[Data Factory] add tumbling window dependsOn property under stable #3445

haoyingli · 2018-07-19T02:24:20Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…me changes to stable

AutorestCI · 2018-07-19T02:25:18Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-07-19T02:25:47Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-07-19T02:28:30Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3449

AutorestCI · 2018-07-19T02:29:34Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-07-19T02:31:43Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2566

annatisch · 2018-07-30T15:31:31Z

@haoyingli - do you have a timeline in mind for when this can be merged?

haoyingli · 2018-07-31T21:55:59Z

We're waiting for our backend code to be deployed in production first. The next scheduled deployment we get from ADF team is end of the week

azuresdkci · 2018-07-31T21:56:00Z

Can one of the admins verify this patch?

annatisch · 2018-07-31T21:57:50Z

Thanks @haoyingli - do you know if you are anticipating any further changes to this spec before the production roll-out finishes? Or is this spec already finalized?

jhendrixMSFT · 2018-08-01T22:29:27Z

@AutorestCI regenerate azure-sdk-for-go

annatisch · 2018-08-23T23:50:57Z

@haoyingli - any updates on the status of this PR?

haoyingli · 2018-08-24T01:21:49Z

We were waiting for backend code to be deployed in production first, and finally it is deployed.
I will merge with latest code tomorrow, and once it's approved, we would be good to merge to master

haoyingli · 2018-08-25T00:08:01Z

Hi, we are ready to merge the swagger. Could you please review it and let us know if it's OK to be merged to master?

annatisch · 2018-08-27T14:32:26Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Trigger.json

+      ],
+      "properties": {
+        "offset": {
+          "description": "Timespan applied to the start time of a tumbling window when evaluating dependency, .Net timespan format.",


Terms like ".Net timespan" will be very confusing to uses of clients generated in other languages. Please use official formatting terminology (e.g. ISO 8601).
If your API does not follow an official standard (which it should) then please supply an example of the formatting that needs to be supplied.

Is there a reason you're not using the swagger supported duration type rather than string?

This property "offset" is input through UI. Users have option for offset in hours, and enter the number of hour users like. Internally we use .Net for this project, and parse the offset from UI into .net timespan.

Thanks @haoyingli - but the swagger must be agnostic of any particular language - please remove references to .Net

annatisch · 2018-08-27T14:39:54Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Trigger.json

+          "maxLength": 15
+        },
+        "size": {
+          "description": "The size of the window when evaluating the dependency. If undefined the frequency of the tumbling window will be used, .Net timespan format.",


Same comment as above.

annatisch · 2018-08-27T14:40:00Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Trigger.json

+      ],
+      "properties": {
+        "offset": {
+          "description": "Timespan applied to the start time of a tumbling window when evaluating dependency, .Net timespan format.",


Same comment as above.

annatisch · 2018-08-27T14:40:06Z

...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Trigger.json

+          "maxLength": 15
+        },
+        "size": {
+          "description": "The size of the window when evaluating the dependency. If undefined the frequency of the tumbling window will be used, .Net timespan format.",


Same comment as above.

haoyingli · 2018-08-28T23:03:15Z

I've updated the description. The format of timespan is internal only, should not expose to outside.

annatisch

LGTM - thanks!

revert tumbling window dependsOn property under preview, and apply sa…

da77fb4

…me changes to stable

haoyingli changed the title ~~revert tumbling window dependsOn property under preview, and apply sa…~~ [Do not merge] [Data Factory] add tumbling window dependsOn property under stable Jul 19, 2018

azuresdkci assigned annatisch Jul 19, 2018

azuresdkci requested a review from annatisch July 19, 2018 02:25

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR datafactory/resource-manager] revert tumbling window dependsOn property under preview, and apply sa… Azure/azure-sdk-for-python#2956

Merged

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR datafactory/resource-manager] revert tumbling window dependsOn property under preview, and apply sa… Azure/azure-sdk-for-node#3196

Closed

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR datafactory/resource-manager] revert tumbling window dependsOn property under preview, and apply sa… Azure/azure-sdk-for-java#2239

Merged

AutorestCI mentioned this pull request Jul 19, 2018

[AutoPR datafactory/resource-manager] revert tumbling window dependsOn property under preview, and apply sa… Azure/azure-sdk-for-go#2264

Closed

AutorestCI mentioned this pull request Aug 1, 2018

[AutoPR datafactory/resource-manager] [Do not merge] [Data Factory] add tumbling window dependsOn property under stable Azure/azure-sdk-for-go#2368

Merged

annatisch requested changes Aug 27, 2018

View reviewed changes

update description

1253768

annatisch approved these changes Aug 29, 2018

View reviewed changes

annatisch merged commit 219ba00 into Azure:master Aug 29, 2018

haoyingli changed the title ~~[Do not merge] [Data Factory] add tumbling window dependsOn property under stable~~ [Data Factory] add tumbling window dependsOn property under stable Aug 29, 2018

haoyingli mentioned this pull request Sep 5, 2018

[data factory] add tumblingWindowTrigger dependsOn and add Folder to pipeline and da… Azure/azure-sdk-for-net#4741

Merged

9 tasks

[Data Factory] add tumbling window dependsOn property under stable #3445

[Data Factory] add tumbling window dependsOn property under stable #3445

Uh oh!

Conversation

haoyingli commented Jul 19, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

annatisch commented Jul 30, 2018

Uh oh!

haoyingli commented Jul 31, 2018

Uh oh!

azuresdkci commented Jul 31, 2018

Uh oh!

annatisch commented Jul 31, 2018

Uh oh!

jhendrixMSFT commented Aug 1, 2018

Uh oh!

annatisch commented Aug 23, 2018

Uh oh!

haoyingli commented Aug 24, 2018

Uh oh!

haoyingli commented Aug 25, 2018

Uh oh!

annatisch Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

haoyingli Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 27, 2018

Choose a reason for hiding this comment

Uh oh!

haoyingli commented Aug 28, 2018

Uh oh!

annatisch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

haoyingli commented Jul 19, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading

AutorestCI commented Jul 19, 2018 •

edited

Loading