Skip to content

Add optional connectionName to DatasetVersion #34521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dargilco merged 5 commits into from
May 8, 2025
Merged

Add optional connectionName to DatasetVersion #34521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9608da1
First
dargilco May 8, 2025
c920210
Updates
dargilco May 8, 2025
7cc5aa8
Update specification/ai/Azure.AI.Projects/datasets/models.tsp
dargilco May 8, 2025
65c54d1
Update specification/ai/Azure.AI.Projects/datasets/models.tsp
dargilco May 8, 2025
7f2d7e3
Follow up on Neehar's comments
dargilco May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/ai/Azure.AI.Projects/common/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ model PendingUploadRequest {
@doc("If PendingUploadId is not provided, a random GUID will be used.")
pendingUploadId?: string;

@doc("Name of Azure blob storage connection to use for generating temporary SAS token")
@doc("Azure Storage Account connection name to use for generating temporary SAS token")
connectionName?: string;

@doc("BlobReference is the only supported type.")
Expand Down
6 changes: 5 additions & 1 deletion specification/ai/Azure.AI.Projects/datasets/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,14 @@ model DatasetVersion {
@doc("Dataset type")
type: DatasetType;

@doc("Indicates if dataset is reference only or managed by dataset service. If true, the underlying data will be deleted when the dataset version is deleted")
@doc("Indicates if the dataset holds a reference to the storage, or the dataset manages storage itself. If true, the underlying data will not be deleted when the dataset version is deleted")
@visibility(Lifecycle.Read)
isReference?: boolean;

@doc("The Azure Storage Account connection name. Required if startPendingUploadVersion was not called before creating the Dataset")
@visibility(Lifecycle.Read, Lifecycle.Create)
connectionName?: string;

...AssetBase;
}

Expand Down
12 changes: 10 additions & 2 deletions ...ication/ai/data-plane/Azure.AI.Projects/preview/2025-05-15-preview/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,9 +2211,17 @@
},
"isReference": {
"type": "boolean",
"description": "Indicates if dataset is reference only or managed by dataset service. If true, the underlying data will be deleted when the dataset version is deleted",
"description": "Indicates if the dataset holds a reference to the storage, or the dataset manages storage itself. If true, the underlying data will not be deleted when the dataset version is deleted",
"readOnly": true
},
"connectionName": {
"type": "string",
"description": "The Azure Storage Account connection name. Required if startPendingUploadVersion was not called before creating the Dataset",
"x-ms-mutability": [
"read",
"create"
]
},
"id": {
"type": "string",
"description": "Asset ID, a unique identifier for the asset",
Expand Down Expand Up @@ -2937,7 +2945,7 @@
},
"connectionName": {
"type": "string",
"description": "Name of Azure blob storage connection to use for generating temporary SAS token"
"description": "Azure Storage Account connection name to use for generating temporary SAS token"
},
"pendingUploadType": {
"type": "string",
Expand Down
12 changes: 10 additions & 2 deletions specification/ai/data-plane/Azure.AI.Projects/stable/2025-05-01/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,9 +1528,17 @@
},
"isReference": {
"type": "boolean",
"description": "Indicates if dataset is reference only or managed by dataset service. If true, the underlying data will be deleted when the dataset version is deleted",
"description": "Indicates if the dataset holds a reference to the storage, or the dataset manages storage itself. If true, the underlying data will not be deleted when the dataset version is deleted",
"readOnly": true
},
"connectionName": {
"type": "string",
"description": "The Azure Storage Account connection name. Required if startPendingUploadVersion was not called before creating the Dataset",
"x-ms-mutability": [
"read",
"create"
]
},
"id": {
"type": "string",
"description": "Asset ID, a unique identifier for the asset",
Expand Down Expand Up @@ -2097,7 +2105,7 @@
},
"connectionName": {
"type": "string",
"description": "Name of Azure blob storage connection to use for generating temporary SAS token"
"description": "Azure Storage Account connection name to use for generating temporary SAS token"
},
"pendingUploadType": {
"type": "string",
Expand Down
12 changes: 10 additions & 2 deletions specification/ai/data-plane/Azure.AI.Projects/stable/v1/azure-ai-projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,9 +1528,17 @@
},
"isReference": {
"type": "boolean",
"description": "Indicates if dataset is reference only or managed by dataset service. If true, the underlying data will be deleted when the dataset version is deleted",
"description": "Indicates if the dataset holds a reference to the storage, or the dataset manages storage itself. If true, the underlying data will not be deleted when the dataset version is deleted",
"readOnly": true
},
"connectionName": {
"type": "string",
"description": "The Azure Storage Account connection name. Required if startPendingUploadVersion was not called before creating the Dataset",
"x-ms-mutability": [
"read",
"create"
]
},
"id": {
"type": "string",
"description": "Asset ID, a unique identifier for the asset",
Expand Down Expand Up @@ -2097,7 +2105,7 @@
},
"connectionName": {
"type": "string",
"description": "Name of Azure blob storage connection to use for generating temporary SAS token"
"description": "Azure Storage Account connection name to use for generating temporary SAS token"
},
"pendingUploadType": {
"type": "string",
Expand Down
Loading