Skip to content

Conversation

@mohabghanem
Copy link
Contributor

@mohabghanem mohabghanem commented Jul 19, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3035

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 19, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2343

@mohabghanem
Copy link
Contributor Author

@sergey-shandar Can you please review the pull request?

@sergey-shandar
Copy link
Contributor

@DavidLiCIG @felixwa please, review.

@felixwa
Copy link
Contributor

felixwa commented Jul 27, 2018

@yangyuan

Copy link
Contributor

@felixwa felixwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-shandar, this looks good to me. In future please include @yangyuan as reviewer for all Cognitive Services swagger file review. Thanks!

@mohabghanem
Copy link
Contributor Author

@sergey-shandar Any notes preventing this pull request form being merged?

@sergey-shandar
Copy link
Contributor

@felixwa I've updated codeowners, please review #3540

@sergey-shandar
Copy link
Contributor

@mohabghanem no, I was waiting for code-owners approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants