Skip to content

updated description of sku name values #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hovsepm merged 2 commits into from
Jul 20, 2018
Merged

updated description of sku name values #3467

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7926680
updated description of sku name values
tfitzmac Jul 20, 2018
420480d
added default sku name value
tfitzmac Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
updated description of sku name values
  • Loading branch information
@tfitzmac
tfitzmac committed Jul 20, 2018
commit 792668040100073bf8be812c1ae2360198b539c0
2 changes: 1 addition & 1 deletion specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5909,7 +5909,7 @@
"properties": {
"name": {
"type": "string",
"description": "The sku name."
"description": "The sku name. Use **Aligned** for managed disks, and **Classic** for unmanaged disks."
Copy link

@smotwani smotwani Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the description of storageAccountType under ManagedDiskParameters. In order to be consistent with documentation I believe this should be updated to
The sku name. Possible values are: Aligned for managed disks, and Classic for unmanaged disks. Default value is Classic if not specified.

Copy link
Contributor

@shandilvarun shandilvarun Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Sameer's comment on adding a default text to let customers know default values.

},
"tier": {
"type": "string",
Expand Down