Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated readme, advisor json file to reflect right exmaples
  • Loading branch information
mojayara committed May 20, 2025
commit 1571009c592b11b5183f0203b1333c63d0a0985c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/advisor/resource-manager/Microsoft.Advisor/preview/2025-05-01-preview/advisor.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.

Check failure on line 1 in specification/advisor/resource-manager/Microsoft.Advisor/preview/2025-05-01-preview/advisor.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/advisor/resource-manager/Microsoft.Advisor/preview/2025-05-01-preview/advisor.json#L1

specification/advisor/resource-manager/Microsoft.Advisor/preview/2025-05-01-preview/advisor.json(1,1): error : Code style issues found, please run prettier. > npm install > npx prettier --write specification/advisor/resource-manager/Microsoft.Advisor/preview/2025-05-01-preview/advisor.json
"swagger": "2.0",
"info": {
"version": "2025-05-01-preview",
Expand Down Expand Up @@ -404,7 +404,7 @@
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.Advisor/recommendations": {
"/{resourceUri}/providers/Microsoft.Advisor/recommendations": {
"get": {
"tags": [
"GetRecommendations"
Expand All @@ -413,7 +413,7 @@
"operationId": "Recommendations_List",
"parameters": [
{
"$ref": "#/parameters/subscriptionIdParameter"
"$ref": "#/parameters/resourceUriParameter"
},
{
"$ref": "#/parameters/apiVersionParameter"
Expand Down Expand Up @@ -460,8 +460,11 @@
"nextLinkName": "nextLink"
},
"x-ms-examples": {
"ListRecommendations": {
"$ref": "./examples/ListRecommendations.json"
"ListRecommendationsSubscriptionResourceUri": {
"$ref": "./examples/ListRecommendationsSubscriptionResourceUri.json"
},
"ListRecommendationsServiceGroupResourceUri": {
"$ref": "./examples/ListRecommendationsServiceGroupResourceUri.json"
}
}
}
Expand Down Expand Up @@ -545,8 +548,11 @@
},
"deprecated": false,
"x-ms-examples": {
"GetRecommendationDetail": {
"$ref": "./examples/GetRecommendationDetail.json"
"GetRecommendationDetailSubscriptionResourceUri": {
"$ref": "./examples/GetRecommendationDetailSubscriptionResourceUri.json"
},
"GetRecommendationDetailServiceGroupResourceUri": {
"$ref": "./examples/GetRecommendationDetailServiceGroupResourceUri.json"
}
}
},
Expand Down Expand Up @@ -1872,6 +1878,13 @@
"required": true,
"type": "string"
},
"resourceUriParameter" :{
"name": "resourceUri",
"in": "path",
"description": "The fully qualified Azure Resource Manager identifier of the resource to which the recommendation applies.",
"required": true,
"type": "string"
},
"apiVersionParameter": {
"name": "api-version",
"in": "query",
Expand Down
26 changes: 25 additions & 1 deletion specification/advisor/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,31 @@ These are the global settings for the Advisor API.

``` yaml
openapi-type: arm
tag: package-2024-11-preview
tag: package-2025-05-preview
```

### Tag: package-2025-05-preview
These settings apply only when `--tag=package-2025-05-preview` is specified on the command line.

```yaml $(tag) == 'package-2025-05-preview'
input-file:
- Microsoft.Advisor/preview/2025-05-01-preview/advisor.json
- Microsoft.Advisor/preview/2025-05-01-preview/assessments.json
- Microsoft.Advisor/preview/2025-05-01-preview/resiliencyReviews.json
suppressions:
- code: ArmResourcePropertiesBag
reason: Suppressing for now to avoid breaking change.
from:
- assessments.json
where:
- $.definitions["AssessmentResult"]
- code: RequiredPropertiesMissingInResourceModel
reason: Suppressing for now to avoid breaking change.
from:
- assessments.json
where:
- $.definitions["AssessmentTypeListResult"]
- $.definitions["WorkloadListResult"]
```

### Tag: package-2024-11-preview
Expand Down
Loading