Skip to content

Adding AvailabilityZone Field to Machine API #34906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FumingZhang merged 8 commits into from
May 28, 2025
Merged

Adding AvailabilityZone Field to Machine API #34906

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7fe3a7c
Adding AvailabilityZone Field to Machine API
skuchipudi295 May 23, 2025
5ac702e
fixedlint err
skuchipudi295 May 23, 2025
3a6ba47
changing to zones: []string{}
skuchipudi295 May 23, 2025
df7e940
fixing format
skuchipudi295 May 23, 2025
59b067a
fixing format
skuchipudi295 May 23, 2025
11f8298
making zones a top level property
skuchipudi295 May 23, 2025
ac1f4c3
fixing format
skuchipudi295 May 23, 2025
a0feb4c
fixing format
skuchipudi295 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changing to zones: []string{}
  • Loading branch information
@skuchipudi295
skuchipudi295 committed May 23, 2025
commit 3a6ba47078704ddbc26d5241254838a5f3a8a2b5
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineGet.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineGet.json#L1 

specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineGet.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineGet.json
"parameters": {
"api-version": "2025-04-01",
"subscriptionId": "26fe00f8-9173-4872-9134-bb1d2e00343a",
Expand Down Expand Up @@ -27,7 +27,7 @@
]
},
"resourceId": "/subscriptions/26fe00f8-9173-4872-9134-bb1d2e00343a/resourceGroups/dummyRG/providers/Microsoft.Compute/virtualMachineScaleSets/aks-nodepool1-25481572-vmss/virtualMachines/0",
"availabilityZone": "1"
"zones": ["1"],
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...source-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineList.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineList.json#L1 

specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineList.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/examples/MachineList.json
"parameters": {
"api-version": "2025-04-01",
"subscriptionId": "26fe00f8-9173-4872-9134-bb1d2e00343a",
Expand Down Expand Up @@ -28,7 +28,7 @@
]
},
"resourceId": "/subscriptions/26fe00f8-9173-4872-9134-bb1d2e00343a/resourceGroups/dummyRG/providers/Microsoft.Compute/virtualMachineScaleSets/aks-nodepool1-25481572-vmss/virtualMachines/0",
"availabilityZone": "1"
"zones": ["1"]
}
}
],
Expand Down
10 changes: 7 additions & 3 deletions ...ce/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/managedClusters.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.

Check failure on line 1 in specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/managedClusters.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/managedClusters.json#L1 

specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/managedClusters.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2025-04-01/managedClusters.json
"swagger": "2.0",
"info": {
"title": "ContainerServiceClient",
Expand Down Expand Up @@ -8218,10 +8218,14 @@
"readOnly": true,
"type": "string"
},
"availabilityZone": {
"description": "The availability zone where the machine is present. If not set, the VM is not zonal",
"zones": {
"type": "array",
"items": {
"type": "string"
}
},
"readOnly": true,
"description": "The Availability zone in which node is located."
}
},
"readOnly": true,
"type": "object"
Expand Down
Loading