Skip to content

[tsp] get rid of new no-unnamed-types warnings #35126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheeguerin merged 5 commits into from
Jun 5, 2025
Merged

[tsp] get rid of new no-unnamed-types warnings #35126

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32b1b2e
fix new specs with unnamed types
Jun 5, 2025
09450d0
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …
Jun 5, 2025
fa07807
Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …
Jun 5, 2025
57e20a0
whitespace differences
Jun 5, 2025
59a2372
suppress to avoid breaking change
Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions specification/keyvault/Security.KeyVault.Common/common.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ alias KeyVaultOperation<
* The key vault server error.
*/
#suppress "@azure-tools/typespec-azure-core/no-nullable" "Intentionally nullable model"
#suppress "@azure-tools/typespec-client-generator-core/no-unnamed-types" "Backcompatibility with existing clients"
union Error {
null,
#suppress "@azure-tools/typespec-client-generator-core/no-unnamed-types" "Backcompatibility with existing clients"
{
/**
* The error code.
Expand Down
53 changes: 29 additions & 24 deletions ...onlineexperimentation/OnlineExperimentation.Management/OnlineExperimentationWorkspace.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,34 @@ model OnlineExperimentationWorkspace
sku?: OnlineExperimentationWorkspaceSku;
}

/**
* Updatable properties of the online experimentation workspace resource.
*/
model OnlineExperimentationWorkspacePatchProperties {
/**
* The resource identifier of the Log Analytics workspace which online experimentation workspace uses for generating experiment analysis results.
*/
logAnalyticsWorkspaceResourceId?: LogAnalyticsWorkspaceArmResourceId;

/**
* The resource identifier of storage account where logs are exported from Log Analytics workspace. online experimentation workspace uses it generating experiment analysis results.
*/
logsExporterStorageAccountResourceId?: StorageAccountArmResourceId;

/**
* The encryption configuration for the online experimentation workspace resource.
*/
encryption?: ResourceEncryptionConfiguration;

/**
* Public Network Access Control for the online experimentation resource. Defaults to Enabled if set to null.
* - Enabled: The resource can be accessed from the public internet.
* - Disabled: The resource can only be accessed from a private endpoint.
*/
@added(Microsoft.OnlineExperimentation.Versions.v2025_08_01_preview)
publicNetworkAccess?: PublicNetworkAccessType;
}

/**
* Partial update of an online experimentation workspace resource.
*/
Expand All @@ -45,30 +73,7 @@ model OnlineExperimentationWorkspacePatch {
/**
* Updatable properties of the online experimentation workspace resource.
*/
properties?: {
/**
* The resource identifier of the Log Analytics workspace which online experimentation workspace uses for generating experiment analysis results.
*/
logAnalyticsWorkspaceResourceId?: LogAnalyticsWorkspaceArmResourceId;

/**
* The resource identifier of storage account where logs are exported from Log Analytics workspace. online experimentation workspace uses it generating experiment analysis results.
*/
logsExporterStorageAccountResourceId?: StorageAccountArmResourceId;

/**
* The encryption configuration for the online experimentation workspace resource.
*/
encryption?: ResourceEncryptionConfiguration;

/**
* Public Network Access Control for the online experimentation resource. Defaults to Enabled if set to null.
* - Enabled: The resource can be accessed from the public internet.
* - Disabled: The resource can only be accessed from a private endpoint.
*/
@added(Microsoft.OnlineExperimentation.Versions.v2025_08_01_preview)
publicNetworkAccess?: PublicNetworkAccessType;
};
properties?: OnlineExperimentationWorkspacePatchProperties;
}

@armResourceOperations
Expand Down
62 changes: 33 additions & 29 deletions ...soft.OnlineExperimentation/preview/2025-05-31-preview/OnlineExperimentationWorkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,38 +602,42 @@
"description": "The SKU (Stock Keeping Unit) assigned to this resource."
},
"properties": {
"type": "object",
"description": "Updatable properties of the online experimentation workspace resource.",
"properties": {
"logAnalyticsWorkspaceResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of the Log Analytics workspace which online experimentation workspace uses for generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.OperationalInsights/workspaces"
}
]
"$ref": "#/definitions/OnlineExperimentationWorkspacePatchProperties",
"description": "Updatable properties of the online experimentation workspace resource."
}
}
},
"OnlineExperimentationWorkspacePatchProperties": {
"type": "object",
"description": "Updatable properties of the online experimentation workspace resource.",
"properties": {
"logAnalyticsWorkspaceResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of the Log Analytics workspace which online experimentation workspace uses for generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.OperationalInsights/workspaces"
}
},
"logsExporterStorageAccountResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of storage account where logs are exported from Log Analytics workspace. online experimentation workspace uses it generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Storage/storageAccounts"
}
]
]
}
},
"logsExporterStorageAccountResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of storage account where logs are exported from Log Analytics workspace. online experimentation workspace uses it generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Storage/storageAccounts"
}
},
"encryption": {
"$ref": "#/definitions/ResourceEncryptionConfiguration",
"description": "The encryption configuration for the online experimentation workspace resource."
}
]
}
},
"encryption": {
"$ref": "#/definitions/ResourceEncryptionConfiguration",
"description": "The encryption configuration for the online experimentation workspace resource."
}
}
},
Expand Down
70 changes: 37 additions & 33 deletions ...soft.OnlineExperimentation/preview/2025-08-01-preview/OnlineExperimentationWorkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,42 +960,46 @@
"description": "The SKU (Stock Keeping Unit) assigned to this resource."
},
"properties": {
"type": "object",
"description": "Updatable properties of the online experimentation workspace resource.",
"properties": {
"logAnalyticsWorkspaceResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of the Log Analytics workspace which online experimentation workspace uses for generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.OperationalInsights/workspaces"
}
]
"$ref": "#/definitions/OnlineExperimentationWorkspacePatchProperties",
"description": "Updatable properties of the online experimentation workspace resource."
}
}
},
"OnlineExperimentationWorkspacePatchProperties": {
"type": "object",
"description": "Updatable properties of the online experimentation workspace resource.",
"properties": {
"logAnalyticsWorkspaceResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of the Log Analytics workspace which online experimentation workspace uses for generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.OperationalInsights/workspaces"
}
},
"logsExporterStorageAccountResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of storage account where logs are exported from Log Analytics workspace. online experimentation workspace uses it generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Storage/storageAccounts"
}
]
]
}
},
"logsExporterStorageAccountResourceId": {
"type": "string",
"format": "arm-id",
"description": "The resource identifier of storage account where logs are exported from Log Analytics workspace. online experimentation workspace uses it generating experiment analysis results.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Storage/storageAccounts"
}
},
"encryption": {
"$ref": "#/definitions/ResourceEncryptionConfiguration",
"description": "The encryption configuration for the online experimentation workspace resource."
},
"publicNetworkAccess": {
"$ref": "#/definitions/PublicNetworkAccessType",
"description": "Public Network Access Control for the online experimentation resource. Defaults to Enabled if set to null.\n- Enabled: The resource can be accessed from the public internet.\n- Disabled: The resource can only be accessed from a private endpoint."
}
]
}
},
"encryption": {
"$ref": "#/definitions/ResourceEncryptionConfiguration",
"description": "The encryption configuration for the online experimentation workspace resource."
},
"publicNetworkAccess": {
"$ref": "#/definitions/PublicNetworkAccessType",
"description": "Public Network Access Control for the online experimentation resource. Defaults to Enabled if set to null.\n- Enabled: The resource can be accessed from the public internet.\n- Disabled: The resource can only be accessed from a private endpoint."
}
}
},
Expand Down
1 change: 1 addition & 0 deletions specification/orbital/Microsoft.PlanetaryComputer/inma.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ namespace StacItems {
* This union allows the request body to accept either a single Item or a collection of Items.
*/
#suppress "@azure-tools/typespec-autorest/union-unsupported" ""
#suppress "@azure-tools/typespec-client-generator-core/no-unnamed-types" "Backcompatibility with existing clients"
@body
body: StacItem | ItemCollection,
): {
Expand Down
1 change: 1 addition & 0 deletions specification/orbital/Microsoft.PlanetaryComputer/models.stac.spec.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ model Link {
* Specifies the HTTP method that the resource expects.
* Default: GET.
*/
#suppress "@azure-tools/typespec-azure-client-generator-core/no-unnamed-types" "Backcompatibility with existing clients"
method?: "GET" | "POST" | string = "GET";

/**
Expand Down
Loading