Skip to content

Fix LocalDNSProfile to model vnet/kubeDNSOverrides as maps #35580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FumingZhang merged 3 commits into from
Jul 2, 2025
Merged

Fix LocalDNSProfile to model vnet/kubeDNSOverrides as maps #35580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76fc69c
Fix LocalDNSProfile to model vnet/kubeDNSOverrides as maps
SriHarsha001 Jul 1, 2025
a8956af
Add violation suppression block for LocalDNSOverrides
SriHarsha001 Jul 1, 2025
744f0da
Update the description
SriHarsha001 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...ce-manager/Microsoft.ContainerService/aks/preview/2025-05-02-preview/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2025-05-02-preview/managedClusters.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "ContainerServiceClient",
Expand Down Expand Up @@ -8230,6 +8230,13 @@
}
},
"LocalDNSOverrides": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/LocalDNSOverride"
},
"description": "LocalDNSOverrides is a map of zone names for Vnet and Kube DNS overrides."
},
"LocalDNSOverride": {
"type": "object",
"description": "Overrides for localDNS profile.",
"properties": {
Expand Down Expand Up @@ -8374,7 +8381,7 @@
]
},
"description": "Policy for serving stale data. See [cache plugin](https://coredns.io/plugins/cache) for more information.",
"default": "Verify"
"default": "Immediate"
}
}
},
Expand Down
4 changes: 4 additions & 0 deletions ...tion/containerservice/resource-manager/Microsoft.ContainerService/aks/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,4 +1357,8 @@ directive:
from: managedClusters.json
where: $.definitions.MachineKubernetesProfile.properties.nodeLabels
reason: User defined custom key-value pairs, similar to the allowed "user defined tags." These pairs can have any value, as there is no validation on the values
- suppress: AvoidAdditionalProperties
from: managedClusters.json
where: $.definitions.LocalDNSOverrides
reason: User defined custom key-value pairs, similar to the allowed "user defined tags." These pairs can have any value, as there is no validation on the values
```
Loading