Back compat fixes

specification/resources/DeploymentStacks.Management/back-compat.tsp

@@ -3,30 +3,10 @@ import "@typespec/openapi";
 import "./routes.tsp";
 
 using Azure.ClientGenerator.Core;
-using Azure.ResourceManager;
-using TypeSpec.Http;
 using TypeSpec.OpenAPI;
-using TypeSpec.Rest;
 
 namespace Microsoft.Resources.DeploymentStacks;
 
-/**
- * The management group name path parameter.
- */
-model ManagementGroupIdParameter {
-  /** The name of the management group. The name is case insensitive. */
-  @path
-  @minLength(1)
-  @maxLength(90)
-  @segment("providers/Microsoft.Management/managementGroups")
-  managementGroupId: string;
-}
-
-model ManagementGroupBaseParameters
-  is Azure.ResourceManager.Foundations.TenantBaseParameters {
-  ...ManagementGroupIdParameter
-}
-
 #suppress "deprecated" "Backwards compat with old swagger"
 @@flattenProperty(DeploymentStack.properties);
 

specification/resources/DeploymentStacks.Management/routeTypes.tsp

@@ -6,10 +6,26 @@ import "./models.tsp";
 
 using TypeSpec.Http;
 using TypeSpec.Rest;
-using Azure.ResourceManager;
 
 namespace Microsoft.Resources.DeploymentStacks;
 
+/**
+ * The management group name path parameter.
+ */
+model ManagementGroupIdParameter {
+  /** The name of the management group. The name is case insensitive. */
+  @path
+  @minLength(1)
+  @maxLength(90)
+  @segment("providers/Microsoft.Management/managementGroups")
+  managementGroupId: string;
+}
+
+model ManagementGroupIdBaseParameters
+  is Azure.ResourceManager.Foundations.TenantBaseParameters {
+  ...ManagementGroupIdParameter;
+}
+
 @doc("Resource validation failed.")
 // TODO: This property isn't being output in the open API definition. Not sure if it's obsolete now. It was explicitly set on the 400 responses to `false` and I believe it influences SDK code generation by returning a response vs throwing an exception.
 //@extension("x-ms-error-response", false)

specification/resources/DeploymentStacks.Management/routes.tsp

@@ -71,4 +71,4 @@ interface DeploymentStacksAtSubscription
 
 @armResourceOperations
 interface DeploymentStacksAtManagementGroup
-  extends DeploymentStackCommonOps<ManagementGroupBaseParameters> {}
+  extends DeploymentStackCommonOps<ManagementGroupIdBaseParameters> {}

specification/resources/resource-manager/Microsoft.Resources/deploymentStacks/stable/2024-03-01/deploymentStacks.json

@@ -50,7 +50,7 @@
     }
   ],
   "paths": {
-    "/providers/Microsoft.Management/managementGroups/{managementGroupName}/providers/Microsoft.Resources/deploymentStacks": {
+    "/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Resources/deploymentStacks": {
       "get": {
         "operationId": "DeploymentStacks_ListAtManagementGroup",
         "tags": [
@@ -62,7 +62,7 @@
             "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
           },
           {
-            "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ManagementGroupNameParameter"
+            "$ref": "#/parameters/ManagementGroupIdParameter"
           }
         ],
         "responses": {
@@ -89,7 +89,7 @@
         }
       }
     },
-    "/providers/Microsoft.Management/managementGroups/{managementGroupName}/providers/Microsoft.Resources/deploymentStacks/{deploymentStackName}": {
+    "/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Resources/deploymentStacks/{deploymentStackName}": {
       "get": {
         "operationId": "DeploymentStacks_GetAtManagementGroup",
         "tags": [
@@ -101,7 +101,7 @@
             "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
           },
           {
-            "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ManagementGroupNameParameter"
+            "$ref": "#/parameters/ManagementGroupIdParameter"
           },
           {
             "name": "deploymentStackName",
@@ -145,7 +145,7 @@
             "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
           },
           {
-            "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ManagementGroupNameParameter"
+            "$ref": "#/parameters/ManagementGroupIdParameter"
           },
           {
             "name": "deploymentStackName",
@@ -219,7 +219,7 @@
             "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
           },
           {
-            "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ManagementGroupNameParameter"
+            "$ref": "#/parameters/ManagementGroupIdParameter"
           },
           {
             "name": "deploymentStackName",
@@ -283,7 +283,7 @@
         "x-ms-long-running-operation": true
       }
     },
-    "/providers/Microsoft.Management/managementGroups/{managementGroupName}/providers/Microsoft.Resources/deploymentStacks/{deploymentStackName}/exportTemplate": {
+    "/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Resources/deploymentStacks/{deploymentStackName}/exportTemplate": {
       "post": {
         "operationId": "DeploymentStacks_ExportTemplateAtManagementGroup",
         "tags": [
@@ -295,7 +295,7 @@
             "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
           },
           {
-            "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ManagementGroupNameParameter"
+            "$ref": "#/parameters/ManagementGroupIdParameter"
           },
           {
             "name": "deploymentStackName",
@@ -329,7 +329,7 @@
         }
       }
     },
-    "/providers/Microsoft.Management/managementGroups/{managementGroupName}/providers/Microsoft.Resources/deploymentStacks/{deploymentStackName}/validate": {
+    "/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Resources/deploymentStacks/{deploymentStackName}/validate": {
       "post": {
         "operationId": "DeploymentStacks_ValidateStackAtManagementGroup",
         "tags": [
@@ -341,7 +341,7 @@
             "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ApiVersionParameter"
           },
           {
-            "$ref": "../../../../../../common-types/resource-management/v6/types.json#/parameters/ManagementGroupNameParameter"
+            "$ref": "#/parameters/ManagementGroupIdParameter"
           },
           {
             "name": "deploymentStackName",
@@ -1948,6 +1948,16 @@
       },
       "x-ms-parameter-location": "method",
       "x-ms-client-name": "unmanageActionResources"
+    },
+    "ManagementGroupIdParameter": {
+      "name": "managementGroupId",
+      "in": "path",
+      "description": "The name of the management group. The name is case insensitive.",
+      "required": true,
+      "type": "string",
+      "minLength": 1,
+      "maxLength": 90,
+      "x-ms-parameter-location": "method"
     }
   }
 }