Skip to content

Conversation

@asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Aug 8, 2018

Remove CostTags from Consumption Specs

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Remove CostTags from Consumption Specs
@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2158

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#3319

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2455

@asarkar84
Copy link
Contributor Author

@marstr Please take a look at this PR.

@marstr
Copy link
Member

marstr commented Aug 8, 2018

Howdy @asarkar84, this is a pretty real breaking change. Can you explain the context as to why the CostTag stuff was added in the first place?

edit: grammar

@asarkar84
Copy link
Contributor Author

Hello @marstr , The consumption cost tags and the cost tags by Cloudyn are similar and conflicting features. We have got instructions to hide this functionality until we decide which one lives. There is no CostTags created until now so it is still safe to hide it.

@marstr
Copy link
Member

marstr commented Aug 8, 2018

Given that this a non-preview API Version, and the swagger has been marked as stable, these sorts of changes should really, really be in a new API Version. They represent fundamental changes to what customers are able to do with your service, and as such is a huge breaking change to anybody trying to use your product regardless of whether or not they're using AutoRest generated clients or curl.

@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 8, 2018
@marstr marstr requested a review from ravbhatnagar August 8, 2018 16:20
@asarkar84
Copy link
Contributor Author

As per the discussion over the email, closing the PR.

@asarkar84 asarkar84 closed this Aug 14, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* Update deviceupdate.json

* Add files via upload

* Add files via upload

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants