Skip to content

adding standard_microsoft in pricing tier #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annatisch merged 1 commit into from
Aug 22, 2018
Merged

adding standard_microsoft in pricing tier #3628

annatisch merged 1 commit into from
Aug 22, 2018

Conversation

@hytao
Copy link
Contributor

@hytao hytao commented Aug 13, 2018 •
edited
Loading

  • Added a new pricing tier "standard_microsoft" in the "Sku" section

@AutorestCI AutorestCI mentioned this pull request Aug 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3184

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 13, 2018

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3402

@AutorestCI AutorestCI mentioned this pull request Aug 13, 2018
Closed
@azuresdkci azuresdkci requested a review from lmazuel August 13, 2018 17:40
@AutorestCI AutorestCI mentioned this pull request Aug 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1564

@AutorestCI AutorestCI mentioned this pull request Aug 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2340

@hytao hytao closed this Aug 13, 2018
@AutorestCI AutorestCI mentioned this pull request Aug 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2517

@hytao hytao reopened this Aug 13, 2018
This was referenced Aug 13, 2018
Merged
Merged
Merged
Merged
@AutorestCI AutorestCI mentioned this pull request Aug 13, 2018
Merged
@lmazuel
Copy link
Member

lmazuel commented Aug 16, 2018

@hytao Is this a new value you added in the current API version live, or a value that was missing in the Swagger since the beginning?

@hytao
Copy link
Contributor Author

hytao commented Aug 20, 2018

Hi @lmazuel , API supports that value since May 2018. Swagger is being updated now to support it through other clients

@johanste
Copy link
Member

johanste commented Aug 20, 2018

Since the enum is marked as modelAsString: true, this change should not require a version bump.

@johanste johanste self-requested a review August 20, 2018 21:38
johanste
johanste approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@johanste johanste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update any api version numbers since this is adding a value to an open ended enum....

@annatisch annatisch merged commit c4aed64 into Azure:master Aug 22, 2018
@hytao hytao mentioned this pull request Aug 28, 2018
Closed
@hytao hytao mentioned this pull request Aug 31, 2018
Merged
@hytao hytao mentioned this pull request Sep 11, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch approved these changes

@johanste johanste johanste approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

+1 more reviewer

@nachakra nachakra nachakra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lmazuel lmazuel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hytao @AutorestCI @azuresdkci @lmazuel @johanste @annatisch @nachakra