Skip to content

Set automated merging requirements met checkrun from summarize-checks #36322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 14 commits into from
Jul 30, 2025
Merged

Set automated merging requirements met checkrun from summarize-checks #36322

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ab96f2e
don't actually update the checks
scbedd Jul 30, 2025
fb6d85d
actually set the check run just make it a a TESTiIGNORE name
scbedd Jul 30, 2025
72102b2
use shared enums!
scbedd Jul 30, 2025
7a6a823
need write permission to checks
scbedd Jul 30, 2025
5d1fcdd
add some output logging
scbedd Jul 30, 2025
00836c0
ensure we don't use the title in the name
scbedd Jul 30, 2025
f6c0882
createCommitStatus
scbedd Jul 30, 2025
39aa888
permissions updates remove unused var
scbedd Jul 30, 2025
c7f008d
find our examples
scbedd Jul 30, 2025
afbad63
apply format, remove dead code
scbedd Jul 30, 2025
92215f8
Merge branch 'main' into summarize-checks-sets-checksuite
scbedd Jul 30, 2025
0192ca6
bail if we don't yet see impact assessment
scbedd Jul 30, 2025
5031506
format updates
scbedd Jul 30, 2025
4ee52a5
update tests for new reality
scbedd Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add some output logging
  • Loading branch information
@scbedd
scbedd committed Jul 30, 2025
commit 5d1fcddd475fa08394cd7e13ae83e06a7f4e9291
66 changes: 45 additions & 21 deletions .github/workflows/src/summarize-checks/summarize-checks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,28 @@ export default async function summarizeChecks({ github, context, core }) {
);
}

/**
* @param {typeof import("@actions/core")} core
* @param {CheckRunData[]} requiredCheckRuns
* @param {CheckRunData[]} fyiCheckRuns
*/
export function outputRunDetails(core, requiredCheckRuns, fyiCheckRuns) {
core.info(
`Observed ${requiredCheckRuns.length} required check runs ${requiredCheckRuns.length > 0 ? ":" : "."}`,
);
requiredCheckRuns.forEach((x) => {
core.info(
`Required check "${x.name}" with status "${x.status}" and conclusion "${x.conclusion}"`,
);
});
core.info(
`Observed ${fyiCheckRuns.length} FYI check runs ${fyiCheckRuns.length > 0 ? ":" : "."}`,
);
fyiCheckRuns.forEach((x) => {
core.info(`FYI check "${x.name}" with status "${x.status}" and conclusion "${x.conclusion}"`);
});
}

/**
* @param {import('@actions/github-script').AsyncFunctionArguments['github']} github
* @param {import('@actions/github').context } context
Expand Down Expand Up @@ -346,6 +368,8 @@ export async function summarizeChecksImpl(
EXCLUDED_CHECK_NAMES,
);

outputRunDetails(core, requiredCheckRuns, fyiCheckRuns);

let labelContext = await updateLabels(labelNames, impactAssessment);

core.info(
Expand All @@ -355,27 +379,27 @@ export async function summarizeChecksImpl(
`Adding labels [${Array.from(labelContext.toAdd).join(", ")}]`,
);

// for (const label of labelContext.toRemove) {
// core.info(`Removing label: ${label} from ${owner}/${repo}#${issue_number}.`);
// await github.rest.issues.removeLabel({
// owner: owner,
// repo: repo,
// issue_number: issue_number,
// name: label,
// });
// }

// if (labelContext.toAdd.size > 0) {
// core.info(
// `Adding labels: ${Array.from(labelContext.toAdd).join(", ")} to ${owner}/${repo}#${issue_number}.`,
// );
// await github.rest.issues.addLabels({
// owner: owner,
// repo: repo,
// issue_number: issue_number,
// labels: Array.from(labelContext.toAdd),
// });
// }
for (const label of labelContext.toRemove) {
core.info(`Removing label: ${label} from ${owner}/${repo}#${issue_number}.`);
// await github.rest.issues.removeLabel({
// owner: owner,
// repo: repo,
// issue_number: issue_number,
// name: label,
// });
}

if (labelContext.toAdd.size > 0) {
core.info(
`Adding labels: ${Array.from(labelContext.toAdd).join(", ")} to ${owner}/${repo}#${issue_number}.`,
);
// await github.rest.issues.addLabels({
// owner: owner,
// repo: repo,
// issue_number: issue_number,
// labels: Array.from(labelContext.toAdd),
// });
}

// adjust labelNames based on labelsToAdd/labelsToRemove
labelNames = labelNames.filter((name) => !labelContext.toRemove.has(name));
Expand Down