Skip to content

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Aug 15, 2018

Description

Adding new API version for Automation 2018-06-30.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Aug 15, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@vrdmr
Copy link
Member Author

vrdmr commented Aug 15, 2018

This change has already been approved by @ravbhatnagar in #3325. @khughes66 and I are creating a new PR with fixes to resolve the Travis issues hit the earlier PR. We'll close #3325 now.

@vrdmr
Copy link
Member Author

vrdmr commented Aug 15, 2018

@marstr This PR is a copy of #3325. I think the PR was too old and did not have all the changes made in Automation's spec, which were causing Travis issues. This new PR has all the changes and passes Travis.

@khughes66
Copy link

@azuresdkci , @jianghaolu : Please review asap. This has been sitting like this for days.

Copy link
Member Author

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marstr marstr requested review from marstr and removed request for jianghaolu August 22, 2018 16:07
@marstr marstr assigned marstr and unassigned jianghaolu Aug 22, 2018
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline with @khughes66, and I've verified that indeed @ravbhatnagar signed off on these changes in the former PR.

@marstr marstr merged commit 4e196d4 into Azure:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants