Skip to content

Conversation

@Am018
Copy link

@Am018 Am018 commented Aug 16, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@Am018 Am018 requested a review from MikhailTryakhov as a code owner August 16, 2018 18:07
@AutorestCI
Copy link

AutorestCI commented Aug 16, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 16, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3413

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 16, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1673

@AutorestCI
Copy link

AutorestCI commented Aug 16, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2804

@AutorestCI
Copy link

AutorestCI commented Aug 16, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3352

@anton-evseev
Copy link
Contributor

@Am018
Copy link
Author

Am018 commented Aug 17, 2018

@number213, I have moved the change to 2018-07-01. Let me know if you see any other issues.

@anton-evseev
Copy link
Contributor

@Am018 I don't know which API version you should target but if you need to add it to 2018-06-01, please also add it to 2018-07-01

@Am018
Copy link
Author

Am018 commented Aug 20, 2018

@number213 , the feature is available from API version 2018-07-01. So I think this should be fine. Is there anything else that I need to do before I can get the approval? Who can approve my PR?

@anton-evseev
Copy link
Contributor

@Am018 try pinging @MikhailTryakhov

@jianghaolu
Copy link
Contributor

@MikhailTryakhov Should this target master or September release?

@jianghaolu
Copy link
Contributor

@MikhailTryakhov Can you please take a look at this if this PR should target master or Network-September-Release. Thanks!

@MikhailTryakhov
Copy link
Contributor

It shouldn't be in both of branches specified.
Please use Network-October-Release branch to push changes

Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-target to the right branch

@jianghaolu
Copy link
Contributor

@Am018 Can you retarget to the right branch please?

@Am018
Copy link
Author

Am018 commented Sep 20, 2018

@MikhailTryakhov, @jianghaolu, I will retarget it to Network-October-Release. However the related feature is already in powershell's network-september-release branch. Can that be an issue?

Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after branch retarget LGTM

Copy link
Contributor

@chandrasekarsrinivasan chandrasekarsrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge

@AutorestCI
Copy link

AutorestCI commented Sep 22, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants