-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Added addressPrefixes to subnet properties #3656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-pythonA PR has been created for you: |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goA PR has been created for you: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
|
FYI current API version is |
|
@number213, I have moved the change to 2018-07-01. Let me know if you see any other issues. |
|
@Am018 I don't know which API version you should target but if you need to add it to 2018-06-01, please also add it to 2018-07-01 |
|
@number213 , the feature is available from API version 2018-07-01. So I think this should be fine. Is there anything else that I need to do before I can get the approval? Who can approve my PR? |
|
@Am018 try pinging @MikhailTryakhov |
|
@MikhailTryakhov Should this target master or September release? |
|
@MikhailTryakhov Can you please take a look at this if this PR should target |
|
It shouldn't be in both of branches specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-target to the right branch
|
@Am018 Can you retarget to the right branch please? |
|
@MikhailTryakhov, @jianghaolu, I will retarget it to Network-October-Release. However the related feature is already in powershell's network-september-release branch. Can that be an issue? |
MikhailTryakhov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after branch retarget LGTM
chandrasekarsrinivasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not merge
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger