Add two missing operation API-s into swagger for integration runtime #3662

zhangyd2015 · 2018-08-17T06:58:41Z

Added two missing operation API-s into swagger to make ARM happy.

Microsoft.DataFactory/factories/integrationRuntimes/linkedIntegrationRuntime/action
Microsoft.DataFactory/factories/integrationruntimes/nodes/read

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-08-17T06:59:36Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-08-17T07:00:06Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

azuresdkci · 2018-08-17T07:00:10Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-17T07:03:30Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3396

AutorestCI · 2018-08-17T07:04:13Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-08-17T07:06:06Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2513

annatisch · 2018-08-20T16:33:05Z

Thanks @zhangyd2015 - there are a number of model validation errors in the examples (both new and old) - could you please take a look?

Thanks!

zhangyd2015 · 2018-08-21T03:42:18Z

@annatisch Fixed model validation errors in new examples.

annatisch

LGTM - just a few tiny grammar errors in the descriptions.

annatisch · 2018-08-21T20:55:56Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          "type": "string"
+        },
+        "dataFactoryLocation": {
+          "description": "The location of the data factory for which the linked integration runtime belong to.",


"The location of the data factory that the linked integration runtime belongs to."

Done. Thanks.

annatisch · 2018-08-21T20:56:24Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          "type": "string"
+        },
+        "dataFactoryName": {
+          "description": "The name of the data factory for which the linked integration runtime belong to.",


"The name of the data factory that the linked integration runtime belongs to."

Done. Thanks.

annatisch · 2018-08-21T20:56:54Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          "type": "string"
+        },
+        "subscriptionId": {
+          "description": "The subscription ID for which the linked integration runtime belong to.",


"The ID of the subscription that the linked integration runtime belongs to."

Done. Thanks.

annatisch · 2018-08-21T20:59:04Z

Thanks @zhangyd2015 - are these new APIs that should be reviewed by ARM? Or are they already live in the service?

zhangyd2015 · 2018-08-22T01:53:10Z

Thanks @annatisch. These APIs are already live in the service, they are used by our internal services, per to ARM compliance, they should be put into swagger. I don't think ARM team need review the two APIs.

Add two API-s to integration runtime

ac46263

zhangyd2015 changed the title ~~Add two API-s to integration runtime~~ Add two missing operation API-s to swagger for integration runtime Aug 17, 2018

zhangyd2015 changed the title ~~Add two missing operation API-s to swagger for integration runtime~~ Add two missing operation API-s into swagger for integration runtime Aug 17, 2018

AutorestCI mentioned this pull request Aug 17, 2018

[AutoPR datafactory/resource-manager] Add two API-s to integration runtime Azure/azure-sdk-for-python#3168

Merged

azuresdkci assigned annatisch Aug 17, 2018

azuresdkci requested a review from annatisch August 17, 2018 07:00

AutorestCI mentioned this pull request Aug 17, 2018

[AutoPR datafactory/resource-manager] Add two API-s to integration runtime Azure/azure-sdk-for-node#3360

Merged

AutorestCI mentioned this pull request Aug 17, 2018

[AutoPR datafactory/resource-manager] Add two API-s to integration runtime Azure/azure-sdk-for-java#2330

Merged

AutorestCI mentioned this pull request Aug 17, 2018

[AutoPR datafactory/resource-manager] Add two API-s to integration runtime Azure/azure-sdk-for-go#2477

Merged

Fixed model validation error for the new APIs

43e8224

annatisch reviewed Aug 21, 2018

View reviewed changes

Improve the properties description per to review comments

5c8e79e

annatisch approved these changes Aug 22, 2018

View reviewed changes

annatisch merged commit 5c2e240 into Azure:master Aug 22, 2018

Add two missing operation API-s into swagger for integration runtime #3662

Add two missing operation API-s into swagger for integration runtime #3662

Uh oh!

Conversation

zhangyd2015 commented Aug 17, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Aug 17, 2018

Uh oh!

AutorestCI commented Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

annatisch commented Aug 20, 2018

Uh oh!

zhangyd2015 commented Aug 21, 2018

Uh oh!

annatisch left a comment

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

zhangyd2015 Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

zhangyd2015 Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

zhangyd2015 Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch commented Aug 21, 2018

Uh oh!

zhangyd2015 commented Aug 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AutorestCI commented Aug 17, 2018 •

edited

Loading

AutorestCI commented Aug 17, 2018 •

edited

Loading

AutorestCI commented Aug 17, 2018 •

edited

Loading

AutorestCI commented Aug 17, 2018 •

edited

Loading

AutorestCI commented Aug 17, 2018 •

edited

Loading