Skip to content

java, dpg, tspconfig, remove wrong emitter-output-dir #36663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 1 commit into from
Aug 14, 2025
Merged

java, dpg, tspconfig, remove wrong emitter-output-dir #36663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion specification/communication/Communication.JobRouter/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ options:
generate-test: true
generate-sample: true
"@azure-tools/typespec-java":
emitter-output-dir: "{java-sdk-folder}/sdk/{service-directory-name}/azure-communication-jobrouter"
Copy link
Member

@catalinaperalta catalinaperalta Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weidongxu-microsoft I dont see why they couldnt they just use this:

emitter-output-dir: "{output-dir}/{service-dir}/azure-communication-jobrouter"

It looks like for some reason they're trying to manually parse and separate out the service-dir instead just using the variable directly.

Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft Aug 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can. But not based on {java-sdk-folder}, as it defined as {project-root}/azure-sdk-for-java/ (where the {project-root} would be in that temp folder).

Yes, I am aware that eventually, this would be the path depends on {output-dir}.

But since the 0.28.0 is released recently, change tspconfig directly to the new pattern, and sync it to SDK repo (we need to sync, because current one causes error in pipeline), this may break dev's workflow (they may be using older version of it -- and that puzzled me a lot when diagnosing on the failure, because my local works fine as I am using the older version of tsp-client), unless properly notified (I will put a notice in java channel).
Hence here I am currently just make it use the old pattern.

PS: here I am trying to resolve an immediate failure in SDK repo, that latest tsp-client would use this wrong emitter-output-dir and then cause error in the pipeline -- there is a pipeline in SDK that involve re-generate code upon PR, here it cannot load the proper file, because the emitter-output-dir is wrong

package-dir: "azure-communication-jobrouter"
namespace: com.azure.communication.jobrouter
partial-update: true
Expand Down
1 change: 0 additions & 1 deletion specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ options:
slice-elements-byval: true
flavor: "azure"
"@azure-tools/typespec-java":
emitter-output-dir: "{project-root}"
Copy link
Member

@catalinaperalta catalinaperalta Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually everyone will be moved to emitter output dir..this should be:

emitter-output-dir: "{output-dir}/{service-dir}/azure-messaging-eventgrid-systemevents"

OR:

emitter-output-dir: "{output-dir}/{service-dir}/{package-dir}"

Copy link
Member

@catalinaperalta catalinaperalta Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for the other instance

Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, we will eventually use the new pattern

namespace: com.azure.messaging.eventgrid.systemevents
package-dir: azure-messaging-eventgrid-systemevents
customization-class: customization/src/main/java/EventGridSystemEventsCustomization.java
Expand Down
1 change: 0 additions & 1 deletion specification/eventgrid/Azure.Messaging.EventGrid/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ options:
namespace: Azure.Messaging.EventGrid.Namespaces
model-namespace: false
"@azure-tools/typespec-java":
emitter-output-dir: "{project-root}/.."
namespace: "com.azure.messaging.eventgrid.namespaces"
package-dir: azure-messaging-eventgrid-namespaces
partial-update: true
Expand Down
Loading