-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add SalesforceV2 partitionOption #36731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SalesforceV2 partitionOption #36731
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
@wenqibu: I think you may need to split this into two PRs, one for data-plane, and one for resource-manager. My understanding is PRs should never contain changes to both data-plane and resource-manager. Your ARM reviewer may be able to confirm or deny this. |
|
Hi, @mikeharder This is our by design process. The data plane and management actually are the same change. And the data plane change for synapse, it's by design and the ADF team and synapse team has reach the agreement. This process is to make sure our change for swagger consistent both in ADF and synapse. So could you pls kindly approve the change? |
I'm not an ARM reviewer. Your PR is in the queue for ARM review. Looking at previous PRs to these specs, they were reviewed by ARM but not data-plane (I don't think), so we can continue doing this going forward. |
|
Please fix the description - fill out the PR template and intake form including due diligence. PR Template: You may need to temporarily create a new PR to get the correct template comment and copy it to the top of this PR. Once you have done that, you will see the intake form you need to fill out. It also has a lot of helpful links and other information to help you successfully complete your PR. (Also github has a way to mark PRs as draft, if this is still draft) |
|
@TimLovellSmith updated, please help approve, thanks |
|
/azp run SDK Validation - JS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: ZiWei Chen <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.