Skip to content

[hardwaresecuritymodules] Change the position of the suppression and remove unnecessary decorators #36854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshao25 merged 2 commits into from
Aug 21, 2025
Merged

[hardwaresecuritymodules] Change the position of the suppression and remove unnecessary decorators #36854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4220555
Change the position of the suppression
melina5656 Aug 21, 2025
829987a
Delete unnecessary decorators
melina5656 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion specification/hardwaresecuritymodules/HardwareSecurityModules.Management/CloudHsmCluster.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace Microsoft.HardwareSecurityModules;
/**
* Resource information with extended details.
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
model CloudHsmCluster
is Azure.ResourceManager.TrackedResource<CloudHsmClusterProperties> {
...ResourceNameParameter<
Expand All @@ -26,11 +25,13 @@ model CloudHsmCluster
/**
* Managed service identity (system assigned and/or user assigned identities)
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
identity?: Azure.ResourceManager.CommonTypes.ManagedServiceIdentity;

/**
* SKU details
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
@visibility(Lifecycle.Read, Lifecycle.Create)
sku?: CloudHsmClusterSku;
}
Expand Down
3 changes: 0 additions & 3 deletions specification/hardwaresecuritymodules/HardwareSecurityModules.Management/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ using Azure.ResourceManager.Foundations;

namespace Microsoft.HardwareSecurityModules;

@@nextLink(CommonTypes.PrivateLinkResourceListResult.nextLink);
@@pageItems(CommonTypes.PrivateLinkResourceListResult.value);

/**
* State of security domain activation
*/
Expand Down