[.github] Remove issue-number artifact from pull_request WFs (#36329)

.github/workflows/breaking-change-code.yaml

@@ -56,15 +56,3 @@ jobs:
           name: "${{ steps.swagger-breaking-change-analyze-code.outputs.versioningReviewLabelName }}"
           # Convert "add/remove" to "true/false"
           value: "${{ steps.swagger-breaking-change-analyze-code.outputs.versioningReviewLabelValue == 'true' }}"
-
-      # Upload artifact with issue number if labels are present and PR number is valid
-      - if: |
-          always() &&
-          (steps.swagger-breaking-change-analyze-code.outputs.breakingChangeReviewLabelName != '' ||
-          steps.swagger-breaking-change-analyze-code.outputs.versioningReviewLabelName != '') &&
-          github.event.pull_request.number > 0
-        name: Upload artifact with issue number
-        uses: ./.github/actions/add-empty-artifact
-        with:
-          name: "issue-number"
-          value: "${{ github.event.pull_request.number }}"

.github/workflows/breaking-change-cross-version-code.yaml

@@ -56,15 +56,3 @@ jobs:
         with:
           name: "${{ steps.breaking-change-cross-version-analyze-code.outputs.versioningReviewLabelName }}"
           value: "${{ steps.breaking-change-cross-version-analyze-code.outputs.versioningReviewLabelValue == 'true' }}"
-
-      # Upload artifact with issue number if labels are present and PR number is valid
-      - if: |
-          always() &&
-          (steps.breaking-change-cross-version-analyze-code.outputs.breakingChangeReviewLabelName != '' ||
-          steps.breaking-change-cross-version-analyze-code.outputs.versioningReviewLabelName != '') &&
-          github.event.pull_request.number > 0
-        name: Upload artifact with issue number
-        uses: ./.github/actions/add-empty-artifact
-        with:
-          name: "issue-number"
-          value: "${{ github.event.pull_request.number }}"

.github/workflows/summarize-impact.yaml

@@ -55,12 +55,3 @@ jobs:
           path: ${{ steps.summarize-impact.outputs.summary }}
           # If the file doesn't exist, just don't add the artifact
           if-no-files-found: ignore
-
-      - if: |
-          always() &&
-          github.event.pull_request.number > 0
-        name: Upload artifact with issue number
-        uses: ./after/.github/actions/add-empty-artifact
-        with:
-          name: "issue-number"
-          value: "${{ github.event.pull_request.number }}"

.github/workflows/test/context.test.js

@@ -295,6 +295,10 @@ describe("extractInputs", () => {
         commit_sha: "abc123",
         per_page: PER_PAGE_MAX,
       });
+
+      // For pull_request, do NOT attempt to extract the issue number from an artifact, since this could be modified
+      // in a fork PR.
+      expect(github.rest.actions.listWorkflowRunArtifacts).toHaveBeenCalledTimes(0);
     },
   );