Skip to content

Conversation

@raniwishahy
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Aug 30, 2025
@github-actions github-actions bot added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 30, 2025
@raniwishahy raniwishahy requested a review from TalFrankel August 30, 2025 23:07
@github-actions
Copy link

github-actions bot commented Aug 30, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger common
Go sdk/resourcemanager/security/armsecurity
Java com.azure.resourcemanager:azure-resourcemanager-security
JavaScript @azure/arm-security

@raniwishahy raniwishahy removed the request for review from TalFrankel August 30, 2025 23:43
@qiaozha
Copy link
Member

qiaozha commented Sep 2, 2025

Approved for avocado error as I don't think the latest preview 2025-07-01-preview has not yet been published to SDK customers yet.

},
"paths": {
"/providers/Microsoft.Security/operations": {
"get": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only new change in this API version ? Not seeing any spec changes as such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramoka178 There are no new changes, operations spec does exist for previous versions (see 2024-10-01-preview) and it does too for 2025-07-01-preview. For some reason the automatic checks require it for some versions but not the others.

@ramoka178 ramoka178 added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 5, 2025
@raniwishahy raniwishahy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 5, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 5, 2025
@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 5, 2025
@ramoka178 ramoka178 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 5, 2025
@raniwishahy raniwishahy added PublishToCustomers Acknowledgement the changes will be published to Azure customers. DoNotMerge <valid label in PR review process> use to hold merge after approval and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Sep 9, 2025
@raniwishahy raniwishahy merged commit 76b1d53 into Azure:main Sep 14, 2025
129 of 131 checks passed
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Sep 18, 2025
…37048)

* Copy Defender for Storage Settings preview spec to stable folder

* Apply changes on top of initial commit: change preview version to new stable + modify readme.md.

* Copy preview operations spec to stable folder

* Change operations preview version to new stable.

* Fix LintDiff error

* Add operations to package

* Fix ModelValidation error

* Add stable version to composite v3 package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants