[Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API #3828

haricr · 2018-09-07T01:56:40Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-07T01:57:12Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-07T01:58:17Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-09-07T02:03:51Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2716

AutorestCI · 2018-09-07T02:05:07Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3529

AutorestCI · 2018-09-07T02:21:18Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2136

azuresdkci · 2018-09-07T02:31:48Z

Can one of the admins verify this patch?

lmazuel · 2018-09-07T20:06:09Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

        "items"
      ]
    },
+    "SetVaraibleActivity": {


lmazuel · 2018-09-07T20:06:23Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

      ]
    },
+    "SetVaraibleActivity": {
+      "x-ms-discriminator-value": "SetVaraible",


lmazuel · 2018-09-07T20:07:01Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

+        "value"
+      ]
+    },
+    "AppendVaraibleActivity": {


lmazuel · 2018-09-07T20:07:07Z

...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json

+      ]
+    },
+    "AppendVaraibleActivity": {
+      "x-ms-discriminator-value": "AppendVaraible",


lmazuel

A few typos

lmazuel · 2018-09-07T23:46:00Z

Hi @haricr
Being the complexity of the object, it would be valuable to have a x-ms-example. Thank you.

hvermis · 2018-09-17T20:57:38Z

Splitting the changes into variables only an the rest. Please review #3917

* Update servicelinker.json, add clientType * fix model check error * format with prettier Co-authored-by: Nan Jiang <[email protected]>

haricr added 4 commits September 6, 2018 12:38

Add Variables, Secure Input and Update Cancel API

9ac1030

Update required property for isrecursive in cancel

bd816e4

Fix errors from Validation

2fc778b

Fix Names for Varaible Type

682ee8d

haricr changed the title ~~[Datafactory] Add Variables and related activities to Pipeline.~~ [Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API Sep 7, 2018

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Variables and related activities to Pipeline. Azure/azure-sdk-for-python#3291

Closed

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Variables and related activities to Pipeline. Azure/azure-sdk-for-go#2635

Closed

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API Azure/azure-sdk-for-node#3529

Closed

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API Azure/azure-sdk-for-java#2373

Closed

azuresdkci assigned lmazuel Sep 7, 2018

azuresdkci requested a review from lmazuel September 7, 2018 02:30

lmazuel reviewed Sep 7, 2018

View reviewed changes

lmazuel requested changes Sep 7, 2018

View reviewed changes

Fix Typos

7a5bc14

hvermis closed this Sep 17, 2018

AutorestCI mentioned this pull request Sep 17, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API Azure/azure-sdk-for-go#2716

Closed

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Update servicelinker.json, add clientType (#3828)

38a7c8a

* Update servicelinker.json, add clientType * fix model check error * format with prettier Co-authored-by: Nan Jiang <[email protected]>

[Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API #3828

[Datafactory] Add Variables, SecureInputs, and Set and Append activities to Pipeline. Add recursive option to cancel API #3828

Uh oh!

Conversation

haricr commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented Sep 7, 2018

Uh oh!

lmazuel Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel left a comment

Choose a reason for hiding this comment

Uh oh!

lmazuel commented Sep 7, 2018

Uh oh!

hvermis commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

haricr commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading