Skip to content

Conversation

@binzhao-chn
Copy link
Contributor

@binzhao-chn binzhao-chn commented Sep 17, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1651

@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3640

@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2753

@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2139

@binzhao-chn binzhao-chn changed the title Add missing enum for aggregation type [Azure monitor] Add missing enum for aggregation type Sep 17, 2018
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar
Copy link
Contributor

@gucalder please, review the PR.

Copy link
Contributor

@gucalder gucalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the comment.

@sergey-shandar
Copy link
Contributor

@gucalder anything else?

@sergey-shandar sergey-shandar merged commit 109c990 into Azure:master Sep 19, 2018
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants