Shorten discriminator type names #4037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you: |
Automation for azure-sdk-for-goA PR has been created for you: |
Contributor
|
Can one of the admins verify this patch? |
The discriminator type names are too long resulting in poor SDK codegen.
jhendrixMSFT
force-pushed
the
monitorfixes
branch
from
1f76ea0 to
f6209cf
Compare
Member
Author
|
@abversqr ping |
Member
Author
|
Closing per offline conversation, the long value is sent over-the-wire. |
mccleanp
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Update diagnostics.json * Update diagnostics.json * Update diagnostics.json * Create Solutions_Search.json * Update diagnostics.json * Update Solutions_Search.json * fix prettier error * Update diagnostics.json * Update diagnostics.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discriminator type names are too long resulting in poor SDK codegen.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger