Add APIs for tumbling window rerun trigger #4060

haoyingli · 2018-10-02T21:41:01Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-10-02T21:41:56Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-10-02T21:42:27Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-10-02T21:42:41Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-10-02T21:46:59Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

AutorestCI · 2018-10-02T21:47:03Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3772

AutorestCI · 2018-10-02T21:49:27Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2893

azuresdkci · 2018-10-02T21:52:01Z

Can one of the admins verify this patch?

dsgouda

This looks like a brand new service endpoint, needs an ARM review.
Terminal status codes for long running operations in particular look a little iffy

dsgouda · 2018-10-03T16:34:36Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+            "$ref": "./examples/RerunTriggers_Create.json"
+          }
+        },
+        "description": "Creates?a?rerun?trigger.",


Please fix the descriptions (is there a reason why ? is used instead of space)

dsgouda · 2018-10-03T16:36:46Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          }
+        },
+        "nextLink": {
+          "description": "The continuation token for getting the next page of results, if any remaining results exist, null otherwise.",


Please mark this as readonly

haoyingli · 2018-10-03T19:30:51Z

Automation for azure-sdk-for-go fails with error "fatal: git fetch-pack: expected ACK/NAK, got '?error: Access denied to IP 104.42.78.222' ". How could I re-run this check?

ravbhatnagar · 2018-10-03T22:21:20Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/RerunTumblingWindowTriggerActionParameters"


cant the same model which is used for response be used here in the request?

The value of RerunTriggerResponse is different than existing response, it's ref of RerunTriggerResource and property is RerunTumblingWindowTrigger

ravbhatnagar · 2018-10-03T22:21:58Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/triggers/{triggerName}/rerunTriggers/{rerunTriggerName}": {


what is the "reruntriggers" resource?

What functionality/scenario does it address?

The rerun trigger addresses the requirement from customers who want to re-run existing trigger past trigger runs, in case if old input data is corrupted and etc. For example, customer created a trigger starting from 6/1/2018-12/31/2018. If the trigger started and ran for a week, then customer found input data is partially missing, and wanted to reprocess this week of data, he would use this function and create a re-run trigger for 6/12018-6/7/2018.

dsgouda · 2018-10-04T22:24:54Z

@jhendrixMSFT Could you take a look at why the Go build is failing

jhendrixMSFT · 2018-10-04T22:27:49Z

@AutorestCI regenerate azure-sdk-for-go

jhendrixMSFT · 2018-10-04T22:33:27Z

@dsgouda it looks like it's a transient error. I asked the bot to regenerate the PR but it seems to be running slow (I have several other PRs still waiting on Go SDK codegen from the bot).

ravbhatnagar · 2018-10-05T00:12:23Z

Looks good. Signing off from ARM side.

dsgouda

Looks good apart from a minor comment

dsgouda · 2018-10-05T15:52:58Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+            "$ref": "#/parameters/triggerName"
+          },
+          {
+            "$ref": "#/parameters/api-version"


nit: Please stick to camelCase convention for the parameter name

This is legacy issue. api-version is defined under parameters for a long time, and all the other APIs refer this parameter as api-version. If we update api-version name, then all APIs using it need to be updated too. Do you think it's still necessary to update it?

We can skip this

jhendrixMSFT · 2018-10-08T17:01:47Z

@AutorestCI regenerate azure-sdk-for-go

haoyingli added 3 commits October 2, 2018 14:08

add API for RerunTumblingWindowTrigger

e8bea3a

remove redudant space

904484b

fix parameter name

307ab1c

AutorestCI mentioned this pull request Oct 2, 2018

[AutoPR datafactory/resource-manager] Add APIs for tumbling window rerun trigger Azure/azure-sdk-for-python#3487

Merged

AutorestCI mentioned this pull request Oct 2, 2018

[AutoPR datafactory/resource-manager] Add APIs for tumbling window rerun trigger Azure/azure-sdk-for-java#2455

Merged

AutorestCI mentioned this pull request Oct 2, 2018

[AutoPR datafactory/resource-manager] Add APIs for tumbling window rerun trigger Azure/azure-sdk-for-node#3752

Merged

AutorestCI mentioned this pull request Oct 2, 2018

[AutoPR datafactory/resource-manager] Add APIs for tumbling window rerun trigger Azure/azure-sdk-for-go#2892

Closed

azuresdkci assigned dsgouda Oct 2, 2018

azuresdkci requested a review from dsgouda October 2, 2018 21:52

update nextLink name

56e0696

dsgouda suggested changes Oct 3, 2018

View reviewed changes

dsgouda added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 3, 2018

1. fix ? in description 2. mark nextLink readonly

6648a0f

ravbhatnagar reviewed Oct 4, 2018

View reviewed changes

AutorestCI mentioned this pull request Oct 4, 2018

[AutoPR datafactory/resource-manager] Add APIs for tumbling window rerun trigger Azure/azure-sdk-for-go#2909

Merged

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 5, 2018

dsgouda suggested changes Oct 5, 2018

View reviewed changes

dsgouda approved these changes Oct 5, 2018

View reviewed changes

dsgouda merged commit 10cc702 into Azure:master Oct 5, 2018

haoyingli mentioned this pull request Oct 6, 2018

[DataFactory] generate SDK for tumbling window rerun trigger Azure/azure-sdk-for-net#4846

Merged

9 tasks

Add APIs for tumbling window rerun trigger #4060

Add APIs for tumbling window rerun trigger #4060

Uh oh!

Conversation

haoyingli commented Oct 2, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Oct 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Oct 2, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haoyingli commented Oct 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Oct 4, 2018

Uh oh!

jhendrixMSFT commented Oct 4, 2018

Uh oh!

jhendrixMSFT commented Oct 4, 2018

Uh oh!

ravbhatnagar commented Oct 5, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT commented Oct 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading

AutorestCI commented Oct 2, 2018 •

edited

Loading