Introducing New Version 2018-10-01 for Consumption API #4069

parisa-naeimi · 2018-10-03T19:02:27Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ggregatedCost

AutorestCI · 2018-10-03T19:02:57Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#183

AutorestCI · 2018-10-03T19:03:07Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2158

azuresdkci · 2018-10-03T19:03:59Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-03T19:04:55Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-10-03T19:06:47Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1684

AutorestCI · 2018-10-03T19:08:06Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-10-03T19:09:08Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3018

annatisch · 2018-10-03T19:25:04Z

Adding @ravbhatnagar for ARM feedback.

annatisch · 2018-10-10T17:33:57Z

ping @ravbhatnagar

ravbhatnagar

Looks good. Signing off from ARM.

ravbhatnagar · 2018-10-10T19:15:33Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-10-01/consumption.json

+            "type": "string"
+           }
+        },
+		"excludedSubscriptions": {


What are the excluded subscriptions based on?

Checked with Parisa, currently the feature is only supported for EA subs. The excluded subs will show the subs part of management group which are non-EA

annatisch · 2018-10-11T20:16:19Z

@parisa-naeimi - could you please update the readme tags to include the new API version?

parisa-naeimi · 2018-10-11T20:41:46Z

@annatisch Could you please let me know what do you mean by updating readme tags? do you mean I need to update readme.md under resource-manager and if so, do I need to do it manually?

annatisch · 2018-10-11T20:57:40Z

Thanks @parisa-naeimi - yes that's correct:
https://github.com/Azure/azure-rest-api-specs/blob/eceb8b730d20aef8f2602b0e65215685c5648cd3/specification/consumption/resource-manager/readme.md

You can create a new "Tag: package-2018-10" with the path to your new API file.
You can then update the "tag" field under "Basic Information" to your latest version.

In addition to above, each "multi API" SDK will need a specific tag setup:

parisa-naeimi · 2018-10-11T22:42:23Z

@annatisch Thank you very much for providing information. I updated read me tags, please let me know if I need to revisit something.

annatisch · 2018-10-12T15:20:19Z

Thanks @parisa-naeimi - could you please update them for all languages (or at least - every language for which you have a published SDK)? :)

parisa-naeimi · 2018-10-12T21:14:05Z

@annatisch I think I already have added the version to readme files. I do not know what are you referring here or at least let me know what I am missing here.

annatisch · 2018-10-12T21:20:41Z

Thanks @parisa-naeimi - In commit 81df0a1, you have only added a tag for the Java multi-api SDK.
You will need to add additional tags, the update the tags which are used for generation.

So first, add a generic tag at the top of the file, like these ones:
https://github.com/Azure/azure-rest-api-specs/blob/81df0a1f83f74c8afe11331ce788cca62d754569/specification/consumption/resource-manager/readme.md#tag-package-2017-11

Next, update the tag used for standard code gen in the Basic Information at the top here:
https://github.com/Azure/azure-rest-api-specs/blob/81df0a1f83f74c8afe11331ce788cca62d754569/specification/consumption/resource-manager/readme.md#basic-information

Finally, in the same way that you just added a "tag and java", you will need to add a "tag and go" and tag and ruby" sections as well.

Then you will need to list those new tags under each language - for example here in java:
https://github.com/Azure/azure-rest-api-specs/blob/81df0a1f83f74c8afe11331ce788cca62d754569/specification/consumption/resource-manager/readme.md#basic-information

I hope this helps... indeed it is a bit complicated.
In future, you can submit new API version specs using the OpenAPI portal - this will automatically handle all the readme tags for you :)

parisa-naeimi · 2018-10-12T21:36:15Z

@annatisch thank you very much. I think I missed those areas in my first commit. I got it now and updated the readme file. Please let me know if it is good now.

annatisch · 2018-10-12T21:44:13Z

Thanks @parisa-naeimi! The changes look good - but it looks like there is a conflict, could you rebase against master?

# Conflicts: # specification/consumption/resource-manager/readme.md

parisa-naeimi · 2018-10-13T00:45:47Z

@annatisch I got the latest from master branch and resolved conflict. I think we are good now. Please let me know if I need to do something in my side. Thank you very much :)

annatisch

Just a couple of tiny things then it's good to go :)

annatisch · 2018-10-15T14:58:59Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-10-01/consumption.json

+{
+  "swagger": "2.0",
+  "info": {
+    "version": "2018-08-31",


Please update the version tag to "2018-10-01"

annatisch · 2018-10-15T14:59:57Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-10-01/consumption.json

+          }
+        },
+        "x-ms-pageable": {
+          "nextLinkNa


Please make "subscriptionGuids" two words: "subscription GUIDs"

annatisch · 2018-10-15T15:00:13Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2018-10-01/consumption.json

+          }
+        },
+        "x-ms-pageable": {
+          "nextLinkNa


Please make "subscriptionGuids" two words: "subscription GUIDs"

… in Consumption.json Per comment

parisa-naeimi · 2018-10-15T17:50:13Z

@annatisch Hello, thank you for the feedback, I applied all of them. Please let me know if I need to update it again.

annatisch · 2018-10-15T17:55:55Z

Thanks @parisa-naeimi -
Just one last comment - I see on line 4302 that the API version parameter description includes the version - I would remove the 2nd sentence here, so we don't forget to update it for future API verisons.

azure-rest-api-specs/specification/consumption/resource-manager/Microsoft.Consumption/stable/2018-10-01/consumption.json

Line 4302 in 63c2d0f

    
           "description": "Version of the API to be used with the client request. The current version is 2018-08-31."

parisa-naeimi · 2018-10-15T18:02:05Z

@annatisch I kept it as it is just updated the version. Thanks for catching it.

parisa-naeimi · 2018-10-19T18:39:26Z

@annatisch Hello Again, you merged these changes 4 days ago but I do not know I cannot see the new version of consumption and also my recent changes. Any suggestion here?

annatisch · 2018-10-19T20:19:44Z

@parisa-naeimi - I'm not sure I understand - your changes have been merged here:
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2018-10-01

Or did you mean your changes in each specific language SDK?

parisa-naeimi · 2018-10-19T20:23:59Z

When I go to this link for consumption rp https://docs.microsoft.com/en-us/rest/api/consumption/ I supposed to see the latest version which is 2018-10-01 but I still see the previous version which is 2018-08-31. It does not seem right?

annatisch · 2018-10-19T20:41:57Z

I don't think the updated API docs are automatic.
Please reach out to the docs team for further info:
https://github.com/Azure/adx-documentation-pr

parisa-naeimi · 2018-10-19T22:01:51Z

@annatisch I have done this before and always after merge I used to see update automatically.

annatisch · 2018-10-19T22:03:37Z

I do not know how API docs are generated from swagger specs - please reach out to the docs team.

parisa-naeimi · 2018-10-19T22:10:36Z

@annatisch looks like I need to reach out to them since it is a version change. Thank you for the help

parisa-naeimi added 2 commits October 2, 2018 15:00

Introducing new version 2018-10-01 for Consumption API

4915da8

Added IncludedSubscriptions and ExcludedSubscriptions properties to A…

3624226

…ggregatedCost

azuresdkci assigned annatisch Oct 3, 2018

azuresdkci requested a review from annatisch October 3, 2018 19:04

AutorestCI mentioned this pull request Oct 3, 2018

[AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API Azure/azure-sdk-for-ruby#1721

Closed

AutorestCI mentioned this pull request Oct 3, 2018

[AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API Azure/azure-sdk-for-node#3757

Merged

annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 3, 2018

Updated api-version to 2018-10-01 in all examples

eceb8b7

ravbhatnagar approved these changes Oct 10, 2018

View reviewed changes

Updated readme tags

81df0a1

Updated readme.md per review comment

eff7dad

AutorestCI mentioned this pull request Oct 12, 2018

[AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API Azure/azure-sdk-for-js#178

Merged

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

c2821ab

# Conflicts: # specification/consumption/resource-manager/readme.md

This was referenced Oct 13, 2018

[AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API Azure/azure-sdk-for-python#3610

Merged

[AutoPR consumption/resource-manager] Introducing New Version 2018-10-01 for Consumption API Azure/azure-sdk-for-go#3004

Merged

annatisch requested changes Oct 15, 2018

View reviewed changes

parisa-naeimi added 2 commits October 15, 2018 10:19

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

8c82c7e

Updated version and replace subscriptionGuids with subscription Guids…

63c2d0f

… in Consumption.json Per comment

Updated version in Parameter

5fb4306

annatisch approved these changes Oct 15, 2018

View reviewed changes

annatisch merged commit 8f39551 into Azure:master Oct 15, 2018

Introducing New Version 2018-10-01 for Consumption API #4069

Introducing New Version 2018-10-01 for Consumption API #4069

Uh oh!

Conversation

parisa-naeimi commented Oct 3, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Oct 3, 2018

Uh oh!

AutorestCI commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Oct 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

annatisch commented Oct 3, 2018

Uh oh!

annatisch commented Oct 10, 2018

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Oct 10, 2018

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar Oct 10, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch commented Oct 11, 2018

Uh oh!

parisa-naeimi commented Oct 11, 2018

Uh oh!

annatisch commented Oct 11, 2018

Uh oh!

parisa-naeimi commented Oct 11, 2018

Uh oh!

annatisch commented Oct 12, 2018

Uh oh!

parisa-naeimi commented Oct 12, 2018

Uh oh!

annatisch commented Oct 12, 2018

Uh oh!

parisa-naeimi commented Oct 12, 2018

Uh oh!

annatisch commented Oct 12, 2018

Uh oh!

parisa-naeimi commented Oct 13, 2018

Uh oh!

annatisch left a comment

Choose a reason for hiding this comment

Uh oh!

annatisch Oct 15, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Oct 15, 2018

Choose a reason for hiding this comment

Uh oh!

annatisch Oct 15, 2018

Choose a reason for hiding this comment

Uh oh!

parisa-naeimi commented Oct 15, 2018

AutorestCI commented Oct 3, 2018 •

edited

Loading

AutorestCI commented Oct 3, 2018 •

edited

Loading

AutorestCI commented Oct 3, 2018 •

edited

Loading

AutorestCI commented Oct 3, 2018 •

edited

Loading

AutorestCI commented Oct 3, 2018 •

edited

Loading

AutorestCI commented Oct 3, 2018 •

edited

Loading