Skip to content

Conversation

@zjpjack
Copy link
Contributor

@zjpjack zjpjack commented Nov 19, 2018

Correct the suppress rule type, so it can suppress the correct one.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@jhendrixMSFT
Copy link
Member

@zjpjack in the previous PR it appears to have worked, am I missing something?

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 20, 2018
@zjpjack
Copy link
Contributor Author

zjpjack commented Nov 20, 2018

@jhendrixMSFT sorry for misleading.

ERROR (RequiredPropertiesMissingInResourceModel/R2020/ARMViolation): Model definition 'TagValue' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.

We have this error, and previous PR I made it "BodyTopLevelProperties", this is not correct. And I missed the error information. That is why I change the suppress type here.

@jhendrixMSFT jhendrixMSFT merged commit 7019b70 into Azure:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants