modeling assignmentOperations with api-version 2018-11-01 #4590

haitch · 2018-11-27T19:25:33Z

Changes

Modeling assignmentOperations, so SDK client can retrieve details about any assignment and history as well.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

openapi-portal-comment · 2018-11-27T19:25:34Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-11-27T19:25:55Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-11-27T19:26:00Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4158

AutorestCI · 2018-11-27T19:26:06Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-11-27T19:26:14Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-11-27T19:27:32Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3857

azuresdkci · 2018-11-27T19:37:40Z

Can one of the admins verify this patch?

ravbhatnagar · 2018-12-12T21:14:05Z

As per discussion with Marcin over email, here is what will happen. tracking it here- #4903
/assignmentOperations
In a resource ID, it will look like this /subscriptions/{id}/providers/Microsoft.Blueprint/blueprintAssignments/{name}/assignmentOperations, which is redundant. On the upside the generated SDK already calls this object AssignmentOperations, so it will match the API now. The downside is that we will continue supporting /operations on API version 2017-11-11-. API versions 2018-11-01- and later would use /assignmentOperations. This will remain in our RP manifest and service code until 2017-11-11-preview is fully deprecated and removed. This seems like a good compromise to get this PR unblocked.

ravbhatnagar · 2018-12-12T21:14:29Z

Signing off from ARM side.

…mentOperations

haitch · 2018-12-12T23:57:03Z

#4903 is addressed in latest commit

haitch · 2018-12-12T23:58:06Z

@annatisch can you take a look again and merge?

annatisch · 2018-12-13T17:37:22Z

Thanks @haitch - model validation pass is still failing:

 error :
operationId: AssignmentOperations_List
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  message: >-
    In operation "AssignmentOperations_List", example for parameter "scope":
    "/subscriptions/f8df94f2-2f5a-4f4a-bcaf-1bb992fb564b" starts with a forward
    slash and the path template:
"/{scope}/providers/Microsoft.Blueprint/blueprintAssignments/{assignmentName}/assignmentOperations"    contains a forward slash before the parameter starts. This will cause double
    forward slashes  in the request url. Thus making it incorrect. Please
    rectify the example.

 error : 
operationId: AssignmentOperations_Get
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  message: >-
    In operation "AssignmentOperations_Get", example for parameter "scope":
    "/subscriptions/f8df94f2-2f5a-4f4a-bcaf-1bb992fb564b" starts with a forward
    slash and the path template:
"/{scope}/providers/Microsoft.Blueprint/blueprintAssignments/{assignmentName}/assignmentOperations/{assignmentOperationName}"
    contains a forward slash before the parameter starts. This will cause double
    forward slashes  in the request url. Thus making it incorrect. Please
    rectify the example.

haitch · 2018-12-13T17:46:41Z

fixed, @annatisch can you approve?

annatisch · 2018-12-13T17:51:50Z

Thanks @haitch - I will try to review this afternoon

annatisch · 2018-12-13T18:00:46Z

@haitch - is this API already deployed/available?

haitch · 2018-12-13T18:03:56Z

it was deployed with /operations last week.

I've also updated our RP with the rename, the rename deploy soon.

annatisch · 2018-12-13T18:05:54Z

Thanks - please update this thread when the rename has been deployed (or when deployment has started).

annatisch

Thanks @haitch - the PR looks good! :)
My only comments are minor regarding the consistent capitalization of the descriptions.

...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/assignmentOperation.json

annatisch

LGTM.
Waiting on service deployment to merge :)

annatisch · 2019-01-08T19:16:43Z

@haitch - Is this API now public?

haitch · 2019-01-08T19:18:16Z

@annatisch it is public, you can safely merge this PR.

annatisch · 2019-01-08T21:01:29Z

@RyanBensonMSFT - could you please sign off your review if your requested changes have been addressed?

Adding @lmazuel to merge PR once that sign off happens.

filizt · 2019-01-10T05:03:56Z

@RyanBensonMSFT please let us know if anything is blocking the sign off.

filizt · 2019-01-10T18:44:09Z

@lmazuel could you merge the PR please?

* move blueprint from private repo to public * address comment * fat finger * add description in ResourceProviderOperation * camelCase for resourceType * strongType ParameterValueCollection * remove the hacky workaround for extension resource path * init apiVersion=Nov2018 * api definition * progress * split assignment and blueprint definition * assignmentOperation api * split swagger to multiple area for easy upgrade * update suppression due to file split * modeling assignmentOperations * suppress warnings on new file * fix assignmentOperation list * typo * add python repo * add title and description, fix old apiversion in examples * update assignmentOperation use scope for more flexbility * rename blueprintAssignments/operations to blueprintAssignments/assignmentOperations * fix double forward slashes * description update * more capital letters * werid casing error

Haitao Chen added 20 commits September 10, 2018 11:57

move blueprint from private repo to public

130a232

address comment

be1f530

fat finger

0c6f5de

add description in ResourceProviderOperation

1b4768e

camelCase for resourceType

f4e3619

strongType ParameterValueCollection

f533119

remove the hacky workaround for extension resource path

700aad8

init apiVersion=Nov2018

3aeb98f

api definition

4a22467

progress

09b7920

merge from latest

4b7152e

split assignment and blueprint definition

59f4dfb

assignmentOperation api

7dba31f

split swagger to multiple area for easy upgrade

6dfd0ad

Merge branch 'master' into haitch/assignmentOperation

53e50eb

update suppression due to file split

949a139

Merge branch 'master' into haitch/assignmentOperation

fb0effc

Merge branch 'master' of github.com:Azure/azure-rest-api-specs

b7134a7

Merge branch 'master' into haitch/assignmentOperation

4235f4e

modeling assignmentOperations

5065fec

AutorestCI mentioned this pull request Nov 27, 2018

[AutoPR blueprint/resource-manager] modeling assignmentOperations with api-version 2018-11-01 Azure/azure-sdk-for-go#3420

Closed

suppress warnings on new file

565047c

azuresdkci assigned annatisch Nov 27, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 12, 2018

rename blueprintAssignments/operations to blueprintAssignments/assign…

1208b90

…mentOperations

amarzavery mentioned this pull request Dec 13, 2018

[BluePrint] [APIissue] resource type name blueprintAssignment/{name}/operations should be chnaged to /assignmentOperations #4903

Closed

fix double forward slashes

9611a31

annatisch reviewed Dec 13, 2018

View reviewed changes

Haitao Chen added 3 commits December 13, 2018 10:57

description update

aeef56b

more capital letters

cd4252d

werid casing error

f109377

annatisch approved these changes Dec 13, 2018

View reviewed changes

ryansbenson approved these changes Jan 10, 2019

View reviewed changes

lmazuel merged commit 1b8809e into Azure:master Jan 11, 2019

filizt mentioned this pull request Jan 17, 2019

Generate SDK for new API version Azure/azure-sdk-for-net#5151

Merged

9 tasks

modeling assignmentOperations with api-version 2018-11-01 #4590

modeling assignmentOperations with api-version 2018-11-01 #4590

Uh oh!

Conversation

haitch commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Contribution checklist:

Uh oh!

openapi-portal-comment bot commented Nov 27, 2018

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Nov 27, 2018

Uh oh!

ravbhatnagar commented Dec 12, 2018

Uh oh!

ravbhatnagar commented Dec 12, 2018

Uh oh!

haitch commented Dec 12, 2018

Uh oh!

haitch commented Dec 12, 2018

Uh oh!

annatisch commented Dec 13, 2018

Uh oh!

haitch commented Dec 13, 2018

Uh oh!

annatisch commented Dec 13, 2018

Uh oh!

annatisch commented Dec 13, 2018

Uh oh!

haitch commented Dec 13, 2018

Uh oh!

annatisch commented Dec 13, 2018

Uh oh!

annatisch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

annatisch left a comment

Choose a reason for hiding this comment

Uh oh!

annatisch commented Jan 8, 2019

Uh oh!

haitch commented Jan 8, 2019

Uh oh!

annatisch commented Jan 8, 2019

Uh oh!

filizt commented Jan 10, 2019

Uh oh!

filizt commented Jan 10, 2019

Uh oh!

Reviewers

haitch commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading

AutorestCI commented Nov 27, 2018 •

edited

Loading