Skip to content

[Portal Generated] Review request for Microsoft.SqlVirtualMachine to add version 2017-03-01-preview #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergey-shandar merged 5 commits into from
Dec 6, 2018
Merged

[Portal Generated] Review request for Microsoft.SqlVirtualMachine to add version 2017-03-01-preview #4740

sergey-shandar merged 5 commits into from
Dec 6, 2018

Conversation

@yareyes
Copy link
Member

@yareyes yareyes commented Dec 3, 2018 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Dec 3, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4020

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@nschonni
Copy link
Contributor

nschonni commented Dec 3, 2018

Is the typo in "Occurred" in "UnExpectedErrorOccured" fixable or generated of a server side type?

@yareyes
Copy link
Member Author

yareyes commented Dec 3, 2018

@nschonni Thanks for noticing, will change.

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3641

@azuresdkci
Copy link
Contributor

azuresdkci commented Dec 3, 2018

Can one of the admins verify this patch?

@nschonni
Copy link
Contributor

nschonni commented Dec 3, 2018

@yareyes there is also these if they're fixable in the exception types
Atleast -> At least
SqlExtnNotInstalled -> SqlExtensionNotInstalled
OSversion -> OSVersion
KeyvaultCredentialsNotSpecified -> KeyVaultCredentialsNotSpecified

@yareyes
Copy link
Member Author

yareyes commented Dec 4, 2018

@nschonni done. :)

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 4, 2018
@yareyes
Copy link
Member Author

yareyes commented Dec 5, 2018

@sergey-shandar could we get this approved and checked in?

@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2018
@sergey-shandar sergey-shandar merged commit 33c292c into Azure:master Dec 6, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@yareyes @AnuTalluri
[Portal Generated] Review request for Microsoft.SqlVirtualMachine to …
57557a0 
…add version 2017-03-01-preview (Azure#4740)

* Updating the swagger

* Updating error message

* Updating error messages

* Adding the example that was missing

* Moving property to the end of the object
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@Shwas
Updates to parameters (#4740)
83164b4 
* Updates to parameters

These APIs are currently only being used in dogfood environment by the developers. And haven't been used in production by anyone.

* Update parameter casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yareyes @AutorestCI @nschonni @azuresdkci @sergey-shandar