Resource and property changes #4766

leonardbf · 2018-12-04T17:37:21Z

Incorrect pool resource reference
Name elements of property not required
Correction to return status code
Add put (and patch) for snapshots.
Service level definition changes.
(NetApp internal ticket NFSAAS-1505)

Note : breaking changes are acceptable as this is for the initial RP version (previously only preview).

NFSAAS-1505 minor update and validation fixes

Put (and patch) for snapshots. Service level definition changes.

NFSAAS-1505 bring in line with RP

NFSAAS-1505 correct resource reference and limits

Incorrect pool resource reference Name elements of property not required Correction to return status code

NFSAAS-1505 resource and property changes

openapi-portal-comment · 2018-12-04T17:37:22Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-04T17:37:23Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-12-04T17:37:46Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-12-04T17:37:50Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-12-04T17:38:09Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-12-04T17:38:10Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3203

azuresdkci · 2018-12-04T17:39:12Z

Can one of the admins verify this patch?

NFSAAS-1505 status codes

AutorestCI · 2018-12-04T21:53:54Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

amarzavery · 2018-12-05T01:15:29Z

@leonardbf
There are errors in the model validator, please fix them. Either the example is correct or the schema definition.

Validating "examples" and "x-ms-examples" in  specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json:
 error : 
operationId: Accounts_List
scenario: Accounts_List
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - accountId
  message: 'Additional properties not allowed: accountId'
  path: value/0/properties
  title: /definitions/accountProperties
  description: NetApp account properties
  position:
    line: 1164
    column: 26
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 13
    column: 27
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Accounts_List.json
 error : 
operationId: Accounts_Get
scenario: Accounts_Get
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - accountId
  message: 'Additional properties not allowed: accountId'
  path: properties
  title: /definitions/accountProperties
  description: NetApp account properties
  position:
    line: 1164
    column: 26
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 12
    column: 25
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Accounts_Get.json
 error : 
operationId: Accounts_CreateOrUpdate
scenario: Accounts_CreateOrUpdate
source: response
responseCode: '200'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_SPEC
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_SPEC
  id: OAV112
  message: >-
    Response statusCode "200" for operation "Accounts_CreateOrUpdate" is
    provided in exampleResponseValue, however it is not present in the swagger
    spec.
  level: error
 error : 
operationId: Accounts_CreateOrUpdate
scenario: Accounts_CreateOrUpdate
source: response
responseCode: '201'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
  id: OAV111
  message: >-
    Following response status codes "201" for operation
    "Accounts_CreateOrUpdate" were present in the swagger spec, however they
    were not present in x-ms-examples. Please provide them.
  level: error
 error : 
operationId: Accounts_Update
scenario: Accounts_Update
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - accountId
  message: 'Additional properties not allowed: accountId'
  path: properties
  title: /definitions/accountProperties
  description: NetApp account properties
  position:
    line: 1164
    column: 26
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 13
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Accounts_Update.json
 error : 
operationId: Pools_List
scenario: Pools_List
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - accountId
  message: 'Additional properties not allowed: accountId'
  path: value/0/properties
  title: /definitions/poolProperties
  description: Pool properties
  position:
    line: 1242
    column: 23
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 14
    column: 27
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Pools_List.json
 error : 
operationId: Pools_Get
scenario: Pools_Get
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - accountId
  message: 'Additional properties not allowed: accountId'
  path: properties
  title: /definitions/poolProperties
  description: Pool properties
  position:
    line: 1242
    column: 23
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 13
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Pools_Get.json
 error : 
operationId: Pools_CreateOrUpdate
scenario: Pools_CreateOrUpdate
source: response
responseCode: '200'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_SPEC
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_SPEC
  id: OAV112
  message: >-
    Response statusCode "200" for operation "Pools_CreateOrUpdate" is provided
    in exampleResponseValue, however it is not present in the swagger spec.
  level: error
 error : 
operationId: Pools_CreateOrUpdate
scenario: Pools_CreateOrUpdate
source: response
responseCode: '201'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
  id: OAV111
  message: >-
    Following response status codes "201" for operation "Pools_CreateOrUpdate"
    were present in the swagger spec, however they were not present in
    x-ms-examples. Please provide them.
  level: error
 error : 
operationId: Pools_Update
scenario: Pools_Update
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - accountId
  message: 'Additional properties not allowed: accountId'
  path: properties
  title: /definitions/poolProperties
  description: Pool properties
  position:
    line: 1242
    column: 23
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 14
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Pools_Update.json
 error : 
operationId: Volumes_List
scenario: Volumes_List
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: value/0/properties
  title: /definitions/volumeProperties
  description: Volume properties
  position:
    line: 1362
    column: 25
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 15
    column: 27
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Volumes_List.json
 error : 
operationId: Volumes_Get
scenario: Volumes_Get
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: properties
  title: /definitions/volumeProperties
  description: Volume properties
  position:
    line: 1362
    column: 25
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 14
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Volumes_Get.json
 error : 
operationId: Volumes_CreateOrUpdate
scenario: Volumes_CreateOrUpdate
source: response
responseCode: '200'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_SPEC
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_SPEC
  id: OAV112
  message: >-
    Response statusCode "200" for operation "Volumes_CreateOrUpdate" is provided
    in exampleResponseValue, however it is not present in the swagger spec.
  level: error
 error : 
operationId: Volumes_CreateOrUpdate
scenario: Volumes_CreateOrUpdate
source: response
responseCode: '201'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
  id: OAV111
  message: >-
    Following response status codes "201" for operation "Volumes_CreateOrUpdate"
    were present in the swagger spec, however they were not present in
    x-ms-examples. Please provide them.
  level: error
 error : 
operationId: Volumes_Update
scenario: Volumes_Update
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: properties
  title: /definitions/volumeProperties
  description: Volume properties
  position:
    line: 1362
    column: 25
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 15
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Volumes_Update.json
 error : 
operationId: MountTargets_List
scenario: MountTargets_List
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: value/0/properties
  title: /definitions/mountTargetProperties
  description: Mount target properties
  position:
    line: 1567
    column: 30
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 16
    column: 27
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/MountTargets_List.json
 error : 
operationId: MountTargets_Get
scenario: MountTargets_Get
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: properties
  title: /definitions/mountTargetProperties
  description: Mount target properties
  position:
    line: 1567
    column: 30
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 15
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/MountTargets_Get.json
 error : 
operationId: Snapshots_List
scenario: Snapshots_List
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: value/0/properties
  title: /definitions/snapshotProperties
  description: Snapshot properties
  position:
    line: 1706
    column: 27
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 16
    column: 27
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Snapshots_List.json
 error : 
operationId: Snapshots_Get
scenario: Snapshots_Get
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: properties
  title: /definitions/snapshotProperties
  description: Snapshot properties
  position:
    line: 1706
    column: 27
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 15
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Snapshots_Get.json
 error : 
operationId: Snapshots_Create
scenario: Snapshots_Create
source: response
responseCode: '200'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_SPEC
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_SPEC
  id: OAV112
  message: >-
    Response statusCode "200" for operation "Snapshots_Create" is provided in
    exampleResponseValue, however it is not present in the swagger spec.
  level: error
 error : 
operationId: Snapshots_Create
scenario: Snapshots_Create
source: response
responseCode: '201'
severity: 0
errorCode: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
errorDetails:
  code: RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE
  id: OAV111
  message: >-
    Following response status codes "201" for operation "Snapshots_Create" were
    present in the swagger spec, however they were not present in x-ms-examples.
    Please provide them.
  level: error
 error : 
operationId: Snapshots_Update
scenario: Snapshots_Update
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - name
  message: 'Additional properties not allowed: name'
  path: properties
  title: /definitions/snapshotProperties
  description: Snapshot properties
  position:
    line: 1706
    column: 27
  url: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/netapp.json
  directives: {}
  jsonPosition:
    line: 16
    column: 23
  jsonUrl: >-
    specification/netapp/resource-manager/Microsoft.NetApp/preview/2017-08-15/examples/Snapshots_Update.json

NFSAAS-1505 tidy up examples

leonardbf · 2018-12-05T08:14:36Z

Examples updated, @amarzavery .

* NFSAAS-1505 minor update and validation fixes * NFSAAS-1505 bring in line with RP Put (and patch) for snapshots. Service level definition changes. * NFSAAS-1505 correct resource reference and limits * NFSAAS-1505 resource and property changes Incorrect pool resource reference Name elements of property not required Correction to return status code * NFSAAS-1505 status codes * NFSAAS-1505 tidy up examples * NFSAAS-1505 tidy up examples

leonardbf and others added 8 commits November 20, 2018 08:04

NFSAAS-1505 minor update and validation fixes

27c0982

Merge pull request #1 from leonardbf/netapp-api-update-public

4535ffb

NFSAAS-1505 minor update and validation fixes

NFSAAS-1505 bring in line with RP

d23b068

Put (and patch) for snapshots. Service level definition changes.

Merge pull request #2 from leonardbf/netapp-api-update-public

d6ce7d9

NFSAAS-1505 bring in line with RP

NFSAAS-1505 correct resource reference and limits

2e3393a

Merge pull request #3 from leonardbf/netapp-api-update-public

d64fced

NFSAAS-1505 correct resource reference and limits

NFSAAS-1505 resource and property changes

f81874b

Incorrect pool resource reference Name elements of property not required Correction to return status code

Merge pull request #4 from leonardbf/netapp-api-update-public

164da1f

NFSAAS-1505 resource and property changes

AutorestCI mentioned this pull request Dec 4, 2018

[AutoPR netapp/resource-manager] Resource and property changes Azure/azure-sdk-for-python#3992

Merged

azuresdkci assigned amarzavery Dec 4, 2018

azuresdkci requested a review from amarzavery December 4, 2018 17:38

leonardbf and others added 2 commits December 4, 2018 21:48

NFSAAS-1505 status codes

7ec6b9e

Merge pull request #5 from leonardbf/netapp-api-update-public

5892e13

NFSAAS-1505 status codes

leonardbf and others added 4 commits December 5, 2018 07:38

NFSAAS-1505 tidy up examples

79df024

Merge pull request #6 from leonardbf/netapp-api-update-public

d8c27fb

NFSAAS-1505 tidy up examples

NFSAAS-1505 tidy up examples

728ffb4

Merge pull request #7 from leonardbf/netapp-api-update-public

e64f32f

NFSAAS-1505 tidy up examples

amarzavery approved these changes Dec 5, 2018

View reviewed changes

amarzavery merged commit 1b63166 into Azure:master Dec 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resource and property changes #4766

Resource and property changes #4766

Uh oh!

leonardbf commented Dec 4, 2018 •

edited by amarzavery

Loading

Uh oh!

openapi-portal-comment bot commented Dec 4, 2018

Uh oh!

AutorestCI commented Dec 4, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Dec 4, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Dec 4, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Dec 4, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Dec 4, 2018 •

edited

Loading

Uh oh!

azuresdkci commented Dec 4, 2018

Uh oh!

AutorestCI commented Dec 4, 2018 •

edited

Loading

Uh oh!

amarzavery commented Dec 5, 2018

Uh oh!

leonardbf commented Dec 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Resource and property changes #4766

Resource and property changes #4766

Uh oh!

Conversation

leonardbf commented Dec 4, 2018 • edited by amarzavery Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-portal-comment bot commented Dec 4, 2018

Uh oh!

AutorestCI commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Dec 4, 2018

Uh oh!

AutorestCI commented Dec 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

amarzavery commented Dec 5, 2018

Uh oh!

leonardbf commented Dec 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leonardbf commented Dec 4, 2018 •

edited by amarzavery

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading

AutorestCI commented Dec 4, 2018 •

edited

Loading