cost-management - API changes #4818

yaborens · 2018-12-06T09:11:15Z

…anagement/preview/2018-08-01-preview/costmanagement.json

Add more Scopes to Alerts.
Also, add /updateStatus to Alerts

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…anagement/preview/2018-08-01-preview/costmanagement.json Add more Scopes to Alerts. Also add /updateStatus to Alerts

openapi-portal-comment · 2018-12-06T09:11:16Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-06T09:11:43Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2018-12-06T09:11:52Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-12-06T09:12:13Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1970

AutorestCI · 2018-12-06T09:12:13Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-12-06T09:12:36Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-12-06T09:13:52Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3749

azuresdkci · 2018-12-06T09:30:26Z

Can one of the admins verify this patch?

...ent/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json

KrisBash

Changes seem fine. one question in comments

yaborens · 2018-12-09T10:07:33Z

@KrisBash , @praries880 Who can merge the code? as I'm not authorized to merge this pull request

praries880 · 2018-12-11T01:00:46Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json

+          },
+          {
+            "name": "$filter",
+            "description": "May be used to filter alerts by properties/definition/type, properties/definition/category, properties/definition/criteria, properties/costEntityId, properties/creationTime, properties/closeTime, properties/status, properties/source. Supported operators are 'eq','lt', 'gt', 'le', 'ge'.",


@yaborens
Examples corresponding to this change?

Also, is the list of filters a closed list? If so... why not use an enum?

Examples corresponding to this change? sorry but I don't understand the question

is the list of filters a closed list? If so... why not use an enum? this is how all other groups implemented a filter.

@yaborens
Here are the changes to the example linked here : https://github.com/Azure/azure-rest-api-specs/pull/4818/files/1d5c0565121e5fef4897b32e78318df919406717#diff-cd2cdd86afbc1836331eaef83f213b9cR30

Is that all that changes there for the new API added here?

As for the supported values for the "filter" parameter from the description above : "properties/definition/type, properties/definition/category, properties/definition/criteria, properties/costEntityId, properties/creationTime, properties/closeTime, properties/status, properties/source", is this a list that changes dynamically? If not, then why not model it as an enum?

Hi,
Is that all that changes there for the new API added here? yes

Filter is not a close group, thus it cannot be enum.

properties/definition/type - not a close group, thus it cannot be enum.

properties/definition/category - Already an Enum

properties/definition/criteria - Already an Enum

properties/costEntityId - not a close group, thus it cannot be enum.

properties/creationTime- Not an Enum field

properties/closeTime - Not an Enum field

properties/status - Already an Enum

properties/source - Already an Enum

praries880

@yaborensth Some comments

praries880 · 2018-12-11T01:03:15Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json

+          },
+          {
+            "name": "$filter",
+            "description": "May be used to filter alerts by properties/definition/type, properties/definition/category, properties/definition/criteria, properties/costEntityId, properties/creationTime, properties/closeTime, properties/status, properties/source. Supported operators are 'eq','lt', 'gt', 'le', 'ge'.",


@yaborens
Examples corresponding to this change?

Also, is the list of filters a closed list? If so... why not use an enum?

same comments as above

I see only this change in the example linked here : https://github.com/Azure/azure-rest-api-specs/pull/4818/files/1d5c0565121e5fef4897b32e78318df919406717#diff-cd2cdd86afbc1836331eaef83f213b9cR30

Is that all changes in the example for this new API?

praries880 · 2018-12-11T01:03:27Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json

+          },
+          {
+            "name": "$filter",
+            "description": "May be used to filter alerts by properties/definition/type, properties/definition/category, properties/definition/criteria, properties/costEntityId, properties/creationTime, properties/closeTime, properties/status, properties/source. Supported operators are 'eq','lt', 'gt', 'le', 'ge'.",


@yaborens
Examples corresponding to this change?

Also, is the list of filters a closed list? If so... why not use an enum?

same comments as above

praries880 · 2018-12-11T01:03:37Z

...ent/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json

+          },
+          {
+            "name": "$filter",
+            "description": "May be used to filter alerts by properties/definition/type, properties/definition/category, properties/definition/criteria, properties/costEntityId, properties/creationTime, properties/closeTime, properties/status, properties/source. Supported operators are 'eq','lt', 'gt', 'le', 'ge'.",


@yaborens
Examples corresponding to this change?

Also, is the list of filters a closed list? If so... why not use an enum?

same comments as above

* Update specification/cost-management/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json Add more Scopes to Alerts. Also add /updateStatus to Alerts * Add billing parameter to departments * Add alert parameters

Update specification/cost-management/resource-manager/Microsoft.CostM…

2ba3d2f

…anagement/preview/2018-08-01-preview/costmanagement.json Add more Scopes to Alerts. Also add /updateStatus to Alerts

AutorestCI mentioned this pull request Dec 6, 2018

[AutoPR cost-management/resource-manager] cost-management - API changes Azure/azure-sdk-for-go#3639

Merged

Add billing parameter to departments

4bda188

azuresdkci assigned praries880 Dec 6, 2018

azuresdkci requested a review from praries880 December 6, 2018 09:33

Add alert parameters

1d5c056

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2018

KrisBash reviewed Dec 7, 2018

View reviewed changes

...ent/resource-manager/Microsoft.CostManagement/preview/2018-08-01-preview/costmanagement.json Show resolved Hide resolved

KrisBash approved these changes Dec 7, 2018

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 7, 2018

praries880 reviewed Dec 11, 2018

View reviewed changes

praries880 suggested changes Dec 11, 2018

View reviewed changes

praries880 approved these changes Dec 17, 2018

View reviewed changes

praries880 merged commit e74dde5 into Azure:master Dec 17, 2018

AutorestCI mentioned this pull request Dec 17, 2018

[AutoPR cost-management/resource-manager] cost-management - API changes Azure/azure-sdk-for-ruby#2094

Merged

mayankagg9722 mentioned this pull request Sep 8, 2022

Adding new preview API version 2022-10-preview #20617

Closed

11 tasks

cost-management - API changes #4818

cost-management - API changes #4818

Uh oh!

Conversation

yaborens commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-portal-comment bot commented Dec 6, 2018

Uh oh!

AutorestCI commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Dec 6, 2018

Uh oh!

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

yaborens commented Dec 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praries880 Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yaborens Dec 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

praries880 Dec 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

praries880 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

yaborens commented Dec 6, 2018 •

edited

Loading

AutorestCI commented Dec 6, 2018 •

edited

Loading

AutorestCI commented Dec 6, 2018 •

edited

Loading

AutorestCI commented Dec 6, 2018 •

edited

Loading

AutorestCI commented Dec 6, 2018 •

edited

Loading

AutorestCI commented Dec 6, 2018 •

edited

Loading

AutorestCI commented Dec 6, 2018 •

edited

Loading

yaborens commented Dec 9, 2018 •

edited

Loading

praries880 Dec 11, 2018 •

edited

Loading

yaborens Dec 12, 2018 •

edited

Loading

praries880 Dec 14, 2018 •

edited

Loading

praries880 left a comment •

edited

Loading