Skip to content

Conversation

@jureid
Copy link
Contributor

@jureid jureid commented Dec 7, 2018

$filter may be used to filter invoices by invoicePeriodEndDate, not invoicePeriodStartDate. This doc (https://docs.microsoft.com/en-us/rest/api/billing/invoices/list) is for API Version 2017-04-24-preview, so this change should fix the sample request in the doc

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

$filter may be used to filter invoices by invoicePeriodEndDate, not invoicePeriodStartDate. This doc (https://docs.microsoft.com/en-us/rest/api/billing/invoices/list) is for API Version 2017-04-24-preview, so this change should fix the sample request in the doc
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Dec 7, 2018

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had offline chat with Julia and her team works on billing experience. Merging this PR.

@anuchandy anuchandy merged commit a09c315 into Azure:master Dec 10, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
…ate (Azure#4824)

$filter may be used to filter invoices by invoicePeriodEndDate, not invoicePeriodStartDate. This doc (https://docs.microsoft.com/en-us/rest/api/billing/invoices/list) is for API Version 2017-04-24-preview, so this change should fix the sample request in the doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants