Skip to content

[Ready to MERGE] Swagger for Tenant Properties API #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praries880 merged 13 commits into from
Feb 22, 2019
Merged

[Ready to MERGE] Swagger for Tenant Properties API #5038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5d3784a
added swagger for Tenant Properties
Jan 15, 2019
38018ad
Fixed camel casing in billing.json file
Jan 15, 2019
c81e213
Update billing.json
Jan 15, 2019
33d848a
changes in DiscoverTenants contracts
Jan 15, 2019
5c877c2
billing.Json trim blank space
Jan 15, 2019
c736ede
Update billing.json
Jan 15, 2019
7a96d09
removal of plural name
Jan 15, 2019
eab3b0f
Updating the route
Jan 17, 2019
b6137f4
Moved Swagger for Discover Tenants from billing to consumption
Jan 18, 2019
53fb8f8
Change in Namespace followed by one additional parameter "billingAcco…
Jan 23, 2019
b405815
Change of method name from discoverTenants to tanants.
Jan 24, 2019
42f98d2
changes ion response type
Jan 24, 2019
0d55ad6
added name after Id. Code review implementation
Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changes in DiscoverTenants contracts 
changes in DiscoverTenants contracts
  • Loading branch information
Santosh Sinha committed Jan 15, 2019
commit 33d848a6a3264cac98a5928547541bda1dd69189
8 changes: 4 additions & 4 deletions ...cation/billing/resource-manager/Microsoft.Billing/preview/2018-03-01-preview/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,10 @@
],
"x-ms-examples": {
"TenantPropertiesGet": {
"$ref": "./examples/TenantPropertiesGet.json"
"$ref": "./examples/DiscoverTenantsGet.json"
}
},
"operationId": "TenantProperties_Get",
"operationId": "DiscoverTenants_Get",
"description": "Gets a Tenant Properties.",
"parameters": [
{
Expand All @@ -228,7 +228,7 @@
"200": {
"description": "OK. The request has succeeded.",
"schema": {
"$ref": "#/definitions/TenantProperties"
"$ref": "#/definitions/DiscoverTenants"
}
},
"default": {
Expand Down Expand Up @@ -472,7 +472,7 @@
}
}
},
"TenantProperties": {
"DiscoverTenants": {
Copy link

@praries880 praries880 Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build issue in Java is because this name is a plural.

Also, why if the field names DiscoverTenants? Should it be Tenant or TenantInfo as it is describing a Tenant?

I will leave that call to the ARM team...

In the meanwhile, to fix the build break, can you remove the plural from the name... and just change it to the following :

Suggested change
"DiscoverTenants": {
"DiscoverTenant": {

Copy link
Contributor Author

@santoshsinha100 santoshsinha100 Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build issue is fixed now. Waiting for approval.

Copy link
Contributor Author

@santoshsinha100 santoshsinha100 Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding Name "DiscoverTenants" its actually doing a tenant discovery in Power BI custom connector and this API is designed only for that purpose. I hope this justifies your query.

"description": "A Tenant properties Resource",
"properties": {
"billingProfileName": {
Expand Down
6 changes: 3 additions & 3 deletions ...preview/examples/TenantPropertiesGet.json → ...-preview/examples/DiscoverTenantsGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"responses": {
"200": {
"body": {
"BillingProfileName": "PayByCheck01",
"BillingAccountId": "9984934b-0494-53de-0fcd-83828e47dbc6",
"TenantId": "251d3d06-c6e0-487b-bd5e-5c2e4c23d51a"
"billingProfileName": "PayByCheck01",
"billingAccountId": "9984934b-0494-53de-0fcd-83828e47dbc6",
"tenantId": "251d3d06-c6e0-487b-bd5e-5c2e4c23d51a"
}
}
}
Expand Down