Skip to content

Azure Search: Resource Manager: Support 'None' Identity type #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarangan12 merged 2 commits into from
Mar 7, 2019
Merged

Azure Search: Resource Manager: Support 'None' Identity type #5319

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fe70b
Azure Search: Resource Manager: Support 'None' Identity type
natinimni Mar 4, 2019
f5ba828
Azure Search: Resource Manager: Adding serice identity creation\remov…
natinimni Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Azure Search: Resource Manager: Support 'None' Identity type
  • Loading branch information
@natinimni
natinimni committed Mar 4, 2019
commit f0fe70b51825fdec12d01df500646be7e4dcff54
1 change: 1 addition & 0 deletions specification/search/resource-manager/Microsoft.Search/stable/2015-08-19/search.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,6 +1064,7 @@
"type": "string",
"description": "The identity type.",
"enum": [
"None",
Copy link
Member

@brjohnstmsft brjohnstmsft Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natinimni Adding a new enum value is a client-side breaking change, so make sure to bump the major version of the .NET Management SDK.

Copy link
Member

@brjohnstmsft brjohnstmsft Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also wouldn't hurt to ensure there's an example of using this value.

Copy link
Contributor Author

@natinimni natinimni Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @brjohnstmsft !
The .NET Mgmt SDK was never generated with the identity property, so it should not be a breaking change for it :)
I've added some examples.

Copy link
Member

@brjohnstmsft brjohnstmsft Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks!

"SystemAssigned"
],
"x-ms-enum": {
Expand Down