Skip to content

[ACR] Update Webhook Event Target Schema to Add Name and Version #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anuchandy merged 3 commits into from
Mar 21, 2019
Merged

[ACR] Update Webhook Event Target Schema to Add Name and Version #5390

anuchandy merged 3 commits into from
Mar 21, 2019

Conversation

@jaysterp
Copy link
Member

@jaysterp jaysterp commented Mar 14, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4637

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1687

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2164

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5002

@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 14, 2019

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from anuchandy March 14, 2019 21:25
@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4349

@shahabhijeet
Copy link
Contributor

shahabhijeet commented Mar 14, 2019

startbuild

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3165

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 18, 2019
@adxsdknet
.NET SDK Resource Provider:'ContainerRegistry'
96f900c 
REST Spec PR 'Azure/azure-rest-api-specs#5390'
REST Spec PR Author 'jaysterp'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 18, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5491
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@96f900c

@jaysterp
Copy link
Member Author

jaysterp commented Mar 18, 2019

@anuchandy Please review when you have a chance.

@anuchandy anuchandy merged commit 4475d4e into Azure:master Mar 21, 2019
This was referenced Mar 21, 2019
Merged
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 21, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'ContainerRegistry' (#5491)
c07cdcf 
REST Spec PR 'Azure/azure-rest-api-specs#5390'
REST Spec PR Author 'jaysterp'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'ContainerRegistry' (Azure#5491)
0e88185 
REST Spec PR 'Azure/azure-rest-api-specs#5390'
REST Spec PR Author 'jaysterp'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

+1 more reviewer

@djyou djyou djyou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anuchandy anuchandy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jaysterp @AutorestCI @azuresdkci @shahabhijeet @adxsdknet @anuchandy @djyou