Skip to content

Conversation

@solankisamir
Copy link
Member

@solankisamir solankisamir commented Apr 6, 2019

If you are a MSFT employee you can view your work branch via this link.

fixes issues

Contribution checklist:

@solankisamir solankisamir requested a review from promoisha April 6, 2019 01:00
@AutorestCI
Copy link

AutorestCI commented Apr 6, 2019

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Apr 6, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3106

@solankisamir solankisamir requested a review from KedarJoshi April 6, 2019 01:01
@solankisamir solankisamir added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 6, 2019
@AutorestCI
Copy link

AutorestCI commented Apr 6, 2019

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#2121

@AutorestCI
Copy link

AutorestCI commented Apr 6, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Apr 6, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@solankisamir
Copy link
Member Author

@shahabhijeet do you know why the .NET SDK generation failed? I do have a couple of breaking changes in the OperationId.

@solankisamir
Copy link
Member Author

@KrisBash @sergey-shandar can you review this new apiversion spec?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 9, 2019
@solankisamir
Copy link
Member Author

@sergey-shandar a gentle ping on this!

@shahabhijeet
Copy link
Contributor

@solankisamir .NET SDK is failing to compile due to the following compile error, meaning SDK is not getting generated properly with your new Spec.
I don't think this spec can be merged in it's current form.

Customization\Models\SubscriptionContract.cs(18,48): error CS1061: 'SubscriptionContract' does not contain a definition for 'ProductId' and no accessible extension method 'ProductId' accepting a first argument of type SubscriptionContract' could be found (are you missing a using directive or an assembly reference?) [D:\myFork\sdkForNet\master\src\SDKs\ApiManagement\Management.ApiManagement\Microsoft.Azure.Management.ApiManagement.csproj]
Customization\Models\SubscriptionContract.cs(20,33): error CS1061: 'SubscriptionContract' does not contain a definition for 'ProductId' and no accessible extension method 'ProductId' accepting a first argument of type 'SubscriptionContract' could be found (are you missing a using directive or an assembly reference?) [D:\myFork\sdkForNet\master\src\SDKs\ApiManagement\Management.ApiManagement\Microsoft.Azure.Management.ApiManagement.csproj]
Customization\Models\SubscriptionContract.cs(31,48): error CS1061: 'SubscriptionContract' does not contain a definition for 'UserId' and no accessible extension method 'UserId' accepting a first argument of type 'SubscriptionContract' could be found (are you missing a using directive or an assembly reference?) [D:\myFork\sdkForNet\master\src\SDKs\ApiManagement\Management.ApiManagement\Microsoft.Azure.Management.ApiManagement.csproj]
Customization\Models\SubscriptionContract.cs(33,33): error CS1061: 'SubscriptionContract' does not contain a definition for 'UserId' and no accessible extension method 'UserId' accepting a first argument of type 'SubscriptionContract' could be found (are you missing a using directive or an assembly reference?) [D:\myFork\sdkForNet\master\src\SDKs\ApiManagement\Management.ApiManagement\Microsoft.Azure.Management.ApiManagement.csproj]

@solankisamir
Copy link
Member Author

@shahabhijeet yes, we have made breaking changes in the SubscriptonContract, and the customization would need to be updated.

fearthecowboy pushed a commit that referenced this pull request Apr 24, 2019
* added multiapi readme files

* Added profile files.

* added java readme (#5509)

* Adding Java generation for ResourceGraph (#5504)

* added java generation in separate file

* Update readme.java.md

* [DataFactory] validation activity (#5473)

* validation activity

* adding type descriptions

* [App Insights control plane] fix: validate subId, apiVersion, rgName (#5505)

* fix: validate subId, apiVersion, rgName

* fix: missed a few parameter defs

* fix: typo

* Swagger for Lease Container API in Feb18, March18Preview, Jul18 & Nov18. (#5480)

* Add Lease Container API Swagger & example in Feb18.

* Add Lease Container API Swagger & example in Jul18.

* Add Lease Container API Swagger & example in Nov18.

* Add Lease Container API Swagger & example in March18Preview

* Fix references to paramter AccountName to StorageAccountName

* Fix new API definition section positioning in the json schema

* Fix references paramter StorageAccountName.

* Camel-case property names

* Add another example json for lease container

* wip: latest-profile generation.

* [Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-02-01-preview (#5512)

* Add inline scripts

* Fix bug: "artifactLocation" -> "artifactUri"

* Renaming sensativityLabels in Readme.md (#5517)

* Renaming sensativityLabels in Readme.md

Might cause azure .net sdk generation errors.

* Update sensitivityLabels.json

* Rename sensitivityLabels.json to SensitivityLabels.json

* added missed parameters in Update Server API to stop PG replication (#5511)

* Finished script for generating latest profile.

* Added latest profile as of 04-01-2019

* Added script command to package.json

* results from crawling the specs from the repo.

* doNotRunExtensionsOnOverProvisioned Vms property description update (#5515)

* made version more specific in terms of the date.

* add Premium_ChinaCdn support to cdn specification 2017-10-12 (#5533)

* adding customerAdminGroupId to osa cluster spec (#5491)

* [HDInsight] - Update configuration related APIs (#5477)

* [HDInsight] - Update configurations

* Remove unused examples to avoid Avocado validation error

* Add description for gateway settings and update gateway settings

* Add suppression rule

* Trigger

* #5326 Fix the criteria definition (#5462)

* [Azure Search] Update examples to use EntityRecognitionSkill instead of NamedEntityRecognitionSkill (#5531)

* Find and replace NamedEntityRecognitionSkill -> EntityRecognitionSkill

* Remove the extraneous minimumPrecision field

* updated multiapi.ts script to make enable-multi-api.readme files reference profile definitions.

* updated script and telemetry file to get originalLocation of invalid paths.

* Adding require of latest profile to readme.

* Adding require to profiles readme.md to all enable-multi-api readmes.

* typo clean

* Update managedserviceidentity type enum (#5536)

Enum is currently missing the ua + sa combination + "none" type. We do support those values in our API and as such need the swagger to reflect that.

* Added Swagger details for CheckNameAvailability API (#5496)

* Added swagger for CheckNameAvailability API

* Adding ResourceGroupName to Route for CheckNameAvailability API and renaming ResourceNameAvailabilityInput to ResourceNameAvailabilityParameters

* Changed operationId for checkNameAvailability from CheckResourceNameAvailability_Post to RecoveryServices_CheckNameAvailability

* Renaming ResourceNameAvailabilityResponse to ResourceNameAvailabilityResult

* Renaming ResourceNameAvailabilityResult to CheckNameAvailabilityResult and changing GCed to GC'ed in swagger API summary

* Renaming ResourceNameAvailabilityParameters to CheckNameAvailabilityParameters

* GTM billing api for getting reservation Transactions by invoice section. (#5475)

* swagger for Get{Reservation}TransactionsByInvoiceSection.

* gtm rest apis for Get{Reservation}TransactionsByInvoiceSection.

* updating operationId for tansactions to Noun_verb as per feedback.

* fixing examples

* fix bugs in examples.

* remove more duplicates

* fix example

* Enable MD5 Support for DataLakeStorage 2018-11-09 (#5537)

* Add Managed Identity envelope to SitePatchResource (#5542)

Add Managed Identity envelope to SitePatchResource object to allow PATCH identity operations to a site through Swagger

* Add cases aggregation endpoint to SecurityInsights RP swagger spec (#5519)

* Add cases aggregation endpoint to SecurityInsights RP swagger spec

* Fix pathParam and add Tag

* Fix model type regression (#5535)

* SRP Apr19 API supporting automatic snapshot feature (#5522)

* Add API Version 2019-04-01

* Support automatic snapshot

* Model SkuName & Kind and string

* Update default api version to 2019-04

* Added specs for Agreements API in version 2018-11-01-preview (#5546)

* Added specs for Agreements API in version 2018-11-01-preview

Added specs for Agreements API in version 2018-11-01-preview

* Updated as per naming convension

Updated as per naming convension

* Add Application Insights smart detection config api (#5518)

* add new version for proactive detection config

* fixing api-version

* alligning resource definition

* fix workbook patch operation

* reverting eric changes

* change helpUri description

* add to readme file

* ApiManagement : Moved all definitions to a common file for automation (#5545)

* A common Definitions file

* Fix for x-ms-odata

* Add file to readme.md

* [Hub Generated] Review request for Microsoft.Batch to add version 2019-04-01 (#5472)

* Adds base for updating Microsoft.Batch from version stable/2018-12-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* add per family quota changes

* update the pfq values and descriptions

* Update specification/batch/resource-manager/Microsoft.Batch/stable/2019-04-01/BatchManagement.json

Co-Authored-By: jafreck <[email protected]>

* update quota fields with usersubscription behavior

* update descriptions from null to not returned

* remove duplicate text

* [Azure Search] Add filter property to autocomplete request for search SDK (#5532)

* initial change to add filter property to autocomplete request

* providing more clear description for filters in autocomplete

* [Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview (#5513)

* Updates API version in new specs and examples

* Adds base for updating Microsoft.VirtualMachineImages from version preview/2019-02-01-preview to version 2019-05-01-preview

* Updates readme

* Add ManagedIdentity, File customizer, fix bugs

* Fix examples

* fix to script

* updated readme enable-multi-api readmes

* Update CODEOWNERS (#5421)

* Update CODEOWNERS

* Update CODEOWNERS

* correction to latest profile.

* fixed case sensitivity for latest-profile generator

* corrected stable-2019-01 profile

* prepended enable-multi-api input-files with $(this-folder)

* Update package.json (#5555)

* Update 2019-04-01-profile.md

* [HDInsight] - Move API with version 2018-06-01-preview to stable folder (#5538)

* [HDInsight] - Move API with version 2018-06-01-preview to stable folder

* Update Readme.go

* Test moving the opt-in-extensible-enums: true to global yaml section. (#5558)

* [Azure Search] Introduce the minimumPrecision parameter for Entity recognition skill (#5553)

* Introduce the minimumPrecision parameter for Entity recognition skill

* Fix weird indentation

* tweak path

* revert change

* [DO NOT MERGE YET] Update OAD and OAV (#5564)

Update OAD and OAV

* [Hub Generated] Review request for Microsoft.Capacity to add version 2019-04-01 (#5403)

* Adds base for updating Microsoft.Capacity from version preview/2018-06-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* initial

* add example

* comma

* long running operation

* update api version

* renaming

* fix ref

* correcting examples

* examples

* adding example

* change parameter name

* descriptions

* updated description

* minor description update

* more description

* chore: Add initial .gitattributes for line endings (#4746)

No normalizaton, just tested updated .gitignore for some excluded files
when checking with `git rm -rf --cached . && git add .`

* Creating stable version for settings type (#5435)

* Adding stable API version for Settings

* Changing new version Settings file

* Add api version 2019-03-01 for Microsoft.Compute (#5492)

* Add api version 2019-03-01 for Microsoft.Compute

Add api version 2019-03-01 for Microsoft.Compute

* Update compute.json

Fix errors in spec

* Update readme.md

Add a new entry for 2019-03-01

* Update readme.md

Fix typo

* Add two new sku names for StorageAccount (#5547)

* fix: reservations\resource-manager\Microsoft.Capacity (#5569)

- Remove trailing newline in description
- specificed -> specified

* LUIS runtime changes (#5424)

* LUIS runtime changes

* Reverting some changes

* fix for relative paths

* DeploymentManager: Override client name for python SDK (#5489)

* Python SDK client name update

* Change C# AutoRest settings

* [Compute] Add new API Version and field (StorageAccountType) to SharedImageGallery swagger spec (#5528)

* add new api version and field for Shared Image Gallery

* fixed example json

* revert go file change

* revert changes that have not been merged over from crp previously

* fix indentation

* modified modelAsString to true

* add missing host information to alerts management (#5580)

* update latest-profile generator

* added dependencies for version comparisons

* updated latest-profile generator to include non-resource operations

* regenerated profile and added new telemetry

* updated non-generated profiles.

* Update readme.md

* Update arm-keyvault path in TS readme (#5563)

For updated path to arm-keyvault to be consistent with the moving armKeyvault repo

* Update Avocado to use new diff logic. (#5566)

* Avocado from GitHub

* new pipeline

* remove avocado.ts

* DO NOT MERGE

* Update package.json

* Revert "DO NOT MERGE"

This reverts commit 2585315.

* update stable-2019-01 profile

* Changed readme.md to add new ApiVersion 2019-03-01 tag package. Cloned a new folder for 2019-03-01 from 2018-10-01 and made version replacements. Added skipShutdown changes for PowerOff Api in 2019-03-01 compute.json for CRP and VMSS (#5560)

* update readme(ts) for arm-advisor path (#5590)

merging this is a known issue

* DeviceTelemetry event grid update (#5584)

* DeviceTelemetry event grid update

* Create dictionary structure for properties

* update readme.ts for arm-analysisservices path (#5594)

* Backfilling Microsoft.Resources and subscriptions Swagger specs up to 2019-03-01 API version (#5529)

* Copied 2018-05-01 resources.json spec with examples and 2016-06-01
subscriptions.json with examples to use as baseline for other changes.

* Subscription tenantId was added in 2018-06-01

* registrationPolicy was added to Provider in 2018-07-01

* API changes in 2018-09-01 do not impact swagger

* In 2019-03-01, capabilities property always shows up

* Removed intermediate API versions

* Updated config files

* Removed unreferenced managed identity example because there is no corresponding path in the Microsoft.Resources swagger

* Added missing references to onError deployment PUT examples

* Fixed example validation errors

* Fixed example timestamp format violations

* [Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-01-01 (#5568)

* Adds base for updating Microsoft.ApiManagement from version preview/2018-06-01-preview to version 2019-01-01

* Updates readme

* Updates API version in new specs and examples

* 2019-01-01 version initial changes

* chore: Renormalize line endings in stable releases (#5570)

Ran `git add --renormalize **/stable/**`

* updated arm-apimanagement path in readmeTS (#5595)

* move hdinsights package for Go back under preview directory (#5593)

* fix: batch/resource-manager/Microsoft.Batch (#5598)

- space in property name
- returnedable -> returnable

* Remove Cognitive Services Anomaly Detector Node.js package (#5440)

* fix: apimanagement/resource-manager/Microsoft.ApiManagement (#5597)

- containining -> containing

* The change is to support new resource type ProximityPlacementGroup (#5507)

* Merging https://github.com/Azure/azure-rest-api-specs-pr/pull/660

* Update the description to fix review comments

* Added description to fix CI warning

* Fix CI failure

* Fix CI failure

* Fixed examples

* Modify Example to include 201 response code

* updating protected Entity class with new UnprotectedDisk field (#5576)

* Container Services: Add API version 2019-04-30 for Azure RedHat OpenShift  (#5557)

* Initial 2019-04-30 check in

* Add/update/fix fields

* Add clusterVersion

* Update readme.md

* Update CODEOWNERS (#5421)

* Update CODEOWNERS

* Update CODEOWNERS

* Update package.json (#5555)

* [Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview (#5513)

* Updates API version in new specs and examples

* Adds base for updating Microsoft.VirtualMachineImages from version preview/2019-02-01-preview to version 2019-05-01-preview

* Updates readme

* Add ManagedIdentity, File customizer, fix bugs

* Fix examples

Initial 2019-04-30 check in

Add/update/fix fields

Add clusterVersion

Update readme.md

Update CODEOWNERS (#5421)

* Update CODEOWNERS

* Update CODEOWNERS

Update package.json (#5555)

Update CODEOWNERS (#5421)

* Update CODEOWNERS

* Update CODEOWNERS

Update package.json (#5555)

* Fix tag for Python/Go SDK generation

* Add package-2019-04-only

* Uodate yaml tag with value package-2019-04-only

* [Hub Generated] Review request for Microsoft.Devices to add version preview/2019-03-22-preview (#5544)

* Adds base for updating Microsoft.Devices from version preview/2018-12-01-preview to version 2019-03-22-preview

* Updates readme

* Updates API version in new specs and examples

* Adding swagger for Customer initiated failover

* Adding swagger for customer initiated failover

* Adding swagger for customer initiated failover

* Added properties for Message Enrichments to Iot Hub Routing Properties description

* Feedback

* Manual failover swagger

* update ReadmeTS for arm-appinsights path (#5602)

* update ReadmeTS for arm-appinsights path

* arm-appinsights folder updated

* update readmeTS for arm-appservice path (#5608)

* update readmeTS for arm-authorization path (#5603)

* Add operation result objects (#5469)

* Add operation result objects

* Fix spelling error with 'Programatic'

* Fix operation swagger. Successfully ran validate-spec tool on each one.

* Add new swagger files to readme.md

* Addition of HybridDataManager  (#5313)

* Create hybriddata.json

Added updated swagger file for Microsoft.HybridData

* Create readme.md

* Updated readme files

* Update readme.md

* Removed unused API endpoints

* Updated example files and swagger

* Fixed error in path to example files

* Fixed Go and Ruby Readme Files

* Added suppression for OperationIdNounVerb

* Added DataManagers_Update and examples

* Added suppression for ARM Violation and updated swagger and example files

* Updated swagger to sdk script for ruby

* Added Python swagger to sdk

* [Hub Generated] Review request for Microsoft.PolicyInsights to add version 2018-07-01-preview (#5408)

* Fix incorrect types

* Transform the type of expressionValue and targetValue to object type for the languages that support a generic object type.

* add compute 2019-03-01 to Go SDK (#5618)

* Added metrics baseline API (#5500)

* Added metrics baseline API

* Remove readonly

* Updated model name

* Renamed operation of older baseline apis

* Reverted braking change, updated new API to List

* Updated operation

* converted to correct List API

* Fixed semantic errors

* Changed the name of the enum

* [Hub Generated] Review request for Microsoft.ApiManagement to add version stable/2019-01-01 (#5613)

* Rename and fixes for .Net client

* Fix for Api Export on 2019-01-01

* Fix GET User Token Contract

* Fix definition for Deploy, Save, AccessInformationUpdate

* fix edits

* update example for deployment

* chore: Renormalize line endings in other files (#5596)

* hore: Renormalize line endings in preview releases

Ran `git add --renormalize **/preview/**`

* chore: Renormalize line endings in other files

Ran `git add --renormalize .`

* Add new API convertToSinglePlacementGroup for VM Scale Set. (#5614)

* Add billing time grains to budget properties (#5599)

* chore: Remove orphan Relay examples (#5621)

* 4253190    [Microsoft.Update.Admin] Resources missing from OpenApi Spec (#5620)

* 4253190    [Microsoft.Update.Admin] Resources missing from OpenApi Spec

* Update UpdateRuns.json

* Update UpdateRuns.json

* Version 0.2.0 of Anomaly Detector in Python (#5627)

* Compute v2019_03_01 Python (#5628)

* Compute v2019_03_01 Python

* Fix readme

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-01-01 (#5612)

* Remove management group scope for exports as we do not support it

* Add scope parameter

* syntax error fix

* updated examples with scope param and fixed syntax error

* fix scope param by removing '/' slash

* fix sorting params

* remove the direction param

* fix direction param name and add missing example

* Move arm in bulk1 (#5619)

* update arm-automation path in readme.TS

* update arm-azurestack path in readme.TS

* update arm-batch path in readme.TS

* update arm-batchai path in readme.TS

* update arm-billing path in readme.TS

* update arm-cdn path in readme.TS

* update arm-consumption path in readme.TS

* update arm-containerinstance path in readme.TS

* update arm-customerinsights path in readme.TS

* update arm-databox path in readme.TS

* update arm-databricks path in readme.TS

* update arm-datacatalog path in readme.TS

* update arm-datafactory path in readme.TS

* update arm-deploymentmanager path in readme.TS

* update arm-deviceprovsioningservices path in readme.TS

* update arm-devspaces path in readme.TS

* update arm-devtestlabs path in readme.TS

* update arm-dns path in readme.TS

* update arm-domainservices path in readme.TS

* update arm-edgegateway path in readme.TS

* update arm-eventgrid path in readme.TS

* update arm-eventhub path in readme.TS

* update arm-features path in readme.TS

* update arm-frontdoor path in readme.TS

* updated foldername for arm-features

* ImageBuilder May preview for Python (#5642)

* First version of data-plane swagger spec for Time Series Insights PAYG (Preview) SKU. (#5610)

* Fix or suppress spec violations
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.

* Try removing 2nd top-level heading, which _may_ have been causing a linter warning.

* Fix extra indention which prevented linter from running.

* Added dataStringComparisonBehavior parameter to reference data put/update spec.

* Fixed grammar.

* adding partitionkeyProperty to environmentInfo

* changing property name

* changing modelAsString

* Initial checkin of spec. Unchanged from GA release other than version.

* Remove .orig files

* Fix validation error by removing IoTHub ES from List ES example response

* Add extra example that was missing from preview spec.

* Add long-term environment to resource hierarchy, and update examples.

* Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource.

* Upsate sku description

* Add new TSI preview api-version to readme.md.

* Add suppressions for false-positive linter failures.

* Test suppression failures

* Adding preview package tag to several other places in readme.md

* Add preview package to the readme.go.md file

* Remove invalid required property from EnvironmentCreateOrUpdateParameters

* Initial version of data plane swagger spec for PAYG (Preview) SKU.

* Added missing Readme.md

* Fixed name of readme

* Fixed path to swagger json

* Attempt to fix readme

* Apply suggestions from code review

Co-Authored-By: dmdenmsft <[email protected]>

* Update timeseriesinsights.json

* Update timeseriesinsights.json

* Added link to oav issue

* Fix operation id of API convertToSinglePlacementGroup (#5640)

* Fix documentation link (#5636)

* Add sdkAutomationConfiguration.json file (#5639)

* Add sdkAutomationConfiguration.json file

* Add ruby to sdkAutomationConfiguration.json

* fix: Remove BOM for Avacodo errors (#5623)

* typo: frontdoor/resource-manager/Microsoft.Network (#5624)

- Double word "use"

* [Azure Search] Adding Complex Type support for index management (#5646)

* fix: Remove BOM for Avacodo errors (#5650)

* enum name change (#5654)

* ManagedDatabase get schemas,tables,columns API (#5171)

* DW deactivated error code

* managed database schema api

* resolve conflicts with prod

* adding schema API for databases. updates for MI schema API

* database schema examples

* added missing ServerNameParameter

* dummy commit

* remove empty properties

* remove empty properties

* remove empty properties

* remove empty properties

* remove empty properties

* remove empty properties

* remove empty properties

* remove empty properties

* remove empty properties

* Switch `breaking-changes` and `momentOfTruth` scripts to TypeScript (#5643)

Switch `breaking-changes` and `momentOfTruth` scripts to TypeScript

* add apimanagement 2019-01-01 to Go SDK (#5657)

* Fixing the parameters because they should not be readonly (#5658)

* Sensitivity labels: Disable/Enable recommended sensitivity labels (#5083)

* Add Disable/Enable recommended sensitivity label APIs

Add Disable/Enable recommended sensitivity label APIs

* SensitivityLabels - Update includeDisabledRecommendations parameter name and update descriptions

* Update sensitivity labels enable/disable APIs

* Move arm in bulk2 (#5641)

* update arm-compute path in readme.TS

* update arm-cognitiveservices path in readme.TS

* update arm-cosmosdb path in readme.TS

* update arm-hanaonazure path in readme.TS

* update arm-hdinsight path in readme.TS

* update arm-iotcentral path in readme.TS

* update arm-iothub path in readme.TS

* update arm-iotspaces path in readme.TS

* update arm-kusto path in readme.TS

* update arm-labservices path in readme.TS

* update arm-links path in readme.TS

* update arm-locks path in readme.TS

* update arm-logic and arm-machinelearningcompute path in readme.TS

* update arm-machinelearningservices path in readme.TS

* update arm-machinelearningexperimenatation path in readme.TS

* update arm-managedapplications path in readme.TS

* update arm-managementgroups path in readme.TS

* update arm-managementpartner path in readme.TS

* update arm-maps path in readme.TS

* update arm-mariadb path in readme.TS

* update arm-marketplaceordering path in readme.TS

* update arm-mediaservices path in readme.TS

* update arm-migrate path in readme.TS

* update arm-mixedreality path in readme.TS

* update arm-monitor path in readme.TS

* update arm-msi path in readme.TS

* update arm-mysql path in readme.TS

* update arm-netapp path in readme.TS

* update arm-network path in readme.TS

* update arm-notificationhubs path in readme.TS

* update arm-operationalinsights path in readme.TS

* update arm-operations path in readme.TS

* update arm-policy path in readme.TS

* update arm-policyinsights path in readme.TS

* update arm-postgresql path in readme.TS

* update arm-powerbidedicated path in readme.TS

* update arm-powerbiembedded path in readme.TS

* update arm-privatedns path in readme.TS

* update arm-recoveryservices path in readme.TS

* update arm-recoveryservices-siterecovery path in readme.TS

* update arm-recoveryservicesbackup path in readme.TS

* update arm-rediscache path in readme.TS

* update arm-relay path in readme.TS

* update arm-reservations path in readme.TS

* update arm-resourcegraph path in readme.TS

* update arm-resourcehealth path in readme.TS

* update arm-resources path in readme.TS

* update arm-search path in readme.TS

* update arm-security path in readme.TS

* update arm-servicebus path in readme.TS

* update arm-servicemap path in readme.TS

* update arm-signalr path in readme.TS

* update arm-sql path in readme.TS

* update arm-sqlvirtualmachine path in readme.TS

* update arm-storage path in readme.TS

* update arm-storageimportexport path in readme.TS

* update arm-storagesync path in readme.TS

* update arm-storsimple1200series path in readme.TS

* update arm-storsimple8000series path in readme.TS

* update arm-streamanalytics path in readme.TS

* update arm-subscriptions path in readme.TS

* update arm-timeseriesinsights path in readme.TS

* update arm-trafficmanager path in readme.TS

* update arm-visualstudio path in readme.TS

* update arm-webservices path in readme.TS

* update arm-workspaces path in readme.TS

* moved arm-webservices, arm-commitmentplans nad arm-workspaces under machinelearning folder

* update arm-containerregistry path in readme.TS

* update arm-containerservice path in readme.TS

* update service folder name for arm-operations

* update service folder name for arm-mariadb

* update service folder name for arm-subscriptions

* update service folder name for arm-recoveryservices-siterecovery

* update service folder name for arm-servicemap

* update service folder name for arm-rediscache

* Move dataplane packages - batch3 (#5644)

* update eventgrid path in readme.TS

* update batch path in readme.TS

* update cognitiveservices-anomalydetector path in readme.TS

* update cognitiveservices-autosuggest path in readme.TS

* update cognitiveservices-autosuggest and cognitiveservices-computervision path in readme.TS

* update cognitiveservices-contentmoderator path in readme.TS

* update cognitiveservices-customimagesearch path in readme.TS

* update cognitiveservices-customsearch path in readme.TS

* update cognitiveservices-customvision-prediction path in readme.TS

* update cognitiveservices-customvision-training path in readme.TS

* update cognitiveservices-entitysearch path in readme.TS

* update cognitiveservices-face path in readme.TS

* update cognitiveservices-imagesearch path in readme.TS

* update cognitiveservices-localsearch path in readme.TS

* update cognitiveservices-luis-authoring path in readme.TS

* update cognitiveservices-luis-runtime path in readme.TS

* update cognitiveservices-newssearch path in readme.TS

* update cognitiveservices-qnamaker path in readme.TS

* update cognitiveservices-spellcheck path in readme.TS

* update cognitiveservices-textanalytics path in readme.TS

* update cognitiveservices-videosearch path in readme.TS

* update cognitiveservices-visualsearch path in readme.TS

* update cognitiveservices-websearch path in readme.TS

* update graph path in readme.TS

* update loganalytics path in readme.TS

* update servicefabric path in readme.TS

* update storage-datalake path in readme.TS

* renamed the service folder name for graph and loganalytics dataplane  packages

* add reservations 2019-04-01 preview to Go SDK (#5656)

* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-01-01 (#5601)

* Fix urls of external docs from consumption to cost management

* Update enum of billing timegrain for budget API

* Revert "Update enum of billing timegrain for budget API"

This reverts commit 177ac54.

* Update enum of billing timegrain for budget API

* Add billing timeframe to export API

* Move enum values to the end

* Fixing operation id to be named consistently (#5666)

* Fix Travis-CI bug (#5669)

* Databricks Python configuration (#5670)

* Use object type (#5672)

* update readme.TS for arm-commerce and applicationinsights-query path (#5667)

* Automation for Python (#5671)

* Rename sdkAutomationConfiguration.json to specificationRepositoryConfiguration.json (#5679)

* [Hub Generated] Review request for Microsoft.IoTCentral to add version 2018-09-01 (#5495)

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* Add IOT central app templates api in swagger

* HanaOnAzure: Re-save JSON files using VSCode JSON formatter (#5673)

* HanaOnAzure: Re-save JSON files using VSCode JSON formatter

* Install recommended VSCode extensions and re-save files

* Resolve issue with unreferenced examples in Network specs for older API versions (#5675)

* Resolve issue with unreferenced examples in Network specs for older API versions

* Fixes for NW examples to resolve OAV errors

* Use `breaking-changes` and `momentOfTruth` from `@azure/rest-api-specs-scripts` (#5660)

* Breaking Change2

* Experimental lintdiff

* No more model/semantic/syntax validations in travis-CI.

* Scripts 0.1.8

* Use scripts from @azure/rest-api-specs-scripts

* ts-utils

* fix breaking changes

* Update supported os family (#5668)

* Fix Go SDK for cognitiveservices/anomalydetector (#5686)

This endpoint requires client-side TLS renegotiation to be enabled.
Add a directive to modify the codegen to enable renegotiation.

* Fix examples (#5690)

* Adding sdk support for Encryption with customer managed key to the Azure Search specs (#5567)

* Add encryption

* change format and fix comment

* Remove UUID

* Update descriptions

* Update description based on PR feedback

* Add encrypted example

* Update examples

* Update descriptions

* Update customer managed keys to customer-managed keys

* Update descriptions

* Updated descriptions

* Update encryption key description

* Update description to use customer-managed instead of user-managed or user-defined

* Add unreferenced examples for service endpoint policy to VirtualNetwork specs (#5693)

* pipeline (#5699)

* Corrected specs and examples for BillingRP (#5682)

* Added specs for Agreements API in version 2018-11-01-preview

Added specs for Agreements API in version 2018-11-01-preview

* Updated as per naming convension

Updated as per naming convension

* Corrected specs and examples for BillingRP

Corrected specs and examples for BillingRP

* Fixed the errors

Fixed the errors

* Fixing errors in spec

Fixing errors in spec

* Updated examples

Updated examples

* Incorporated review comments

Incorporated review comments

* Incorporated review comments

* Incorporated review comments

Incorporated review comments

* Add SQL, Mongo, Table, Cassandra APIs (#5523)

* Add Database and Collection API

* Add SQL Database and Container API

* Remove properties in CreateUpdateOptions

* Update delete response code

* Add properties in SQL Container and simplify names

* Add Mongo Database and Collection API

* Add Table API

* Add Cassandra keyspace and table API

* Add Gremlin API

* Fix excluded key path

* Fix examples model validation

* Remove duplicated id from example

* Fix example CosmosDBGremlinContainerCreateUpdate

* Azure/rest-api-specs-scripts with new di (#5701)

* typo: cosmos-db/resource-manager/Microsoft.DocumentDB (#5705)

* typo: cosmos-db/resource-manager/Microsoft.DocumentDB

- contianer -> container

* chore: Use Xenial image

* Added back ProximityPlaceGroup APIs which are missing in 2019-03-01 (#5692)

* [Hub Generated] Review request for Microsoft.ResourceGraph to add version 2018-09-01-preview (#5451)

* Add resourceChanges and resourceChangeDetails actions

* Fix examples

Add titles and descriptions
Add wrapping 'parameters'

* Fix examples

Rename 'top' to '$top', 'skipToken' to '$skipToken'

* Fix resourceChangeDetails example

Add changeId to resourceChangeDetails response example

* Adds suppression to readme

* fix unhandled promises (#5711)

* fix unhandled promises

* allow mode validation to fail.

* fix syntax failure.

* Update preproduction-azure-pipelines.yml (#5716)

* Update preproduction-azure-pipelines.yml

* Update preproduction-azure-pipelines.yml

* Improve Batch documentation (#5700)

- Improved application package references documentation.
  - Improved max tasks per node documentation.
  - Improved spread vs pack documentation.
  - Improved documentation about task idempotency.

* Dev batch microsoft.batch 2019 04 01- Fix swagger spec incorrect nullable property (#5720)

* Adds base for updating Microsoft.Batch from version stable/2018-12-01 to version 2019-04-01

* Updates readme

* Updates API version in new specs and examples

* add per family quota changes

* update the pfq values and descriptions

* Update specification/batch/resource-manager/Microsoft.Batch/stable/2019-04-01/BatchManagement.json

Co-Authored-By: jafreck <[email protected]>

* update quota fields with usersubscription behavior

* update descriptions from null to not returned

* remove duplicate text

* correct nullable properties

* Storage Python 2019-04-01 (#5659)

* [Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 (#5715)

* Task 4321317: RI renewal : ARM review

* Task 4321317: RI renewal : ARM review

* Task 4321317: RI renewal : ARM review

* Task 4321317: RI renewal : ARM review

* Task 4321317: RI renewal : ARM review

* FW: More changes

* FW: More changes

* FW: More changes

* Task 4321317: RI renewal : ARM review

* Task 4321317: RI renewal : ARM review

* Task 4321317: RI renewal : ARM review

* Updating description of enableAutomaticUpdates and enableAutomaticOSUpgrade (#5697)

* Updating descriptions

* Add suggestion

Co-Authored-By: Deepali-Gupta <[email protected]>

* Updating with suggestion

Co-Authored-By: Deepali-Gupta <[email protected]>

* Build release (#5717)

* Adds base for updating Microsoft.Network from version stable/2018-12-01 to version 2019-02-01

* Updates readme

* Updates API version in new specs and examples

* Remove Alert action from user rules (#5428)

* Patch call for DDoS Protection plan (#5426)

* Patch call for DDoS Protection plan

Removing unreferenced definition

Addressing review comments. Setting x-ms-long-running-operation to false

Removing tags from Patch call description

Fixing the response message description

Removing x-ms-long-running-operation from patch

fixing the file renames

* Adding patch call to 2019-02-01

* fixing date

* fixing semantic error

* Addressing review comments

* Fixed examples for WAFPolicy (#5454)

* Added missing descriptions in Network specs (#5490)

* Added missing descriptions in Network specs

* Add missing x-ms-enum

* Updated VNet Gateways operations: Fix for #4642 (#5223)

* Adds base for updating Microsoft.Network from version stable/2018-12-01 to version 2018-12-01

* Updates readme

* Updates API version in new specs and examples

* Updated VNet Gateways operations: Fix for #4642

* Network: Duplicate tags in readme file. (#5227)

* Added missing change. Extended to new API version

* Copy changes for AppGw from 2018-12-01 (#5463)

* Correct Azure Firewall Rule Action in Examples (#5514)

* Swagger has to just enforce a positive fileUploadLimitInMb, It doesnt have to check the upper Limit. (#5527)

*  Swagger has to just enforce a non-negative fileupload limit, need not do the upper limit check

* rolling back

* Swagger has to just enforce a positive fileUploadLimitInMb, It doesnt have to check the upper Limit.

* removed unused flag allowglobalreach (#5539)

* Stub YML config for validating NRP PRs (#5550)

* Add new protocols (#5582)

* Update readme.python.md

* Remove extra "x-ms-enum" (#5617)

* Added missing x-ms-long-running-operation-options (#5572)

* Initial commit (#5635)

* Add new Nat Gateway resource (#5579)

* Add new Nat Gateway resource

* Update API version

* Update PR comments

* Update nat gateway

* Fix json errors

* Updated nat gateway

* Update Nat Gateway examples name

* Update Examples with 202

* Need to update with latest master since network.csproj is failing on azure-powershell

* azure firewall revert alert

* Update NatGateway

* Update nat gateway tags

* Remove basic sku since it is not supported

* Add application gateway backendHealthOnDemand Operation (#5552)

* Add application gateway backendHealthOnDemand Operation

* Update ApplicationGatewayBackendHealthTest.json

* change backendHealthOnDemand to getBackendHealthOnDemand

* add x-ms-long-running-operation-options

* fix api version

* Add disableBgpRoutePropagation (#5585)

* Add disableBgpRoutePropagation

* Reformat

* Move Network validation config to azure-pipelines.yml (#5589)

* Move Network validation config to azure-pipelines.yml

* Add continueOnError to Network validation

* Resolve issue with unreferenced examples in Network specs (#5674)

* Swagger changes for useLocalAzureIpAddress property. (#5678)

* Fixed allow Vnet description (#5696)

* Remove duplicate enums from Network specs (#5647)

* Remove duplicate enums

* Remove readOnly from references to definitions that are already marked as read only

* Add missing descriptions (#5662)

* Remove duplicate enum ApplicationGatewayProtocol (#5708)

* Update examples to include custom routes parameter (#5710)

* fixed mistyping

* Fix examples

* Rollback typo fix

* [Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview (#5723)

* Update description of property "destination" in "ImageTemplateFileCustomizer"

* Update min and max values of property "buildTimeoutInMinutes"

* Fix a bug to reflect the actual resource naming pattern (which allows dot) of the service

* Use correct "artifactTags" instead of "tags" for distribute in examples

* Fix an example by removing unnecessary field "imageId"

* generate GO SDK for 2019-05-01-preview

* Re-generate python SDK

* fix go sdk for 2019-05-01-preview package

* Fix example response status codes

* Remove duplicate unreferenced example

* Fix update identity example by including identity section in the response

* Fix PATCH examples for 202 response

* Fix async operation urls in responses

* Find AutoRest (#5728)

* Install AutoRest

* use AutoRest from 'node_modules'

* dummy change

* 202

* 203

* 204

* OAD 0.6.0

* 206

* OAD 0.6.1

* OAD 0.6.2

* Revert test changes

* OAD 0.6.3

* 0.5.1

* rest-api-spec-scripts 0.2.21

* Mark output blob sas url as mandatory parameter in GetVpnSitesConfigu… (#5731)

* Mark output blob sas url as mandatory parameter in GetVpnSitesConfigurationRequest

* Fix linter errors

* add serialconsole package-2018-05 to Go SDK (#5736)

* add serialconsole package-2018-05 to Go SDK

* fix ordering of swagger-to-sdk section

* refactor input section and remove global output-folder

* Support Update properties (#5729)

* Support Update properties

* Update specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/stable/2017-04-18/cognitiveservices.json

Co-Authored-By: yangyuan <[email protected]>

* Managed instance updates plus examples (#5730)

* Initializing instance pools swagger and examples - no usages / managed instances get by instance pool

* updates to mi examples + swagger

* Use common definitions

* Remove unused def

* Update specification/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/managedInstances.json

Fix based on suggestion. Made code changes internally.

Co-Authored-By: johnpaulkee <[email protected]>

* Update specification/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/managedInstances.json

Fix typo based on suggestion. Fixed internally so that this doesn't come back from regen.

Co-Authored-By: johnpaulkee <[email protected]>

* Fix managed instance create max public endpoint value

* Update managed instance update public endpoint example to bool

* Making sub casing match for an example - retriggering build for PR

* VnetInfo CertBlob format changed to string (#5655)

* Add ErrorResponse to "AddIntent" post (#5741)

* Add ErrorResponse to "/apps/{appId}/versions/{versionId}/intents" post

* Adjust enums of /definitions/ReadableType

- Add "Closed List Entity Extractor "to enum list
- Add "Regex Entity Extractor" to enum list

* Updated the operation id for Billing spec (#5727)

* Added specs for Agreements API in version 2018-11-01-preview

Added specs for Agreements API in version 2018-11-01-preview

* Updated as per naming convension

Updated as per naming convension

* Corrected specs and examples for BillingRP

Corrected specs and examples for BillingRP

* Fixed the errors

Fixed the errors

* Fixing errors in spec

Fixing errors in spec

* Updated examples

Updated examples

* Incorporated review comments

Incorporated review comments

* Incorporated review comments

* Incorporated review comments

Incorporated review comments

* Updated the operation id for Billing spec

Updated the operation id for Billing spec

* Incorporated review comments

Incorporated review comments

* Incorporated review comments

Incorporated review comments

* Fixed the errors

Fixed the errors

* Added multiple inputs

Added multiple inputs

* Fixed build errors

Fixed build errors

* Incorporated review comments

Incorporated review comments

* Incorporated review comments

* add network 2019-02-01 to Go SDK (#5735)

* [Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 (#5745)

* FW: [Revert][Hub Generated] Review request for Microsoft.Capacity to add version preview/2019-04-01 (#5715)

* Refactor enum list of /definitions/ReadableType (#5747)

- Remove unnecessary "Regular Expression Entity Extractor"

* Update rest-api-spec-scripts to 0.2 and remote travis-ci jobs (except… (#5742)

* Update rest-api-spec-scripts to 0.2 and remote travis-ci jobs (except branch check)

* return semantic and model

* minor

* modelValidation and semanticValidation use avocado diff.

* Install .Net

* semantic and model

* restore travis

* minor

* Fix documentation issues. (#5721)

* Introduce toBeDetached flag for Datadisks for ApiVersion 2019-03-01 (#5704)

* ToBeDetached added in Json and an example added

* Removed from OS disk and added to dataDisk

* Initial stable version (#5683)

* NFSAAS-2185 update to R4 standard

* NFSAAS-2185 update to R4 RP standard

* NFSAAS-2185 update to R4 RP standard

* NFSAAS-2185 update to R4 RP standard

* NFSAAS-2185 update to RP R4 standard

* NFSAAS-2185 update to R4 RP standard

* NFSAAS-2185 update to R4 RP standard

* NFSAAS-2185 update to R4 RP standard

* NFSAAS-2185 update to R4 RP standard

* Adds Partners GET (#5726)

* generated latest multiapi readmes

* updated latest profile generator to generate profile with date labels

* generated latest profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants