Skip to content

fix cases variable names #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehudklein wants to merge 1 commit into from
Closed

fix cases variable names #5577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 52 additions & 22 deletions ...ource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"tags": [
"Alert Rules"
],
"description": "Gets all alert rules.",
"description": "Gets all scheduled alert rules.",
"operationId": "AlertRules_List",
"parameters": [
{
Expand All @@ -92,7 +92,7 @@
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/AlertRulesList"
"$ref": "#/definitions/ScheduledAlertRulesList"
}
},
"default": {
Expand All @@ -117,7 +117,7 @@
"tags": [
"Alert Rules"
],
"description": "Gets the alert rule.",
"description": "Gets the scheduled alert rule.",
"operationId": "AlertRules_Get",
"parameters": [
{
Expand All @@ -143,7 +143,7 @@
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/AlertRule"
"$ref": "#/definitions/ScheduledAlertRule"
}
},
"default": {
Expand All @@ -163,7 +163,7 @@
"tags": [
"Alert Rules"
],
"description": "Creates or updates the alert rule.",
"description": "Creates or updates the scheduled alert rule.",
"operationId": "AlertRules_CreateOrUpdate",
"parameters": [
{
Expand All @@ -185,20 +185,20 @@
"$ref": "#/parameters/RuleId"
},
{
"$ref": "#/parameters/AlertRule"
"$ref": "#/parameters/ScheduledAlertRule"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/AlertRule"
"$ref": "#/definitions/ScheduledAlertRule"
}
},
"201": {
"description": "Created",
"schema": {
"$ref": "#/definitions/AlertRule"
"$ref": "#/definitions/ScheduledAlertRule"
}
},
"default": {
Expand Down Expand Up @@ -1580,7 +1580,7 @@
}
}
},
"AlertRuleKind": {
"AlertRuleKind": {
Copy link
Contributor

@kpajdzik kpajdzik Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think previous formatting was more correct.

"type": "object",
"description": "Describes an Azure resource with kind.",
"properties": {
Expand All @@ -1602,7 +1602,27 @@
}
}
},
"ScheduledAlertRule": {
"ScheduledAlertRulesList": {
"description": "List all the schdeuled alert rules.",
Copy link
Contributor

@nschonni nschonni Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "List all the schdeuled alert rules.",
"description": "List all the scheduled alert rules.",

"properties": {
"nextLink": {
"readOnly": true,
"description": "URL to fetch the next set of scheduled alert rules.",
"type": "string"
},
"value": {
"description": "Array of scheduled alert rules.",
"type": "array",
"items": {
"$ref": "#/definitions/ScheduledAlertRule"
}
}
},
"required": [
"value"
]
},
"ScheduledAlertRule": {
Copy link
Contributor

@kpajdzik kpajdzik Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

"x-ms-discriminator-value": "Scheduled",
"type": "object",
"description": "Represents scheduled alert rule.",
Expand Down Expand Up @@ -1813,7 +1833,7 @@
},
"properties": {
"x-ms-client-flatten": true,
"description": "Case properties",
"description": "Case properties",
Copy link
Contributor

@kpajdzik kpajdzik Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

"$ref": "#/definitions/CaseProperties"
}
}
Expand All @@ -1822,47 +1842,47 @@
"type": "object",
"description": "Describes case properties",
"properties": {
"lastUpdatedTimeUtc": {
"LastUpdatedTimeUtc": {
"type": "string",
"format": "date-time",
"description": "The last time the case was updated"
},
"createdTimeUtc": {
"CreatedTimeUtc": {
"type": "string",
"format": "date-time",
"description": "The time the case was created"
},
"endTimeUtc": {
"EndTimeUtc": {
"type": "string",
"format": "date-time",
"description": "The end time of the case"
},
"startTimeUtc": {
"StartTimeUtc": {
"type": "string",
"format": "date-time",
"description": "The start time of the case"
},
"labels": {
"Labels": {
"type": "array",
"items": {
"$ref": "#/definitions/Label"
},
"description": "List of labels relevant to this case"
},
"description": {
"Description": {
"type": "string",
"description": "The description of the case"
},
"title": {
"Title": {
"type": "string",
"description": "The title of the case"
},
"assignedTo": {
"AssignedTo": {
"type": "object",
"description": "Describes a user that the case is assigned to",
"$ref": "#/definitions/UserInfo"
},
"severity": {
"Severity": {
"type": "string",
"description": "The severity of the case",
"enum": [
Expand Down Expand Up @@ -1899,7 +1919,7 @@
]
}
},
"status": {
"Status": {
"type": "string",
"description": "The status of the case",
"enum": [
Expand Down Expand Up @@ -1931,7 +1951,7 @@
]
}
},
"closeReason": {
"CloseReason": {
"type": "string",
"description": "The reason the case was closed",
"enum": [
Expand Down Expand Up @@ -2942,6 +2962,16 @@
"$ref": "#/definitions/AlertRule"
},
"x-ms-parameter-location": "method"
},
"ScheduledAlertRule": {
Copy link
Contributor

@kpajdzik kpajdzik Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

"name": "scheduledAlertRule",
"in": "body",
"description": "The scheduled alert rule",
"required": true,
"schema": {
"$ref": "#/definitions/ScheduledAlertRule"
},
"x-ms-parameter-location": "method"
},
"ActionId": {
"name": "actionId",
Expand Down