Skip to content

Resolve issue with unreferenced examples in Network specs for older API versions #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 2 commits into from
Apr 17, 2019
Merged

Resolve issue with unreferenced examples in Network specs for older API versions #5675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
346afca
Resolve issue with unreferenced examples in Network specs for older A…
nschonni Apr 12, 2019
ff55cfe
Fixes for NW examples to resolve OAV errors
anton-evseev Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Resolve issue with unreferenced examples in Network specs for older A… 
…PI versions
  • Loading branch information
@nschonni @anton-evseev
nschonni authored and anton-evseev committed Apr 17, 2019
commit 346afca19c65807e4ea8a5e5bd12c96ff649c984
12 changes: 2 additions & 10 deletions ...rce-manager/Microsoft.Network/stable/2017-06-01/examples/LoadBalancerCreateWithZones.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"location": "eastus",
"sku": {
"name": "Basic"
},
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfigurations": [
Expand Down Expand Up @@ -170,8 +167,7 @@
},
"probe": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/probes/probe-lb"
},
"disableOutboundSnat": false
}
}
}
],
Expand Down Expand Up @@ -222,9 +218,6 @@
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"location": "eastus",
"sku": {
"name": "Basic"
},
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfigurations": [
Expand Down Expand Up @@ -286,8 +279,7 @@
},
"probe": {
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/probes/probe-lb"
},
"disableOutboundSnat": false
}
}
}
],
Expand Down
5 changes: 4 additions & 1 deletion specification/network/resource-manager/Microsoft.Network/stable/2017-06-01/loadBalancer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@
"x-ms-examples": {
"Create load balancer": {
"$ref": "./examples/LoadBalancerCreate.json"
},
"Create load balancer with Frontend IP in Zone 1": {
"$ref": "./examples/LoadBalancerCreateWithZones.json"
}
},
"x-ms-long-running-operation": true
Expand Down Expand Up @@ -1638,4 +1641,4 @@
"description": "Client API version."
}
}
}
}
62 changes: 61 additions & 1 deletion ...fication/network/resource-manager/Microsoft.Network/stable/2017-06-01/networkWatcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@
"$ref": "#/definitions/NetworkWatcher"
}
}
},
"x-ms-examples": {
"Create Network Watcher": { "$ref": "./examples/NetworkWatcherCreate.json" }
}
},
"get": {
Expand Down Expand Up @@ -124,6 +127,9 @@
"$ref": "#/definitions/NetworkWatcher"
}
}
},
"x-ms-examples": {
"Get Network Watcher": { "$ref": "./examples/NetworkWatcherGet.json" }
}
},
"delete": {
Expand Down Expand Up @@ -162,6 +168,9 @@
"204": {
"description": "Delete successful."
}
},
"x-ms-examples": {
"Delete Network Watcher": { "$ref": "./examples/NetworkWatcherDelete.json" }
}
}
},
Expand Down Expand Up @@ -195,6 +204,9 @@
}
}
},
"x-ms-examples": {
"List Network Watchers": { "$ref": "./examples/NetworkWatcherList.json" }
},
"x-ms-pageable": {
"nextLinkName": null
}
Expand Down Expand Up @@ -223,6 +235,9 @@
}
}
},
"x-ms-examples": {
"List Network Watchers": { "$ref": "./examples/NetworkWatcherListAll.json" }
},
"x-ms-pageable": {
"nextLinkName": null
}
Expand Down Expand Up @@ -273,6 +288,9 @@
"$ref": "#/definitions/Topology"
}
}
},
"x-ms-examples": {
"Get Topology": { "$ref": "./examples/NetworkWatcherTopologyGet.json" }
}
}
},
Expand Down Expand Up @@ -328,6 +346,9 @@
"$ref": "#/definitions/VerificationIPFlowResult"
}
}
},
"x-ms-examples": {
"Verify IP Flow": { "$ref": "./examples/NetworkWatcherIpFlowVerify.json" }
}
}
},
Expand Down Expand Up @@ -383,6 +404,9 @@
"$ref": "#/definitions/NextHopResult"
}
}
},
"x-ms-examples": {
"Get Next Hop": { "$ref": "./examples/NetworkWatcherNextHopGet.json" }
}
}
},
Expand Down Expand Up @@ -438,6 +462,9 @@
"$ref": "#/definitions/SecurityGroupViewResult"
}
}
},
"x-ms-examples": {
"Get Security Group View": { "$ref": "./examples/NetworkWatcherSecurityGroupViewGet.json" }
}
}
},
Expand Down Expand Up @@ -494,6 +521,9 @@
"$ref": "#/definitions/PacketCaptureResult"
}
}
},
"x-ms-examples": {
"Create Packet Capture": { "$ref": "./examples/NetworkWatcherPacketCaptureCreate.json" }
}
},
"get": {
Expand Down Expand Up @@ -538,6 +568,9 @@
"$ref": "#/definitions/PacketCaptureResult"
}
}
},
"x-ms-examples": {
"Create Packet Capture": { "$ref": "./examples/NetworkWatcherPacketCaptureGet.json" }
}
},
"delete": {
Expand Down Expand Up @@ -583,6 +616,9 @@
"202": {
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-examples": {
"Delete Packet Capture": { "$ref": "./examples/NetworkWatcherPacketCaptureDelete.json" }
}
}
},
Expand Down Expand Up @@ -630,6 +666,9 @@
"202": {
"description": "Accepted and the operation will complete asynchronously."
}
},
"x-ms-examples": {
"Stop Packet Capture": { "$ref": "./examples/NetworkWatcherPacketCaptureStop.json" }
}
}
},
Expand Down Expand Up @@ -686,6 +725,9 @@
"$ref": "#/definitions/PacketCaptureQueryStatusResult"
}
}
},
"x-ms-examples": {
"Get Packet Capture status": { "$ref": "./examples/NetworkWatcherPacketCaptureQueryStatus.json" }
}
}
},
Expand Down Expand Up @@ -726,6 +768,9 @@
}
}
},
"x-ms-examples": {
"List Packet Captures": { "$ref": "./examples/NetworkWatcherPacketCapturesList.json" }
},
"x-ms-pageable": {
"nextLinkName": null
}
Expand Down Expand Up @@ -783,6 +828,9 @@
"$ref": "#/definitions/TroubleshootingResult"
}
}
},
"x-ms-examples": {
"Troubleshoot Resource": { "$ref": "./examples/NetworkWatcherTroubleshootGet.json" }
}
}
},
Expand Down Expand Up @@ -838,6 +886,9 @@
"$ref": "#/definitions/TroubleshootingResult"
}
}
},
"x-ms-examples": {
"Get Troubleshoot result": { "$ref": "./examples/NetworkWatcherTroubleshootResultQuery.json" }
}
}
},
Expand Down Expand Up @@ -893,6 +944,9 @@
"$ref": "#/definitions/FlowLogInformation"
}
}
},
"x-ms-examples": {
"Configure Flow Logs": { "$ref": "./examples/NetworkWatcherFlowLogConfigure.json" }
}
}
},
Expand Down Expand Up @@ -948,6 +1002,9 @@
"$ref": "#/definitions/FlowLogInformation"
}
}
},
"x-ms-examples": {
"Query Flow Log Status": { "$ref": "./examples/NetworkWatcherFlowLogStatusQuery.json" }
}
}
},
Expand Down Expand Up @@ -1003,6 +1060,9 @@
"$ref": "#/definitions/ConnectivityInformation"
}
}
},
"x-ms-examples": {
"Check Connectivity": { "$ref": "./examples/NetworkWatcherConnectivityCheck.json" }
}
}
}
Expand Down Expand Up @@ -2005,4 +2065,4 @@
"description": "Client API version."
}
}
}
}
5 changes: 4 additions & 1 deletion ...fication/network/resource-manager/Microsoft.Network/stable/2017-06-01/virtualNetwork.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@
},
"Create virtual network with subnet": {
"$ref": "./examples/VirtualNetworkCreateSubnet.json"
},
"Create virtual network with service endpoints": {
"$ref": "./examples/VirtualNetworkCreateServiceEndpoints.json"
}
}
}
Expand Down Expand Up @@ -1219,4 +1222,4 @@
"description": "Client API version."
}
}
}
}
4 changes: 3 additions & 1 deletion specification/network/resource-manager/Microsoft.Network/stable/2017-08-01/loadBalancer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@
}
},
"x-ms-examples": {
"Create load balancer": { "$ref": "./examples/LoadBalancerCreate.json" }
"Create load balancer": { "$ref": "./examples/LoadBalancerCreate.json" },
"Create load balancer with Standard SKU": { "$ref": "./examples/LoadBalancerCreateStandardSku.json" },
"Create load balancer with Frontend IP in Zone 1": { "$ref": "./examples/LoadBalancerCreateWithZones.json" }
},
"x-ms-long-running-operation": true
}
Expand Down
4 changes: 3 additions & 1 deletion specification/network/resource-manager/Microsoft.Network/stable/2017-09-01/loadBalancer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@
}
},
"x-ms-examples": {
"Create load balancer": { "$ref": "./examples/LoadBalancerCreate.json" }
"Create load balancer": { "$ref": "./examples/LoadBalancerCreate.json" },
"Create load balancer with Standard SKU": { "$ref": "./examples/LoadBalancerCreateStandardSku.json" },
"Create load balancer with Frontend IP in Zone 1": { "$ref": "./examples/LoadBalancerCreateWithZones.json" }
},
"x-ms-long-running-operation": true
},
Expand Down
Loading