Switch to the @azure/[email protected] and convert JS to TypeScript. #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

sergey-shandar wants to merge 23 commits into master from sergey/scripts

Contributor

sergey-shandar commented Apr 17, 2019 •

edited

Loading

This PR should be merged after preproduction CI is validated in a private repo.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

sergey-shandar added 16 commits

April 15, 2019 17:21


          Breaking Change2

5f9a909


          Experimental lintdiff

5700f08


          No more model/semantic/syntax validations in travis-CI.

cb5caa5


          Scripts 0.1.8

3e2a0c6


          Use scripts from @azure/rest-api-specs-scripts

39cad03


          ts-utils

5151be7


          fix breaking changes

4d24cf6


          momentOfTruthPostProcessing

f597442


          momentOfTruthPostProcessing.ts

794b245


          remove 'ts-utils.ts'

151ed28


          Remove utils

acfad34


          postToGitHub.ts

ae39843


          switch to momentOfTruthUtils

30285c0


          minor

36eff22


          Syntax.ts

c30473c


          semanticValidation.ts

9f0ac27

AutorestCI commented Apr 17, 2019 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

AutorestCI commented Apr 17, 2019 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

AutorestCI commented Apr 17, 2019 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

AutorestCI commented Apr 17, 2019 •

edited

Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

AutorestCI commented Apr 17, 2019 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

sergey-shandar self-assigned this


          Merge from master

466b17f

sergey-shandar changed the title ~~Sergey/scripts~~ [Don't merge] This PR should be merged only after diff switch to Avocado

Contributor

azuresdkci commented Apr 18, 2019

Can one of the admins verify this patch?


          another try

3e694ea

nschonni reviewed

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

sergey-shandar mentioned this pull request

Using avocado diff algorithm instead of 'git fetch' Azure/rest-api-specs-scripts#3

Merged

sergey-shandar added 2 commits

April 19, 2019 10:30


          minor update

67ced89


          URL/fix

95cbfde

sergey-shandar added 3 commits

April 19, 2019 15:51


          OAD ^0.2.13

c0cac7a


          Merge rom master

2cec6cc


          update to new scripts.

a7a4f79

sergey-shandar changed the title ~~[Don't merge] This PR should be merged only after diff switch to Avocado~~ [Don't merge] This PR should be merged after preproduction CI is validated in a private repo

sergey-shandar assigned veronicagg

sergey-shandar marked this pull request as ready for review

April 19, 2019 23:20

sergey-shandar added the DoNotMerge label

sergey-shandar removed their assignment

sergey-shandar requested a review from veronicagg

April 19, 2019 23:22

sergey-shandar changed the title ~~[Don't merge] This PR should be merged after preproduction CI is validated in a private repo~~ [Don't merge] Switch to the @azure/[email protected] and convert JS to TypeScript.

sergey-shandar changed the title ~~[Don't merge] Switch to the @azure/[email protected] and convert JS to TypeScript.~~ Switch to the @azure/[email protected] and convert JS to TypeScript.

sergey-shandar removed the DoNotMerge label

veronicagg changed the title ~~Switch to the @azure/[email protected] and convert JS to TypeScript.~~ [Do not merge] Switch to the @azure/[email protected] and convert JS to TypeScript.

veronicagg changed the title ~~[Do not merge] Switch to the @azure/[email protected] and convert JS to TypeScript.~~ Switch to the @azure/[email protected] and convert JS to TypeScript.

Contributor Author

sergey-shandar commented Apr 23, 2019

Please, review this PR #5742

sergey-shandar closed this

Member

JackTn commented Aug 23, 2021

Hi, @sergey-shandar. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

Member

JackTn commented Jun 16, 2022

Hi, @sergey-shandar. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

2 similar comments

Member

JackTn commented Jun 16, 2022

Hi, @sergey-shandar. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

Member

JackTn commented Jun 16, 2022

Hi, @sergey-shandar. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

JackTn deleted the sergey/scripts branch

July 5, 2022 01:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet