Skip to content

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 13 commits into from
Apr 22, 2019
Merged

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview #5723

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6bc1b8c
Update description of property "destination" in "ImageTemplateFileCus…
Apr 21, 2019
a290d93
Update min and max values of property "buildTimeoutInMinutes"
Apr 21, 2019
9923e7f
Fix a bug to reflect the actual resource naming pattern (which allows…
Apr 21, 2019
4c252d6
Use correct "artifactTags" instead of "tags" for distribute in examples
Apr 21, 2019
6b2ad3c
Fix an example by removing unnecessary field "imageId"
Apr 21, 2019
41c34bc
generate GO SDK for 2019-05-01-preview
Apr 21, 2019
45059cc
Re-generate python SDK
Apr 21, 2019
770176c
fix go sdk for 2019-05-01-preview package
Apr 22, 2019
56e5a9e
Fix example response status codes
Apr 22, 2019
c1299bf
Remove duplicate unreferenced example
Apr 22, 2019
54813d9
Fix update identity example by including identity section in the resp…
Apr 22, 2019
6ff554e
Fix PATCH examples for 202 response
Apr 22, 2019
99fa75e
Fix async operation urls in responses
Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix go sdk for 2019-05-01-preview package
  • Loading branch information
Feiyu Shi committed Apr 22, 2019
commit 770176ce8c82070a2473badf49758af3c2054d70
8 changes: 4 additions & 4 deletions specification/imagebuilder/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ These settings apply only when `--go` is specified on the command line.
batch:
- tag: package-2018-02
- tag: package-2019-02
- tag: package-2019-05
- tag: package-preview-2019-05
```

### Tag: package-2018-02
Expand All @@ -35,11 +35,11 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-02-01-preview/$(namespace)
```

### Tag: package-2019-05
### Tag: package-preview-2019-05

These settings apply only when `--tag=package-2019-05 --go` is specified on the command line.
These settings apply only when `--tag=package-preview-2019-05 --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2019-05' && $(go)
``` yaml $(tag) == 'package-preview-2019-05' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2019-05-01-preview/$(namespace)
```