Update Application Insights Schema to support WorkItemConfig operations #5870

debugthings · 2019-05-06T17:40:52Z

Updating the componentWorkItemConfigs_API.json swagger def to address S360 work item.

Changes

Added PATCH and GET for a specific WorkItemConfig
Added examples for both PATCH and GET
Updated the WorkItemConfigsCreate (POST) example to match new schema
Updated the WorkItemCreateConfiguration schema definition to match what is currently being sent by ARM and what is expected.
- Changed ValidateOnly property to string from boolean to match current implementation
- Changed WorkItemProperties to be a generic dictionary to match current implementation

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-06T17:41:47Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmpytq_4_vn/rest/specification/applicationinsights/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpahxixbbr']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-06T17:41:57Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2022

AutorestCI · 2019-05-06T17:42:12Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2794

azuresdkci · 2019-05-06T17:42:27Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-06T17:43:07Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4768

debugthings · 2019-05-06T17:44:16Z

@TomMilos can you look this over as well to make sure it's good for CDS?

REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit

adxsdknet · 2019-05-06T17:47:39Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6137
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@b87c384
adxsdknet/azure-sdk-for-net@2989561

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json

AutorestCI · 2019-05-06T20:49:20Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json

...sights/resource-manager/Microsoft.Insights/stable/2015-05-01/examples/WorkItemConfigGet.json

majastrz · 2019-05-07T19:53:54Z

"WorkItemCreateConfiguration": {

Just a heads-up, but this resource type schema is a violation of the RPC. Given that this was already available like this, I'm not going to block these changes.

However, ARM API review will block additions of new resource types that are not compliant with the RPC documented at https://github.com/Azure/azure-resource-manager-rpc #Pending

Refers to: specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json:304 in dba4561. [](commit_id = dba4561, deletion_comment = False)

majastrz

I added some comments. Please take a look.

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json

REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit

debugthings · 2019-05-09T19:24:06Z

@dsgouda and @majastrz I've completed the reviewed changes. Please check again and let me know if there are more fixes needed.

majastrz

Looks like all my comments were addressed. Thanks!

dsgouda

LGTM

dsgouda · 2019-05-09T19:52:28Z

@debugthings Pleazse fix the model validation errors reported here

debugthings · 2019-05-09T21:17:34Z

@dsgouda All good now it seems. Thanks for all your help

* .NET SDK Resource Provider:'ApplicationInsights' REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit * .NET SDK Resource Provider:'ApplicationInsights' REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit

…#6137) * .NET SDK Resource Provider:'ApplicationInsights' REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit * .NET SDK Resource Provider:'ApplicationInsights' REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit

debugthings added 7 commits May 6, 2019 09:01

Updating WorkItemConfig API to define GET and PATCH

3d96628

Quick clean up of DELETED schema

ef49556

Updating based on Lint recommendation

98bdd2f

Fixing examples errors

f72b3b5

Fixing Config Object to allow freeform dictionary

3adf0cd

Fixing Config Object to allow freeform dictionary

760ab4c

Fixing Config Object to allow freeform dictionary

dba4561

AutorestCI mentioned this pull request May 6, 2019

[AutoPR applicationinsights/resource-manager] Update Application Insights Schema to support WorkItemConfig operations Azure/azure-sdk-for-python#5089

Merged

AutorestCI mentioned this pull request May 6, 2019

[AutoPR applicationinsights/resource-manager] Update Application Insights Schema to support WorkItemConfig operations Azure/azure-sdk-for-js#2728

Merged

azuresdkci assigned dsgouda May 6, 2019

azuresdkci requested a review from dsgouda May 6, 2019 17:42

AutorestCI mentioned this pull request May 6, 2019

[AutoPR applicationinsights/resource-manager] Update Application Insights Schema to support WorkItemConfig operations Azure/azure-sdk-for-go#4747

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 6, 2019

.NET SDK Resource Provider:'ApplicationInsights'

b87c384

REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit

dsgouda suggested changes May 6, 2019

View reviewed changes

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json Show resolved Hide resolved

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json Show resolved Hide resolved

dsgouda added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 6, 2019

AutorestCI mentioned this pull request May 6, 2019

[AutoPR applicationinsights/resource-manager] Update Application Insights Schema to support WorkItemConfig operations Azure/azure-sdk-for-java#3553

Merged

majastrz reviewed May 7, 2019

View reviewed changes

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json Outdated Show resolved Hide resolved

majastrz reviewed May 7, 2019

View reviewed changes

...sights/resource-manager/Microsoft.Insights/stable/2015-05-01/examples/WorkItemConfigGet.json Outdated Show resolved Hide resolved

majastrz requested changes May 7, 2019

View reviewed changes

majastrz added the ARMChangesRequested label May 7, 2019

TomMilos approved these changes May 7, 2019

View reviewed changes

...ghts/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json Show resolved Hide resolved

jamdavi added 2 commits May 9, 2019 12:09

Suggestions by Tom and Marcin

d56af84

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

0c75f16

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 9, 2019

.NET SDK Resource Provider:'ApplicationInsights'

2989561

REST Spec PR 'Azure/azure-rest-api-specs#5870' REST Spec PR Author 'debugthings' REST Spec PR Last commit

jamdavi added 3 commits May 9, 2019 12:17

Removing extra file from merge

afbfaa9

Merge dumbness

0e5712a

Merge fix

9e4b98f

majastrz approved these changes May 9, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 9, 2019

dsgouda approved these changes May 9, 2019

View reviewed changes

Fixing validation

f02d210

dsgouda merged commit 39f45ec into Azure:master May 9, 2019

Update Application Insights Schema to support WorkItemConfig operations #5870

Update Application Insights Schema to support WorkItemConfig operations #5870

Uh oh!

Conversation

debugthings commented May 6, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

azuresdkci commented May 6, 2019

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

debugthings commented May 6, 2019

Uh oh!

adxsdknet commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

Uh oh!

AutorestCI commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

Uh oh!

Uh oh!

majastrz commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

debugthings commented May 9, 2019

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda commented May 9, 2019

Uh oh!

debugthings commented May 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

adxsdknet commented May 6, 2019 •

edited

Loading

AutorestCI commented May 6, 2019 •

edited

Loading

majastrz commented May 7, 2019 •

edited

Loading