[Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable #5918

eschwabe · 2019-05-10T22:09:37Z

The AzureFrontDoor Service is planning to release the 2019-03-01 WAF API as stable. This PR contains minor validation and documentation changes.

Changes:

Copy preview 2019-03-01 API spec files to stable 2019-03-01
Add SDK checks to restrict the min/max values for rate limiting settings
Update documentation for several rate limiting and match condition fields

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ation

AutorestCI · 2019-05-10T22:10:36Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-05-10T22:10:37Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5719

AutorestCI · 2019-05-10T22:10:46Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3522

AutorestCI · 2019-05-10T22:12:13Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4967

AutorestCI · 2019-05-10T22:30:49Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpvbvpisrt/rest/specification/frontdoor/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpi77i7yhf']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

azuresdkci · 2019-05-10T22:31:38Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5918' REST Spec PR Author 'eschwabe' REST Spec PR Last commit

adxsdknet · 2019-05-10T22:49:10Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6246
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@a998cb9
adxsdknet/azure-sdk-for-net@6de71d8

...n/frontdoor/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json

eschwabe · 2019-05-15T23:56:56Z

@sergey-shandar Could you please review the PR and let me know if any additional sign-offs are required to release this API as stable. Thanks!

specification/frontdoor/resource-manager/Microsoft.Network/stable/2019-03-01/network.json

...n/frontdoor/resource-manager/Microsoft.Network/stable/2019-03-01/webapplicationfirewall.json

REST Spec PR 'Azure/azure-rest-api-specs#5918' REST Spec PR Author 'eschwabe' REST Spec PR Last commit

eschwabe · 2019-05-24T17:22:04Z

@sergey-shandar - Could you please review the latest commit? Thanks!

sanjaiganesh · 2019-06-01T01:19:30Z

I did check with Eric (who created PR). There is no breaking change.. Adding new api with just minor updates in the new api vesrion (Compare iteration 1 and 7, for WebApplicationFirewall.json)

openapi-sdkautomation · 2019-06-03T22:22:28Z

SDK Automation [Logs] (Generated from 36e3078)

Python: Azure/azure-sdk-for-python

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Eric Schwabe added 3 commits May 8, 2019 15:33

Initialize WAF API stable version 2019-03-01

ca9278c

Update readme.md for 2019-04-01 package

b9d9b2e

Add provisioning state enumerations, add validation, and fix document…

8eabf3b

…ation

AutorestCI mentioned this pull request May 10, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for Microsoft.Network to add version preview/2019-03-01-preview Azure/azure-sdk-for-python#5183

Closed

AutorestCI mentioned this pull request May 10, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for Microsoft.Network to add version preview/2019-03-01-preview Azure/azure-sdk-for-js#2815

Closed

eschwabe changed the title ~~[Hub Generated] Review request for Microsoft.Network to add version preview/2019-03-01-preview~~ [Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable May 10, 2019

AutorestCI mentioned this pull request May 10, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for Microsoft.Network to add version preview/2019-03-01-preview Azure/azure-sdk-for-go#4775

Merged

azuresdkci assigned sergey-shandar May 10, 2019

azuresdkci requested a review from sergey-shandar May 10, 2019 22:32

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 10, 2019

.NET SDK Resource Provider:'FrontDoor'

a998cb9

REST Spec PR 'Azure/azure-rest-api-specs#5918' REST Spec PR Author 'eschwabe' REST Spec PR Last commit

Remove FrontDoor README and assets

b21ad6c

eschwabe commented May 13, 2019

View reviewed changes

...n/frontdoor/resource-manager/Microsoft.Network/stable/2019-04-01/webapplicationfirewall.json Show resolved Hide resolved

sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels May 20, 2019

sergey-shandar reviewed May 20, 2019

View reviewed changes

Revert model changes for provisioning state

8b34fd2

AutorestCI mentioned this pull request May 21, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable Azure/azure-sdk-for-js#3075

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 22, 2019

.NET SDK Resource Provider:'FrontDoor'

6de71d8

REST Spec PR 'Azure/azure-rest-api-specs#5918' REST Spec PR Author 'eschwabe' REST Spec PR Last commit

Eric Schwabe added 2 commits May 29, 2019 09:37

Merge branch 'master' into dev-frontdoor-Microsoft.Network-2019-03-01

6ce7b94

Merge formatting changes in WAF API examples

89905fc

AutorestCI mentioned this pull request May 29, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable Azure/azure-sdk-for-python#5518

Closed

AutorestCI mentioned this pull request May 29, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable Azure/azure-sdk-for-js#3254

Closed

eschwabe requested a review from sergey-shandar May 31, 2019 15:43

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 1, 2019

Minor documentation change to re-trigger merge validation.

36e3078

sergey-shandar approved these changes Jun 6, 2019

View reviewed changes

sergey-shandar merged commit 8aae8c1 into Azure:master Jun 6, 2019

AutorestCI mentioned this pull request Jun 6, 2019

[AutoPR frontdoor/resource-manager] [Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable Azure/azure-sdk-for-js#3521

Merged

[Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable #5918

[Hub Generated] Review request for FrontDoor WAF to add version 2019-03-01 stable #5918

Uh oh!

Conversation

eschwabe commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented May 10, 2019

Uh oh!

adxsdknet commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

eschwabe commented May 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eschwabe commented May 24, 2019

Uh oh!

sanjaiganesh commented Jun 1, 2019

Uh oh!

openapi-sdkautomation bot commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from 36e3078)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eschwabe commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

AutorestCI commented May 10, 2019 •

edited

Loading

adxsdknet commented May 10, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 3, 2019 •

edited

Loading