Skip to content

Conversation

@simanor
Copy link
Contributor

@simanor simanor commented May 27, 2019

  • examples

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • [+] I have reviewed the documentation for the workflow.
  • [+] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [+] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 27, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented May 27, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented May 27, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5697

@AutorestCI
Copy link

AutorestCI commented May 27, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpl8btw55b/rest/specification/alertsmanagement/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpce5lx9p5']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@simanor
Copy link
Contributor Author

simanor commented May 27, 2019

Hello,
Here's a link to the approved PR in azure-rest-api-specs-pr: https://github.com/Azure/azure-rest-api-specs-pr/pull/734

Thank you

@AutorestCI
Copy link

AutorestCI commented May 27, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@YairoR
Copy link

YairoR commented Jun 4, 2019

Hi, any update with that?

@sarangan12
Copy link
Contributor

New changes added. Tagging ARM Team for Approval

@sarangan12 sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 4, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be identical to the ARM reviewed API from pr repo

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 5, 2019
@sarangan12 sarangan12 merged commit 5946db9 into Azure:master Jun 5, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 5, 2019

SDK Automation [Logs] (Generated from f4b30b3)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
…er Microsoft.Workloads RP (#6124)

* Adding New API in Swagger and Examples

* Modifying Ouput - Sending base disk details instead of Cumulatie

* Resolving review comments

* Adding deploymentType Property in input

* Removing few required fields from phpWorkloads

* removing duplicate 'Wordpress'.

* Updating examples

Co-authored-by: shishir-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants