[Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand #6204

hvermis · 2019-06-04T00:40:36Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-06-04T00:40:38Z

SDK Automation [Logs] (Generated from e4bd347)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

AutorestCI · 2019-06-04T00:41:22Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-04T00:42:01Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpnfwkb73n/rest/specification/datafactory/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmptt28llkw']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-06-04T00:42:34Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5747

AutorestCI · 2019-06-04T00:50:47Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4975

azuresdkci · 2019-06-04T01:02:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-06-04T01:13:24Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3577

KrisBash

Please see questions regarding adding properties within API version

KrisBash · 2019-06-05T02:34:30Z

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json

            "$ref": "#/definitions/ScriptAction"
          }
+        },
+        "virtualNetworkId": {


When adding properties within an API version, there is risk if the properties are updated by a current version client, but then the resource is modified by a down-level client. This is not strictly a breaking change, but you certainly have more control against accidental overwrite if exposed in a new API version. What is the behavior on the service if an update excludes these properties after they have been previously defined?

We are aware of these scenarios, and our customers also are used to these kinds of updates. We keep adding new features all the time, and they result in new properties, so adding new API version time is not feasible. The service overwrites the entities. This affects our SDK and Rest API users, but they are already aware of this, and keep getting new SDK versions when they want to use new properties. In fact, these changes are to catch up with our UX support.

KrisBash

LGTM

hvermis · 2019-06-06T03:09:58Z

@tjprescott Can you please merge this?

ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand

e4bd347

azuresdkci assigned tjprescott Jun 4, 2019

azuresdkci requested a review from tjprescott June 4, 2019 00:41

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR datafactory/resource-manager] [Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand Azure/azure-sdk-for-python#5663

Merged

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR datafactory/resource-manager] [Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand Azure/azure-sdk-for-go#4947

Merged

AutorestCI mentioned this pull request Jun 4, 2019

[AutoPR datafactory/resource-manager] [Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand Azure/azure-sdk-for-js#3423

Closed

tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 4, 2019

KrisBash suggested changes Jun 5, 2019

View reviewed changes

KrisBash added the ARMChangesRequested label Jun 5, 2019

KrisBash approved these changes Jun 6, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2019

tjprescott approved these changes Jun 7, 2019

View reviewed changes

tjprescott merged commit 0489820 into Azure:master Jun 7, 2019

AutorestCI mentioned this pull request Jun 7, 2019

[AutoPR datafactory/resource-manager] [Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand Azure/azure-sdk-for-js#3576

Merged

[Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand #6204

[Datafactory] ADLS Gen 2 support for HDI BYOC and vNet support for HDI on demand #6204

Uh oh!

Conversation

hvermis commented Jun 4, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from e4bd347)

Uh oh!

AutorestCI commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Jun 4, 2019

Uh oh!

AutorestCI commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

KrisBash Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

hvermis Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

KrisBash Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

hvermis commented Jun 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-sdkautomation bot commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading

AutorestCI commented Jun 4, 2019 •

edited

Loading