Skip to content

typo: botservice #6418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergey-shandar merged 1 commit into from
Jul 1, 2019
Merged

typo: botservice #6418

sergey-shandar merged 1 commit into from
Jul 1, 2019

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jun 22, 2019

Double word "service"

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 63856b1)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 22, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 22, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 22, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6070

@AutorestCI
Copy link

AutorestCI commented Jun 22, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 22, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5173

@azuresdkci azuresdkci requested a review from michaeljqzq June 22, 2019 16:32
@azuresdkci
Copy link
Contributor

azuresdkci commented Jun 22, 2019

Can one of the admins verify this patch?

@michaeljqzq
Copy link
Contributor

michaeljqzq commented Jun 24, 2019

Please fix CI tasks

@nschonni
Copy link
Contributor Author

nschonni commented Jun 24, 2019

@michaeljqzq I'm not an MS employee, so I'm not sure what the correct fixes are for the READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST errors. I've PR'd model validation fixes before, but this case it could either be an issue with the example or with the spec, and i'm not someone that could make that call

@michaeljqzq
Copy link
Contributor

michaeljqzq commented Jun 26, 2019

The Bots_Create operation is a put operation, and in the example it includes the property id which is defined as readOnly in the spec. This is not allowed

@nschonni
Copy link
Contributor Author

nschonni commented Jun 26, 2019

@michaeljqzq I'm just making a documentation change here. I can't fix service issues in this PR as I'm not a Microsoft employee

@michaeljqzq
Copy link
Contributor

michaeljqzq commented Jun 27, 2019

@sergey-shandar Could you help merge this PR? Although the model validation failed, the changes here have nothing to do with that part

@michaeljqzq
Copy link
Contributor

michaeljqzq commented Jun 27, 2019

@carlosscastro Hi, I saw you were the first contributor for the swagger file. Are you still working with that? Could you see and try fixing the model validation error in the examples? Thanks

@nschonni
typo: botservice
63856b1 
Double word "service"
@sergey-shandar sergey-shandar merged commit b04e1a6 into Azure:master Jul 1, 2019
@nschonni nschonni deleted the typo--botservice branch July 1, 2019 21:57
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@nschonni @celikcigdem
typo: botservice (Azure#6418)
8a4921d 
Double word "service"
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@yunho-microsoft
Frs stable ver (Azure#6418)
36a3f16 
* copy 2021-09-10-preview from preview to stable

* rename folder 2021-09-10-preview to 2022-02-15

* change api version to 02-15 (copy ping's change)

* update readme (copy from ping's change)

Co-authored-by: Yunpeng Hou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaeljqzq michaeljqzq Awaiting requested review from michaeljqzq

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michaeljqzq michaeljqzq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nschonni @AutorestCI @azuresdkci @michaeljqzq @sergey-shandar