Skip to content

Enable sub/nitegupt #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergey-shandar merged 2 commits into from
Jul 15, 2019
Merged

Enable sub/nitegupt #6591

sergey-shandar merged 2 commits into from
Jul 15, 2019

Conversation

@nitegupt
Copy link
Contributor

@nitegupt nitegupt commented Jul 11, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 11, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 9e09d2f, Iteration 1)

Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Jul 11, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 11, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5748

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 11, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 11, 2019

Can one of the admins verify this patch?

ryansbenson
ryansbenson approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 11, 2019
@sergey-shandar sergey-shandar merged commit 23561ae into Azure:master Jul 15, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@nitegupt @celikcigdem
Enable sub/nitegupt (Azure#6591)
699aac9 
* Add enable subscription api.

* Update subscriptions.json
nitegupt added a commit to nitegupt/azure-rest-api-specs that referenced this pull request Aug 1, 2019
@nitegupt
Revert "Enable sub/nitegupt (Azure#6591)"
f9cad62 
This reverts commit 23561ae.
yaohaizh pushed a commit that referenced this pull request Aug 6, 2019
@nitegupt @yaohaizh
Revert "Enable sub/nitegupt (#6591)" (#6845)
f18d995 
This reverts commit 23561ae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson approved these changes

+1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nitegupt @AutorestCI @azuresdkci @sergey-shandar @ryansbenson