Skip to content

Nasingla/nugetupdate #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahabhijeet merged 9 commits into from
Jul 30, 2019
Merged

Nasingla/nugetupdate #6673

shahabhijeet merged 9 commits into from
Jul 30, 2019

Conversation

@navysingla
Copy link
Contributor

@navysingla navysingla commented Jul 18, 2019 •
edited
Loading

Following changes are made in this PR -

  • Fixing textual description changes that are breaking SDK build
  • Changing parameter names to have unique names across versions
  • Removing operations API for two versions as it is already in 2018-03-01-preview
  • Moving operations API in operations.json from Subscriptions.json

@navysingla
Merge pull request #1 from Azure/master
e499d0f 
Merging from Azure to nasingla fork
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 18, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from be9b791, Iteration 10)

In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress Python: Azure/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress JavaScript: Azure/azure-sdk-for-js [Logs]
  • Package generation in progress.

@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5748

@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 18, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5383

@azuresdkci azuresdkci requested a review from shahabhijeet July 18, 2019 23:55
@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 19, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 22, 2019
Merged
lmazuel
lmazuel approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you include specification/subscription/resource-manager/Microsoft.Subscription/preview/2018-03-01-preview/operations.json in the tag?
Otherwise, LGTM

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 26, 2019
Merged
@navysingla navysingla force-pushed the nasingla/nugetupdate branch from 7ae6903 to e7db358 Compare July 27, 2019 00:18
@AutorestCI AutorestCI mentioned this pull request Jul 27, 2019
Merged
@shahabhijeet
Copy link
Contributor

shahabhijeet commented Jul 29, 2019

@navysingla there are still conflicting files

@navysingla navysingla force-pushed the nasingla/nugetupdate branch from e7db358 to bd003a6 Compare July 29, 2019 18:13
@shahabhijeet shahabhijeet merged commit 72c1b69 into Azure:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel approved these changes

+1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shahabhijeet shahabhijeet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@navysingla @AutorestCI @azuresdkci @shahabhijeet @lmazuel