Skip to content

fix: Microsoft.Sql model validation errors #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaeljqzq merged 2 commits into from
Aug 1, 2019
Merged

fix: Microsoft.Sql model validation errors #6704

michaeljqzq merged 2 commits into from
Aug 1, 2019

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 23, 2019 •
edited
Loading

  • Remove "description" not it schema
  • Remove empty "body" for RESPONSE_SCHEMA_NOT_IN_SPEC errors
  • IsAzureMonitorTargetEnabled -> isAzureMonitorTargetEnabled
  • "State" -> "state"
  • emailAccountAdmins "true" -> true
  • Add 202 response for RestorePoints_Create
  • password -> certPassword for ManagedInstanceTdeCertificates_Create and TdeCertificates_Create

@nschonni
fix: Microsoft.Sql/stable/2014-04-01 model validation
0feaeac 
- RESPONSE_SCHEMA_NOT_IN_SPEC
- RESPONSE_BODY_NOT_IN_EXAMPLE
- Remove "description" not it schema
Other issues not resolved
@nschonni nschonni requested a review from jaredmoo as a code owner July 23, 2019 05:44
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 23, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 368b591, Iteration 5)

Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5771

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5404

@azuresdkci azuresdkci requested a review from mybayern1974 July 23, 2019 06:38
@azuresdkci
Copy link
Contributor

azuresdkci commented Jul 23, 2019

Can one of the admins verify this patch?

@nschonni
Copy link
Contributor Author

nschonni commented Jul 31, 2019 •
edited
Loading

Found a few in the other sql versions, I'll try and add them to this PR. If you land this one, I can just submit them separately though

This was referenced Jul 31, 2019
Merged
Merged
Merged
Merged
Closed
Merged
@nschonni
fix: sql preview model validation errors
368b591 
- Remove empty "body" for RESPONSE_SCHEMA_NOT_IN_SPEC errors
- IsAzureMonitorTargetEnabled -> isAzureMonitorTargetEnabled
- "State" -> "state"
- emailAccountAdmins "true" -> true
- Add 202 response for RestorePoints_Create
- password -> certPassword for ManagedInstanceTdeCertificates_Create and TdeCertificates_Create
@nschonni
Copy link
Contributor Author

nschonni commented Jul 31, 2019

@jaredmoo I pushed updates to the preview specs in a separate commit if you want to take a look. I can also split those off to another PR if you prefer

This was referenced Jul 31, 2019
Merged
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 31, 2019
Merged
@nschonni nschonni changed the title fix: Microsoft.Sql/stable/2014-04-01 model validation fix: Microsoft.Sql model validation errors Jul 31, 2019
@PhoenixHe-NV
Copy link

PhoenixHe-NV commented Jul 31, 2019

@OpenAPIBot sdkautomation rebuild

@michaeljqzq michaeljqzq merged commit 35de9f3 into Azure:master Aug 1, 2019
@nschonni nschonni deleted the fix--Microsoft.Sql/stable/2014-04-01-model-validation branch August 1, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mybayern1974 mybayern1974 Awaiting requested review from mybayern1974

2 more reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@michaeljqzq michaeljqzq michaeljqzq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michaeljqzq michaeljqzq

@mybayern1974 mybayern1974

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nschonni @AutorestCI @azuresdkci @PhoenixHe-NV @jaredmoo @michaeljqzq @mybayern1974