Skip to content

Conversation

@dosegal
Copy link
Contributor

@dosegal dosegal commented Jul 29, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 29, 2019

In Testing, Please Ignore

[Logs] (Generated from d8bd7aa, Iteration 10)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5722

@AutorestCI
Copy link

AutorestCI commented Jul 29, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5480

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@dosegal dosegal marked this pull request as ready for review July 30, 2019 15:22
}
],
"responses": {
"201": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

201 [](start = 11, length = 3)

It should return either 200 if was an update to existing one and 201 if it's created a new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I'm aware. The put endpoint supports only creation in the server side and modification is not allowed. so this why 200 is not part of the response.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 1, 2019
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARM side with a comment.

@dosegal
Copy link
Contributor Author

dosegal commented Aug 6, 2019

@lirenhe could you please merge?

@lirenhe lirenhe merged commit 9986fe0 into Azure:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants