Skip to content

Add managedInstaceAdministrators.json to readme file, which reprepres… #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhendrixMSFT merged 2 commits into from
Aug 15, 2019
Merged

Add managedInstaceAdministrators.json to readme file, which reprepres… #6852

jhendrixMSFT merged 2 commits into from
Aug 15, 2019

Conversation

@SanjaMalesevic
Copy link
Contributor

@SanjaMalesevic SanjaMalesevic commented Aug 2, 2019

…ents AutoRest configuration file for Sql

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from dea881c, Iteration 2)

In-Progress .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • Package generation in progress.
In-Progress Python: test-repo-billy/azure-sdk-for-python [Logs]
  • Package generation in progress.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs]
  • Package generation in progress.
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • Package generation in progress.
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from sarangan12 August 2, 2019 09:57
@AutorestCI AutorestCI mentioned this pull request Aug 2, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 2, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5771

@AutorestCI
Copy link

AutorestCI commented Aug 2, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5530

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 2, 2019

Can one of the admins verify this patch?

@sarangan12 sarangan12 removed their request for review August 14, 2019 13:25
@sarangan12 sarangan12 removed their assignment Aug 14, 2019
jaredmoo
jaredmoo suggested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add file to:

  • package-composite-v3
  • package-composite-v2
  • package-composite-v1
  • package-pure-2017-03-preview

@SanjaMalesevic
Add missing json to package-composite-v2, package-composite-v1, packa…
dea881c 
…ge-pure-2017-03-preview and package-2017-03-preview
@AutorestCI AutorestCI mentioned this pull request Aug 15, 2019
Merged
@SanjaMalesevic
Copy link
Contributor Author

SanjaMalesevic commented Aug 15, 2019

Please add file to:

  • package-composite-v3
  • package-composite-v2
  • package-composite-v1
  • package-pure-2017-03-preview

This is added now.

@jhendrixMSFT jhendrixMSFT merged commit 152934e into Azure:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

+1 more reviewer

@jaredmoo jaredmoo jaredmoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhendrixMSFT jhendrixMSFT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SanjaMalesevic @AutorestCI @azuresdkci @jaredmoo @jhendrixMSFT @sarangan12