Skip to content

Adding alertRuleTemplates swagger spec to securityInsight #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaeljqzq merged 8 commits into from
Aug 15, 2019
Merged

Adding alertRuleTemplates swagger spec to securityInsight #6942

michaeljqzq merged 8 commits into from
Aug 15, 2019

Conversation

@sagamzu
Copy link
Contributor

@sagamzu sagamzu commented Aug 13, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from e5ddbaf, Iteration 10)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
  • No packages generated.
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from michaeljqzq August 13, 2019 06:00
@AutorestCI AutorestCI mentioned this pull request Aug 13, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5722

@AutorestCI AutorestCI mentioned this pull request Aug 13, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5505

@azuresdkci
Copy link
Contributor

azuresdkci commented Aug 13, 2019

Can one of the admins verify this patch?

@sagamzu sagamzu marked this pull request as ready for review August 13, 2019 10:56
@ryansbenson ryansbenson added ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 13, 2019
ryansbenson
ryansbenson approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from ARMs side

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2019
@michaeljqzq michaeljqzq merged commit 9547714 into Azure:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson approved these changes

@michaeljqzq michaeljqzq Awaiting requested review from michaeljqzq

+1 more reviewer

@nirgfani nirgfani nirgfani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@michaeljqzq michaeljqzq

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sagamzu @AutorestCI @azuresdkci @ryansbenson @nirgfani @michaeljqzq